From: Al Viro <viro@zeniv.linux.org.uk>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] fscontext: do not consume log entries when returning -EMSGSIZE
Date: Wed, 6 Aug 2025 20:07:51 +0100 [thread overview]
Message-ID: <20250806190751.GG222315@ZenIV> (raw)
In-Reply-To: <20250807-fscontext-log-cleanups-v3-1-8d91d6242dc3@cyphar.com>
On Thu, Aug 07, 2025 at 03:55:23AM +1000, Aleksa Sarai wrote:
> - goto err_free;
> - ret = -EFAULT;
> - if (copy_to_user(_buf, p, n) != 0)
> - goto err_free;
> + if (copy_to_user(_buf, p, n))
> + n = -EFAULT;
> ret = n;
> -
> -err_free:
> if (need_free)
> kfree(p);
> return ret;
Minor nit: seeing that there's only one path to that return, I would
rather turn it into
return n;
and dropped the assignment to ret a few lines above. Anyway, that's
trivially done when applying...
Anyway, who's carrying fscontext-related stuff this cycle? I've got
a short series in that area, but there won't be much from me around
there - a plenty of tree-in-dcache stuff, quite a bit of mount-related
work, etc., but not a lot around the options-parsing machinery.
Christian, do you have any plans around that area?
next prev parent reply other threads:[~2025-08-06 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 17:55 [PATCH v3 0/2] fscontext: do not consume log entries when returning -EMSGSIZE Aleksa Sarai
2025-08-06 17:55 ` [PATCH v3 1/2] " Aleksa Sarai
2025-08-06 19:07 ` Al Viro [this message]
2025-08-07 2:46 ` Aleksa Sarai
2025-08-07 3:08 ` Al Viro
2025-08-08 13:52 ` Christian Brauner
2025-08-06 17:55 ` [PATCH v3 2/2] selftests/filesystems: add basic fscontext log tests Aleksa Sarai
2025-08-08 14:06 ` [PATCH v3 0/2] fscontext: do not consume log entries when returning -EMSGSIZE Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806190751.GG222315@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).