linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* selftests/futex: issue with -g option help text
@ 2025-08-08 10:40 Colin King (gmail)
  2025-08-08 10:54 ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 4+ messages in thread
From: Colin King (gmail) @ 2025-08-08 10:40 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior, Darren Hart, Davidlohr Bueso,
	Ingo Molnar, Thomas Gleixner, Peter Zijlstra, Shuah Khan,
	open list:KERNEL SELFTEST FRAMEWORK
  Cc: linux-kernel@vger.kernel.org


[-- Attachment #1.1.1: Type: text/plain, Size: 953 bytes --]

Hi,

I found some text that contains a spelling mistake, however I can't 
parse the message either, so I'm reporting this as a minor issue that 
needs some attention.

The issue is found in commit:

commit cda95faef7bcf26ba3f54c3cddce66d50116d146
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date:   Wed Apr 16 18:29:20 2025 +0200

     selftests/futex: Add futex_priv_hash


Namely:

static void usage(char *prog)
{
         printf("Usage: %s\n", prog);
         printf("  -c    Use color\n");
         printf("  -g    Test global hash instead intead local immutable 
\n");
         printf("  -h    Display this help message\n");
         printf("  -v L  Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
                VQUIET, VCRITICAL, VINFO);
}


there word "intead" for the -g option should be removed, but I'm also 
finding the resulting text hard to parse, perhaps it needs to be rephrased?

Colin

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: selftests/futex: issue with -g option help text
  2025-08-08 10:40 selftests/futex: issue with -g option help text Colin King (gmail)
@ 2025-08-08 10:54 ` Sebastian Andrzej Siewior
  2025-08-08 11:01   ` Colin King (gmail)
  0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2025-08-08 10:54 UTC (permalink / raw)
  To: Colin King (gmail)
  Cc: Darren Hart, Davidlohr Bueso, Ingo Molnar, Thomas Gleixner,
	Peter Zijlstra, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK,
	linux-kernel@vger.kernel.org

On 2025-08-08 11:40:23 [+0100], Colin King (gmail) wrote:
> Hi,
Hi,

> Namely:
> 
> static void usage(char *prog)
> {
>         printf("Usage: %s\n", prog);
>         printf("  -c    Use color\n");
>         printf("  -g    Test global hash instead intead local immutable
> \n");
>         printf("  -h    Display this help message\n");
>         printf("  -v L  Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
>                VQUIET, VCRITICAL, VINFO);
> }
> 
> 
> there word "intead" for the -g option should be removed, but I'm also
> finding the resulting text hard to parse, perhaps it needs to be rephrased?

   Test global hash instead instead private hash

?

> Colin

Sebastian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: selftests/futex: issue with -g option help text
  2025-08-08 10:54 ` Sebastian Andrzej Siewior
@ 2025-08-08 11:01   ` Colin King (gmail)
  2025-08-08 11:16     ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 4+ messages in thread
From: Colin King (gmail) @ 2025-08-08 11:01 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: Darren Hart, Davidlohr Bueso, Ingo Molnar, Thomas Gleixner,
	Peter Zijlstra, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK,
	linux-kernel@vger.kernel.org


[-- Attachment #1.1.1: Type: text/plain, Size: 880 bytes --]

Hi,

On 08/08/2025 11:54, Sebastian Andrzej Siewior wrote:
> On 2025-08-08 11:40:23 [+0100], Colin King (gmail) wrote:
>> Hi,
> Hi,
> 
>> Namely:
>>
>> static void usage(char *prog)
>> {
>>          printf("Usage: %s\n", prog);
>>          printf("  -c    Use color\n");
>>          printf("  -g    Test global hash instead intead local immutable
>> \n");
>>          printf("  -h    Display this help message\n");
>>          printf("  -v L  Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
>>                 VQUIET, VCRITICAL, VINFO);
>> }
>>
>>
>> there word "intead" for the -g option should be removed, but I'm also
>> finding the resulting text hard to parse, perhaps it needs to be rephrased?
> 
>     Test global hash instead instead private hash

Surely:
	Test global hash instead of private hash

> 
> ?
> 
>> Colin
> 
> Sebastian


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: selftests/futex: issue with -g option help text
  2025-08-08 11:01   ` Colin King (gmail)
@ 2025-08-08 11:16     ` Sebastian Andrzej Siewior
  0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2025-08-08 11:16 UTC (permalink / raw)
  To: Colin King (gmail)
  Cc: Darren Hart, Davidlohr Bueso, Ingo Molnar, Thomas Gleixner,
	Peter Zijlstra, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK,
	linux-kernel@vger.kernel.org

On 2025-08-08 12:01:49 [+0100], Colin King (gmail) wrote:
> Hi,
Hi,

> > 
> >     Test global hash instead instead private hash
> 
> Surely:
> 	Test global hash instead of private hash

Thanks.
There must be an issue with my keyboard.

> > 
> > ?
> > 
> > > Colin

Sebastian

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-08 11:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-08 10:40 selftests/futex: issue with -g option help text Colin King (gmail)
2025-08-08 10:54 ` Sebastian Andrzej Siewior
2025-08-08 11:01   ` Colin King (gmail)
2025-08-08 11:16     ` Sebastian Andrzej Siewior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).