* [PATCH] selftests/futex: fix typos and grammar in futex_priv_hash
@ 2025-08-15 9:39 Gopi Krishna Menon
2025-08-19 7:55 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: Gopi Krishna Menon @ 2025-08-15 9:39 UTC (permalink / raw)
To: tglx
Cc: Gopi Krishna Menon, mingo, peterz, dvhart, dave, andrealmeid,
shuah, bigeasy, linux-kernel, linux-kselftest, skhan,
linux-kernel-mentees
Fix multiple typos and small grammar issues in help text,
comments and test messages in futex_priv_hash test.
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
.../selftests/futex/functional/futex_priv_hash.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/futex/functional/futex_priv_hash.c b/tools/testing/selftests/futex/functional/futex_priv_hash.c
index 2dca18fefedc..4a7dea008314 100644
--- a/tools/testing/selftests/futex/functional/futex_priv_hash.c
+++ b/tools/testing/selftests/futex/functional/futex_priv_hash.c
@@ -115,7 +115,7 @@ static void usage(char *prog)
{
printf("Usage: %s\n", prog);
printf(" -c Use color\n");
- printf(" -g Test global hash instead intead local immutable \n");
+ printf(" -g Test global hash instead of local immutable hash\n");
printf(" -h Display this help message\n");
printf(" -v L Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
VQUIET, VCRITICAL, VINFO);
@@ -180,7 +180,7 @@ int main(int argc, char *argv[])
if (ret != 0)
ksft_exit_fail_msg("pthread_join() failed: %d, %m\n", ret);
- /* First thread, has to initialiaze private hash */
+ /* First thread, has to initialize private hash */
futex_slots1 = futex_hash_slots_get();
if (futex_slots1 <= 0) {
ksft_print_msg("Current hash buckets: %d\n", futex_slots1);
@@ -232,17 +232,17 @@ int main(int argc, char *argv[])
futex_hash_slots_set_verify(2);
join_max_threads();
- ksft_test_result(counter == MAX_THREADS, "Created of waited for %d of %d threads\n",
+ ksft_test_result(counter == MAX_THREADS, "Created and waited for %d of %d threads\n",
counter, MAX_THREADS);
counter = 0;
- /* Once the user set something, auto reisze must be disabled */
+ /* Once the user set something, auto resize must be disabled */
ret = pthread_barrier_init(&barrier_main, NULL, MAX_THREADS);
create_max_threads(thread_lock_fn);
join_max_threads();
ret = futex_hash_slots_get();
- ksft_test_result(ret == 2, "No more auto-resize after manaul setting, got %d\n",
+ ksft_test_result(ret == 2, "No more auto-resize after manual setting, got %d\n",
ret);
futex_hash_slots_set_must_fail(1 << 29, 0);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/futex: fix typos and grammar in futex_priv_hash
2025-08-15 9:39 [PATCH] selftests/futex: fix typos and grammar in futex_priv_hash Gopi Krishna Menon
@ 2025-08-19 7:55 ` Sebastian Andrzej Siewior
2025-08-19 15:57 ` [PATCH v2] " Gopi Krishna Menon
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2025-08-19 7:55 UTC (permalink / raw)
To: Gopi Krishna Menon
Cc: tglx, mingo, peterz, dvhart, dave, andrealmeid, shuah,
linux-kernel, linux-kselftest, skhan, linux-kernel-mentees
On 2025-08-15 15:09:39 [+0530], Gopi Krishna Menon wrote:
> --- a/tools/testing/selftests/futex/functional/futex_priv_hash.c
> +++ b/tools/testing/selftests/futex/functional/futex_priv_hash.c
> @@ -115,7 +115,7 @@ static void usage(char *prog)
> {
> printf("Usage: %s\n", prog);
> printf(" -c Use color\n");
> - printf(" -g Test global hash instead intead local immutable \n");
> + printf(" -g Test global hash instead of local immutable hash\n");
> printf(" -h Display this help message\n");
> printf(" -v L Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
> VQUIET, VCRITICAL, VINFO);
This hunk is addressed by
https://lore.kernel.org/all/20250808112458.831212-1-colin.i.king@gmail.com/
the other are fine.
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] selftests/futex: fix typos and grammar in futex_priv_hash
2025-08-19 7:55 ` Sebastian Andrzej Siewior
@ 2025-08-19 15:57 ` Gopi Krishna Menon
0 siblings, 0 replies; 3+ messages in thread
From: Gopi Krishna Menon @ 2025-08-19 15:57 UTC (permalink / raw)
To: tglx
Cc: Gopi Krishna Menon, mingo, peterz, dvhart, dave, andrealmeid,
shuah, bigeasy, linux-kernel, linux-kselftest, skhan,
linux-kernel-mentees
Fix multiple typos and small grammar issues in help text,
comments and test messages in futex_priv_hash test.
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changelog :
Changes since v1:
- Dropped hunk which is already addressed by
https://lore.kernel.org/all/20250808112458.831212-1-colin.i.king@gmail.com/
Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
.../testing/selftests/futex/functional/futex_priv_hash.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/futex/functional/futex_priv_hash.c b/tools/testing/selftests/futex/functional/futex_priv_hash.c
index 2dca18fefedc..67be60a8238d 100644
--- a/tools/testing/selftests/futex/functional/futex_priv_hash.c
+++ b/tools/testing/selftests/futex/functional/futex_priv_hash.c
@@ -180,7 +180,7 @@ int main(int argc, char *argv[])
if (ret != 0)
ksft_exit_fail_msg("pthread_join() failed: %d, %m\n", ret);
- /* First thread, has to initialiaze private hash */
+ /* First thread, has to initialize private hash */
futex_slots1 = futex_hash_slots_get();
if (futex_slots1 <= 0) {
ksft_print_msg("Current hash buckets: %d\n", futex_slots1);
@@ -232,17 +232,17 @@ int main(int argc, char *argv[])
futex_hash_slots_set_verify(2);
join_max_threads();
- ksft_test_result(counter == MAX_THREADS, "Created of waited for %d of %d threads\n",
+ ksft_test_result(counter == MAX_THREADS, "Created and waited for %d of %d threads\n",
counter, MAX_THREADS);
counter = 0;
- /* Once the user set something, auto reisze must be disabled */
+ /* Once the user set something, auto resize must be disabled */
ret = pthread_barrier_init(&barrier_main, NULL, MAX_THREADS);
create_max_threads(thread_lock_fn);
join_max_threads();
ret = futex_hash_slots_get();
- ksft_test_result(ret == 2, "No more auto-resize after manaul setting, got %d\n",
+ ksft_test_result(ret == 2, "No more auto-resize after manual setting, got %d\n",
ret);
futex_hash_slots_set_must_fail(1 << 29, 0);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-19 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-15 9:39 [PATCH] selftests/futex: fix typos and grammar in futex_priv_hash Gopi Krishna Menon
2025-08-19 7:55 ` Sebastian Andrzej Siewior
2025-08-19 15:57 ` [PATCH v2] " Gopi Krishna Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).