From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F15214A6A; Tue, 19 Aug 2025 16:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755620870; cv=none; b=BlkAVVH4bCk68j5EYPW8Qb1449xo5Osa5yVY36jBcBrea45PczsSSTu90WzJdsuZbHYNlHScU7cItbsChtVqitUsbVAdTXFumbS3DBJcaZ+VgpqYV/qLY/EtydbhvSCwbvwQyx3ld9wA42Dnr7Fao2SbQooyZYt25paNNwYEvHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755620870; c=relaxed/simple; bh=XMiGAtjdArL2gbxrFhicE4t6Y0M2WueXT37wxBI+sMo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WUPSYU9GW9n9isBShxbk0hoicK7d52P+JM630AgsUmbhybGI9fREwvCuEEvsi9yqwN1kS72rq7CR3GWto0lpadEX4gpQ3rCGOijgFh6nVmNs3g7k9lyN9jVJQ/BF1js4A3Rbz42gfCoAvooNrPQExW3yGtLN7ByHsodbBJwN1zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d+JxJLh0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d+JxJLh0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4548C4CEF1; Tue, 19 Aug 2025 16:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755620870; bh=XMiGAtjdArL2gbxrFhicE4t6Y0M2WueXT37wxBI+sMo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=d+JxJLh0SJwTYUA/93AwSF8/tSdgXyMP64Ee2L9v21GpDJfx6w7p6UhNbvZ8c3PlI U0UqU95hhUUXMyVj2PatjtyX52YZK4V/I2f3ZXp0nUAh1jdj7ND1/xPzbCU8Z6IRRB 4dQBbY+wrU2+ONNJyLFf/vkic+aEul8gY+f+5XhTsdUZLc95O87D/Z4+jB3YtSrG46 /+d17fgrPiBibwGCNduRlOZsC96KtL03FdVR8LXmcIDyC9J4qts9HT3A5/QExxu/7t MjuCXNQZUQtQJB56ar/27kNiUD8s2sC5vamPySyD2tAvmuWU2W/IJH5de3xfs8ADOr gUsybBVi/CFQg== From: Mark Brown Date: Tue, 19 Aug 2025 17:21:52 +0100 Subject: [PATCH v19 6/8] selftests/clone3: Factor more of main loop into test_clone3() Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250819-clone3-shadow-stack-v19-6-bc957075479b@kernel.org> References: <20250819-clone3-shadow-stack-v19-0-bc957075479b@kernel.org> In-Reply-To: <20250819-clone3-shadow-stack-v19-0-bc957075479b@kernel.org> To: "Rick P. Edgecombe" , Deepak Gupta , Szabolcs Nagy , "H.J. Lu" , Florian Weimer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Brauner , Shuah Khan Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , jannh@google.com, bsegall@google.com, Andrew Morton , Yury Khrustalev , Wilco Dijkstra , linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, Mark Brown , Kees Cook , Kees Cook , Shuah Khan X-Mailer: b4 0.15-dev-cff91 X-Developer-Signature: v=1; a=openpgp-sha256; l=3987; i=broonie@kernel.org; h=from:subject:message-id; bh=XMiGAtjdArL2gbxrFhicE4t6Y0M2WueXT37wxBI+sMo=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBopKXTExHE/eEr4zmk/VVQse1Hz6TRf2NQFW+Cr 5OlXUREwr6JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaKSl0wAKCRAk1otyXVSH 0GpaB/4v8PwFrs7AOMi66cA6Tsi/qBjflH3KQrj3At4pq7TFPyO91m0lAQh1WXFylFC5JAF6uCf uzV/uQXIFyaT9pTlUFea5OkxOf7zYs2cOzeuq+8hL3yahyQsVSjrr9UAOthoUVSoZsb8PR82pu+ LvUDRKEdyokDt0SBOBPh0kFSNFHBWJH+Gl1EWFqq0MAj1SFHP46UzniKrKTUfurI6kE+zk/uBlk 159yhkqFqXTAuKGm2f8SmDwT1lFBJ/jD2hb7GxW60oUhJbuQvfsx3k8svlQYDbhb6sDw1qdUR4e 1pw1JDqj4I9u8mtH+62X19zkTVQBrW6bgbOIxiYJPwP9vaEh X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB In order to make it easier to add more configuration for the tests and more support for runtime detection of when tests can be run pass the structure describing the tests into test_clone3() rather than picking the arguments out of it and have that function do all the per-test work. No functional change. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Reviewed-by: Catalin Marinas Tested-by: Rick Edgecombe Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 77 ++++++++++++++++----------------- 1 file changed, 37 insertions(+), 40 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index e61f07973ce5..e066b201fa64 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -30,6 +30,19 @@ enum test_mode { CLONE3_ARGS_INVAL_EXIT_SIGNAL_NSIG, }; +typedef bool (*filter_function)(void); +typedef size_t (*size_function)(void); + +struct test { + const char *name; + uint64_t flags; + size_t size; + size_function size_function; + int expected; + enum test_mode test_mode; + filter_function filter; +}; + static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode) { struct __clone_args args = { @@ -109,30 +122,40 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode) return 0; } -static bool test_clone3(uint64_t flags, size_t size, int expected, - enum test_mode test_mode) +static void test_clone3(const struct test *test) { + size_t size; int ret; + if (test->filter && test->filter()) { + ksft_test_result_skip("%s\n", test->name); + return; + } + + if (test->size_function) + size = test->size_function(); + else + size = test->size; + + ksft_print_msg("Running test '%s'\n", test->name); + ksft_print_msg( "[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)\n", - getpid(), flags, size); - ret = call_clone3(flags, size, test_mode); + getpid(), test->flags, size); + ret = call_clone3(test->flags, size, test->test_mode); ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n", - getpid(), ret, expected); - if (ret != expected) { + getpid(), ret, test->expected); + if (ret != test->expected) { ksft_print_msg( "[%d] Result (%d) is different than expected (%d)\n", - getpid(), ret, expected); - return false; + getpid(), ret, test->expected); + ksft_test_result_fail("%s\n", test->name); + return; } - return true; + ksft_test_result_pass("%s\n", test->name); } -typedef bool (*filter_function)(void); -typedef size_t (*size_function)(void); - static bool not_root(void) { if (getuid() != 0) { @@ -160,16 +183,6 @@ static size_t page_size_plus_8(void) return getpagesize() + 8; } -struct test { - const char *name; - uint64_t flags; - size_t size; - size_function size_function; - int expected; - enum test_mode test_mode; - filter_function filter; -}; - static const struct test tests[] = { { .name = "simple clone3()", @@ -319,24 +332,8 @@ int main(int argc, char *argv[]) ksft_set_plan(ARRAY_SIZE(tests)); test_clone3_supported(); - for (i = 0; i < ARRAY_SIZE(tests); i++) { - if (tests[i].filter && tests[i].filter()) { - ksft_test_result_skip("%s\n", tests[i].name); - continue; - } - - if (tests[i].size_function) - size = tests[i].size_function(); - else - size = tests[i].size; - - ksft_print_msg("Running test '%s'\n", tests[i].name); - - ksft_test_result(test_clone3(tests[i].flags, size, - tests[i].expected, - tests[i].test_mode), - "%s\n", tests[i].name); - } + for (i = 0; i < ARRAY_SIZE(tests); i++) + test_clone3(&tests[i]); ksft_finished(); } -- 2.39.5