From: Sagi Shahar <sagis@google.com>
To: linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Ryan Afranji <afranji@google.com>,
Andrew Jones <ajones@ventanamicro.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Sagi Shahar <sagis@google.com>,
Roger Wang <runanwang@google.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Oliver Upton <oliver.upton@linux.dev>,
"Pratik R. Sampat" <pratikrajesh.sampat@amd.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Chao Gao <chao.gao@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH v9 14/19] KVM: selftests: Add helpers to init TDX memory and finalize VM
Date: Wed, 20 Aug 2025 21:29:07 -0700 [thread overview]
Message-ID: <20250821042915.3712925-15-sagis@google.com> (raw)
In-Reply-To: <20250821042915.3712925-1-sagis@google.com>
From: Ackerley Tng <ackerleytng@google.com>
TDX protected memory needs to be measured and encrypted before it can be
used by the guest. Traverse the VM's memory regions and initialize all
the protected ranges by calling KVM_TDX_INIT_MEM_REGION.
Once all the memory is initialized, the VM can be finalized by calling
KVM_TDX_FINALIZE_VM.
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Co-developed-by: Erdem Aktas <erdemaktas@google.com>
Signed-off-by: Erdem Aktas <erdemaktas@google.com>
Co-developed-by: Sagi Shahar <sagis@google.com>
Signed-off-by: Sagi Shahar <sagis@google.com>
---
.../selftests/kvm/include/x86/tdx/tdx_util.h | 2 +
.../selftests/kvm/lib/x86/tdx/tdx_util.c | 97 +++++++++++++++++++
2 files changed, 99 insertions(+)
diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
index a2509959c7ce..2467b6c35557 100644
--- a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
+++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
@@ -71,4 +71,6 @@ void vm_tdx_load_common_boot_parameters(struct kvm_vm *vm);
void vm_tdx_load_vcpu_boot_parameters(struct kvm_vm *vm, struct kvm_vcpu *vcpu);
void vm_tdx_set_vcpu_entry_point(struct kvm_vcpu *vcpu, void *guest_code);
+void vm_tdx_finalize(struct kvm_vm *vm);
+
#endif // SELFTESTS_TDX_TDX_UTIL_H
diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
index d8eab99d9333..4024587ed3c2 100644
--- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
+++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
@@ -274,3 +274,100 @@ void vm_tdx_init_vm(struct kvm_vm *vm, uint64_t attributes)
free(init_vm);
}
+
+static void tdx_init_mem_region(struct kvm_vm *vm, void *source_pages,
+ uint64_t gpa, uint64_t size)
+{
+ uint32_t metadata = KVM_TDX_MEASURE_MEMORY_REGION;
+ struct kvm_tdx_init_mem_region mem_region = {
+ .source_addr = (uint64_t)source_pages,
+ .gpa = gpa,
+ .nr_pages = size / PAGE_SIZE,
+ };
+ struct kvm_vcpu *vcpu;
+
+ vcpu = list_first_entry_or_null(&vm->vcpus, struct kvm_vcpu, list);
+
+ TEST_ASSERT((mem_region.nr_pages > 0) &&
+ ((mem_region.nr_pages * PAGE_SIZE) == size),
+ "Cannot add partial pages to the guest memory.\n");
+ TEST_ASSERT(((uint64_t)source_pages & (PAGE_SIZE - 1)) == 0,
+ "Source memory buffer is not page aligned\n");
+ vm_tdx_vcpu_ioctl(vcpu, KVM_TDX_INIT_MEM_REGION, metadata, &mem_region);
+}
+
+static void tdx_init_pages(struct kvm_vm *vm, void *hva, uint64_t gpa,
+ uint64_t size)
+{
+ void *scratch_page = calloc(1, PAGE_SIZE);
+ uint64_t nr_pages = size / PAGE_SIZE;
+ int i;
+
+ TEST_ASSERT(scratch_page,
+ "Could not allocate memory for loading memory region");
+
+ for (i = 0; i < nr_pages; i++) {
+ memcpy(scratch_page, hva, PAGE_SIZE);
+
+ tdx_init_mem_region(vm, scratch_page, gpa, PAGE_SIZE);
+
+ hva += PAGE_SIZE;
+ gpa += PAGE_SIZE;
+ }
+
+ free(scratch_page);
+}
+
+static void load_td_private_memory(struct kvm_vm *vm)
+{
+ struct userspace_mem_region *region;
+ int ctr;
+
+ hash_for_each(vm->regions.slot_hash, ctr, region, slot_node) {
+ const struct sparsebit *protected_pages = region->protected_phy_pages;
+ const vm_paddr_t gpa_base = region->region.guest_phys_addr;
+ const uint64_t hva_base = region->region.userspace_addr;
+ const sparsebit_idx_t lowest_page_in_region = gpa_base >> vm->page_shift;
+
+ sparsebit_idx_t i;
+ sparsebit_idx_t j;
+
+ if (!sparsebit_any_set(protected_pages))
+ continue;
+
+ sparsebit_for_each_set_range(protected_pages, i, j) {
+ const uint64_t size_to_load = (j - i + 1) * vm->page_size;
+ const uint64_t offset =
+ (i - lowest_page_in_region) * vm->page_size;
+ const uint64_t hva = hva_base + offset;
+ const uint64_t gpa = gpa_base + offset;
+
+ vm_set_memory_attributes(vm, gpa, size_to_load,
+ KVM_MEMORY_ATTRIBUTE_PRIVATE);
+
+ /*
+ * Here, memory is being loaded from hva to gpa. If the memory
+ * mapped to hva is also used to back gpa, then a copy has to be
+ * made just for loading, since KVM_TDX_INIT_MEM_REGION ioctl
+ * cannot encrypt memory in place.
+ *
+ * To determine if memory mapped to hva is also used to back
+ * gpa, use a heuristic:
+ *
+ * If this memslot has guest_memfd, then this memslot should
+ * have memory backed from two sources: hva for shared memory
+ * and gpa will be backed by guest_memfd.
+ */
+ if (region->region.guest_memfd == -1)
+ tdx_init_pages(vm, (void *)hva, gpa, size_to_load);
+ else
+ tdx_init_mem_region(vm, (void *)hva, gpa, size_to_load);
+ }
+ }
+}
+
+void vm_tdx_finalize(struct kvm_vm *vm)
+{
+ load_td_private_memory(vm);
+ vm_tdx_vm_ioctl(vm, KVM_TDX_FINALIZE_VM, 0, NULL);
+}
--
2.51.0.rc1.193.gad69d77794-goog
next prev parent reply other threads:[~2025-08-21 4:29 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 4:28 [PATCH v9 00/19] TDX KVM selftests Sagi Shahar
2025-08-21 4:28 ` [PATCH v9 01/19] KVM: selftests: Include overflow.h instead of redefining is_signed_type() Sagi Shahar
2025-08-21 14:16 ` Sean Christopherson
2025-08-21 14:37 ` Ira Weiny
2025-08-21 14:42 ` Sean Christopherson
2025-08-21 4:28 ` [PATCH v9 02/19] KVM: selftests: Allocate pgd in virt_map() as necessary Sagi Shahar
2025-08-21 14:45 ` Ira Weiny
2025-08-26 2:36 ` Binbin Wu
2025-08-21 4:28 ` [PATCH v9 03/19] KVM: selftests: Expose functions to get default sregs values Sagi Shahar
2025-08-26 2:36 ` Binbin Wu
2025-08-26 14:05 ` Sean Christopherson
2025-08-21 4:28 ` [PATCH v9 04/19] KVM: selftests: Expose function to allocate guest vCPU stack Sagi Shahar
2025-08-21 22:00 ` Ira Weiny
2025-08-21 22:24 ` Sagi Shahar
2025-08-26 5:39 ` Binbin Wu
2025-08-26 16:00 ` Sagi Shahar
2025-08-26 17:16 ` Sean Christopherson
2025-08-21 4:28 ` [PATCH v9 05/19] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Sagi Shahar
2025-08-21 22:05 ` Ira Weiny
2025-08-21 22:30 ` Sagi Shahar
2025-08-26 5:51 ` Binbin Wu
2025-08-26 16:04 ` Sagi Shahar
2025-08-21 4:28 ` [PATCH v9 06/19] KVM: selftests: Expose segment definitons to assembly files Sagi Shahar
2025-08-21 20:04 ` Ira Weiny
2025-08-21 4:29 ` [PATCH v9 07/19] KVM: selftests: Add kbuild definitons Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 08/19] KVM: selftests: Define structs to pass parameters to TDX boot code Sagi Shahar
2025-08-26 6:52 ` Binbin Wu
2025-08-26 16:10 ` Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 09/19] KVM: selftests: Add " Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 10/19] KVM: selftests: Set up TDX boot code region Sagi Shahar
2025-08-25 5:32 ` Yan Zhao
2025-08-26 16:38 ` Sean Christopherson
2025-08-27 1:36 ` Yan Zhao
2025-08-21 4:29 ` [PATCH v9 11/19] KVM: selftests: Set up TDX boot parameters region Sagi Shahar
2025-08-26 8:36 ` Binbin Wu
2025-08-26 16:17 ` Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 12/19] KVM: selftests: Add helper to initialize TDX VM Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 13/19] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration Sagi Shahar
2025-08-26 9:22 ` Binbin Wu
2025-08-21 4:29 ` Sagi Shahar [this message]
2025-08-25 8:40 ` [PATCH v9 14/19] KVM: selftests: Add helpers to init TDX memory and finalize VM Yan Zhao
2025-08-25 19:02 ` Sagi Shahar
2025-08-26 1:07 ` Yan Zhao
2025-08-27 2:24 ` Binbin Wu
2025-08-27 2:44 ` Yan Zhao
2025-08-27 3:52 ` Yan Zhao
2025-08-21 4:29 ` [PATCH v9 15/19] KVM: selftests: Hook TDX support to vm and vcpu creation Sagi Shahar
2025-08-26 8:28 ` Chenyi Qiang
2025-08-26 16:12 ` Sagi Shahar
2025-08-26 17:31 ` Sean Christopherson
2025-08-26 20:16 ` Ira Weiny
2025-08-26 20:29 ` Sagi Shahar
2025-08-26 20:30 ` Sagi Shahar
2025-08-26 21:31 ` Sean Christopherson
2025-08-26 21:38 ` Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 16/19] KVM: selftests: Add support for TDX TDCALL from guest Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 17/19] KVM: selftests: Add wrapper for TDX MMIO " Sagi Shahar
2025-08-21 4:29 ` [PATCH v9 18/19] KVM: selftests: Add ucall support for TDX Sagi Shahar
2025-08-27 7:18 ` Binbin Wu
2025-09-02 15:45 ` Sean Christopherson
2025-09-03 1:07 ` Binbin Wu
2025-08-21 4:29 ` [PATCH v9 19/19] KVM: selftests: Add TDX lifecycle test Sagi Shahar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821042915.3712925-15-sagis@google.com \
--to=sagis@google.com \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=ajones@ventanamicro.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=erdemaktas@google.com \
--cc=ira.weiny@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=pratikrajesh.sampat@amd.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=runanwang@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).