* [PATCH v2] kselftests:grammer correction
@ 2025-08-20 12:58 Pavan Bobba
2025-08-20 22:15 ` Shivam Chaudhary
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pavan Bobba @ 2025-08-20 12:58 UTC (permalink / raw)
To: shuah, cvam0000; +Cc: linux-kselftest, linux-kernel, Pavan Bobba
correct a minor grammer mistake
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
v1 -> v2 : changed the "corrected" word to "correct" word in message
description to follow the convention
tools/testing/selftests/acct/acct_syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c
index 87c044fb9293..ee2894e4f7bc 100644
--- a/tools/testing/selftests/acct/acct_syscall.c
+++ b/tools/testing/selftests/acct/acct_syscall.c
@@ -22,7 +22,7 @@ int main(void)
ksft_print_header();
ksft_set_plan(1);
- // Check if test is run a root
+ // Check if test is run as root
if (geteuid()) {
ksft_exit_skip("This test needs root to run!\n");
return 1;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] kselftests:grammer correction
2025-08-20 12:58 [PATCH v2] kselftests:grammer correction Pavan Bobba
@ 2025-08-20 22:15 ` Shivam Chaudhary
2025-08-21 6:53 ` Shivam Chaudhary
2025-08-21 18:14 ` Al Viro
2 siblings, 0 replies; 4+ messages in thread
From: Shivam Chaudhary @ 2025-08-20 22:15 UTC (permalink / raw)
To: Pavan Bobba, shuah; +Cc: linux-kselftest, linux-kernel
On 20/08/25 6:28 PM, Pavan Bobba wrote:
> correct a minor grammer mistake
grammer should be grammar , spelling.txt does not have this, that is why
missed by checkpatch.
Also use proper subject prefix kselftests: should be selftests: acct:
please Send v3
> Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> ---
> v1 -> v2 : changed the "corrected" word to "correct" word in message
> description to follow the convention
> tools/testing/selftests/acct/acct_syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c
> index 87c044fb9293..ee2894e4f7bc 100644
> --- a/tools/testing/selftests/acct/acct_syscall.c
> +++ b/tools/testing/selftests/acct/acct_syscall.c
> @@ -22,7 +22,7 @@ int main(void)
> ksft_print_header();
> ksft_set_plan(1);
>
> - // Check if test is run a root
> + // Check if test is run as root
> if (geteuid()) {
> ksft_exit_skip("This test needs root to run!\n");
> return 1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] kselftests:grammer correction
2025-08-20 12:58 [PATCH v2] kselftests:grammer correction Pavan Bobba
2025-08-20 22:15 ` Shivam Chaudhary
@ 2025-08-21 6:53 ` Shivam Chaudhary
2025-08-21 18:14 ` Al Viro
2 siblings, 0 replies; 4+ messages in thread
From: Shivam Chaudhary @ 2025-08-21 6:53 UTC (permalink / raw)
To: Pavan Bobba, shuah; +Cc: linux-kselftest, linux-kernel
On 20/08/25 6:28 PM, Pavan Bobba wrote:
> correct a minor grammer mistake
grammer should be grammar, i think not present in spelling.txt and
missed by checkpatch.
Also fix your subsystem prefix it should be selftests: acct:
send v3
-cvam
>
> Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> ---
> v1 -> v2 : changed the "corrected" word to "correct" word in message
> description to follow the convention
> tools/testing/selftests/acct/acct_syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/acct/acct_syscall.c b/tools/testing/selftests/acct/acct_syscall.c
> index 87c044fb9293..ee2894e4f7bc 100644
> --- a/tools/testing/selftests/acct/acct_syscall.c
> +++ b/tools/testing/selftests/acct/acct_syscall.c
> @@ -22,7 +22,7 @@ int main(void)
> ksft_print_header();
> ksft_set_plan(1);
>
> - // Check if test is run a root
> + // Check if test is run as root
> if (geteuid()) {
> ksft_exit_skip("This test needs root to run!\n");
> return 1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] kselftests:grammer correction
2025-08-20 12:58 [PATCH v2] kselftests:grammer correction Pavan Bobba
2025-08-20 22:15 ` Shivam Chaudhary
2025-08-21 6:53 ` Shivam Chaudhary
@ 2025-08-21 18:14 ` Al Viro
2 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2025-08-21 18:14 UTC (permalink / raw)
To: Pavan Bobba; +Cc: shuah, cvam0000, linux-kselftest, linux-kernel
On Wed, Aug 20, 2025 at 06:28:36PM +0530, Pavan Bobba wrote:
> correct a minor grammer mistake
Demonstrations of the Muphry's law are amusing, but this is the the
6th copy (all with unique Message-ID, at that) all with the same patch.
You might at least vary the misspelling...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-21 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 12:58 [PATCH v2] kselftests:grammer correction Pavan Bobba
2025-08-20 22:15 ` Shivam Chaudhary
2025-08-21 6:53 ` Shivam Chaudhary
2025-08-21 18:14 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).