linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 bpf-next] selftests/bpf: Fix the issue where the error code is 0
@ 2025-08-29  1:41 Feng Yang
  0 siblings, 0 replies; only message in thread
From: Feng Yang @ 2025-08-29  1:41 UTC (permalink / raw)
  To: ast, daniel, john.fastabend, andrii, martin.lau, eddyz87, song,
	yonghong.song, kpsingh, sdf, haoluo, jolsa
  Cc: bpf, linux-kernel, linux-kselftest

From: Feng Yang <yangfeng@kylinos.cn>

The error message printed here only uses the previous err value,
which results in it being printed as 0.
Fix this issue by using libbpf_get_error to retrieve the error.

Fix before:
run_subtest:FAIL:1019 bpf_map__attach_struct_ops failed for map pro_epilogue: err=0

Fix after:
run_subtest:FAIL:1019 bpf_map__attach_struct_ops failed for map pro_epilogue: err=-9

Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
---
Changes in v2:
- Use libbpf_get_error, thanks: Alexei Starovoitov.
- Link to v1: https://lore.kernel.org/all/20250828081507.1380218-1-yangfeng59949@163.com/
---
 tools/testing/selftests/bpf/test_loader.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c
index 78423cf89e01..b8e102eb0908 100644
--- a/tools/testing/selftests/bpf/test_loader.c
+++ b/tools/testing/selftests/bpf/test_loader.c
@@ -1082,8 +1082,8 @@ void run_subtest(struct test_loader *tester,
 			}
 			link = bpf_map__attach_struct_ops(map);
 			if (!link) {
-				PRINT_FAIL("bpf_map__attach_struct_ops failed for map %s: err=%d\n",
-					   bpf_map__name(map), err);
+				PRINT_FAIL("bpf_map__attach_struct_ops failed for map %s: err=%ld\n",
+					   bpf_map__name(map), libbpf_get_error(link));
 				goto tobj_cleanup;
 			}
 			links[links_cnt++] = link;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-29  1:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-29  1:41 [PATCH v2 bpf-next] selftests/bpf: Fix the issue where the error code is 0 Feng Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).