Re: [PATCH v5 05/15] iommupt: Add iova_to_phys op

Jason Gunthorpe
2025-09-19T18:35:23Z

On Thu, Sep 18, 2025 at 07:08:39AM +0000, Tian, Kevin wrote:
> > +/*
> > + * Some APIs use unsigned long some use dma_addr_t as the type. Dispatch
> > to the
> > + * correct validation based on the type.
>
> "Some APIs use unsigned long, while others use..."

OK

> > +#define PT_IOMMU_CHECK_DOMAIN(s, pt_iommu_memb, domain_memb)
> > \
> > + static_assert(offsetof(s, pt_iommu_memb.domain) == \
> > + offsetof(s, domain_memb))
> >
>
> not belong to this patch

I moved it to patch 3 "basic structure"

Thanks,
Jason