From: Jakub Kicinski <kuba@kernel.org>
To: Andre Carvalho <asantostc@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] netconsole: resume previously deactivated target
Date: Mon, 22 Sep 2025 16:50:57 -0700 [thread overview]
Message-ID: <20250922165057.70eefc6b@kernel.org> (raw)
In-Reply-To: <20250921-netcons-retrigger-v2-5-a0e84006237f@gmail.com>
On Sun, 21 Sep 2025 22:55:45 +0100 Andre Carvalho wrote:
> + if (nt->state == STATE_DEACTIVATED && event == NETDEV_UP)
> + maybe_resume_target(nt, dev);
This uses GFP_KERNEL
> netconsole_target_put(nt);
> }
> spin_unlock_irqrestore(&target_list_lock, flags);
And we're under a spin lock.
This gets hit in the selftest you're adding so please triple check
the kernel config that you're testing with.
next prev parent reply other threads:[~2025-09-22 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 21:55 [PATCH net-next v2 0/6] netconsole: support automatic target recovery Andre Carvalho
2025-09-21 21:55 ` [PATCH net-next v2 1/6] netconsole: add target_state enum Andre Carvalho
2025-09-21 21:55 ` [PATCH net-next v2 2/6] netconsole: convert 'enabled' flag to enum for clearer state management Andre Carvalho
2025-09-21 21:55 ` [PATCH net-next v2 3/6] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Andre Carvalho
2025-09-21 21:55 ` [PATCH net-next v2 4/6] netpoll: add wrapper around __netpoll_setup with dev reference Andre Carvalho
2025-09-21 21:55 ` [PATCH net-next v2 5/6] netconsole: resume previously deactivated target Andre Carvalho
2025-09-22 23:50 ` Jakub Kicinski [this message]
2025-09-23 19:36 ` Andre Carvalho
2025-09-23 12:22 ` Breno Leitao
2025-09-23 19:30 ` Andre Carvalho
2025-09-24 8:26 ` Breno Leitao
2025-09-24 22:26 ` Andre Carvalho
2025-09-25 8:34 ` Breno Leitao
2025-09-21 21:55 ` [PATCH net-next v2 6/6] selftests: netconsole: validate target reactivation Andre Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922165057.70eefc6b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox