From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B78E234973 for ; Thu, 25 Sep 2025 13:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758806924; cv=none; b=nS4Yi1PEyCkFVmU/cxkB+5G9CQk+t1eMyNUwklG1BkKoeXCHcRuW4AzK/pZGhQ1fWqnlpNqUD/Gs5hxqCevlUtnRpMwX8QEMKGlu5kZX7HgU972da4Eh8s3BDgScbIjdIlacAMTavM/TjvsvcWpiKhHZyYiJZ2vaJExZ7X5I1Q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758806924; c=relaxed/simple; bh=WNzxPrFin73Lh2ypAKh0zFTGhRAVwxDD1dobdQ9kdBI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TPZbI5zGpUJfECaymtWo3OpyRK7YnnkMWVlcmg6OEFFWLeDMWweJ3eV9bHpxFIyMnUtG7lqljkB9hHpViwCQM6ioD2B224ZCfN6gIEORmCTLW5vOK8LqW3VQtoEadSEVLo96VOXuHxm7hMpSv7+6seo3cLOjw+wVpnfDw1gNyoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AR3y7+40; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AR3y7+40" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-634a3327ff7so1582850a12.1 for ; Thu, 25 Sep 2025 06:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758806921; x=1759411721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RIjBW0HGJ1nhvOGLp1W0sfAHAgMMEq0zVvUkf/NQa8k=; b=AR3y7+40bS4vLrdByw6VpDa3ZXTdOXtstO/0xWrva5oNUBYV5ZtTRdRvK1RlMecLX3 /UgFk5Et6I/DGiI2jid3F+kvfNLBuY5laGTMPcojrOY16dToUiCWmakcyffT2hLJjWTa Tmt5IiUL843rxtWTgMZiRBoQsTtNzbOC5Ccp+qrbB7SPObD5uR0ago8OyTXOjmL0C72i OE8laPZApuUHi7fVlbTlWCUvxH+FrC40VjtKViWGK7DI/k+K0H4Cd1bSGli7zft8kK1B XWiTx+DXqGgxOMY7fUt5nZM1tpPBhxEvmH5RcCASSaIO3Flzx1uRDG8v6weWbvScX3aD WzHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758806921; x=1759411721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RIjBW0HGJ1nhvOGLp1W0sfAHAgMMEq0zVvUkf/NQa8k=; b=Y6gKqRMqhkYckinaS/BEnDf2BSqv27HwPcN0N2rbxrtK3zCkTwuTi2hvU3USXSzlFG ra6bJ1MobapNtS+tvZMF5sdaeo8L8c7AvZEbLcc8Dywm7TwaTxlPElMiM0RBVFHc84fs F/kVnq8/tefHLYq10hqhCTs3WqRLsjT3uy4ZbX8O4zzF+nbk7cKPEKwtKLKyU69MPff6 twPH07AsXtH+o94uiNjNR18hi5ANYnt3p+ZXHRh0TnQL00hXzT2ERABJxr5T1QIcQW92 NCcZJD7T36yLxWIqyzjap7gaJNZg3JYe9wFWmKEBx15LdsIckcYZ3f2wt/XZWOoq1BCG PVyg== X-Forwarded-Encrypted: i=1; AJvYcCVdkTS52/cEUPb1c/8g0QhWuhtzvzWzmtnJCsNPuMlgMrN1Z5Tl6Y8w5e1V1hCPJpWIUsDGt1ZotKmiyhWX4Vg=@vger.kernel.org X-Gm-Message-State: AOJu0YxgrrnRtEIDsgPQVPqocIwGNHuApHReIs+a0+uvOZxZGQxyCi+C hQ+t2tl4G4/QLjvSXRPGu/1zH38ZuLVCQe/26iIJm2WTw3JjIWNczH6J X-Gm-Gg: ASbGncvJ6W8aWmRbm8d6pviGZ4o6njNfpGxgeJEzOQvT2DaRPHg6tOiGiCO/PLwbMdM 9+yrw/ptYVpwKdhK0IveEKEiajMKi8fH5zcQqpwzszXRsdOYO9Kd8ByXjwAK/vZp/HDSP134Ev/ CdZTfDEoY+l6uLIXFxK+yptOgWSjHPrtN0bo2MJvcLT2g72BlXhTSYsaiLFExmPUyCEsIxkNF2n j+5jVucgWc7N4zZXtq5Bp0/neg8vgIeCCtehaxBLp6pGbDA91/bJvZwtRvRtzcUb3LAHkMOYTrm gQY2n8LF6NusEngiMI2bIsGPmt0eTfC+IoJMIwpNBErU8xqexa9KeDnwx0hV+JqqVtz2JLmrIav YZSOFjlhDEDhn/mw6SqiJWAakstNWteqnO65cg27jiV5WOCbvRgF58O3D6LaaxjVk1sTRmPVC7g U9WyiFaw== X-Google-Smtp-Source: AGHT+IE3bLNJPUzSKiXc9lkzEM/Izf2jTetxO9oV5D9S6+ZprF/oHUQ3nKipbH/bpNZu/lVBwAtFEQ== X-Received: by 2002:a05:6402:348b:b0:62f:32c7:6c2b with SMTP id 4fb4d7f45d1cf-6349f9fad7emr2672620a12.11.1758806921247; Thu, 25 Sep 2025 06:28:41 -0700 (PDT) Received: from alessandro-pc.station (net-2-37-207-41.cust.vodafonedsl.it. [2.37.207.41]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-634a3b02d8asm1185354a12.44.2025.09.25.06.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 06:28:40 -0700 (PDT) From: Alessandro Zanni To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org Cc: Alessandro Zanni , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] selftest: net: Fix error message if empty variable Date: Thu, 25 Sep 2025 15:28:23 +0200 Message-ID: <20250925132832.9828-1-alessandro.zanni87@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix to avoid cases where the `res` shell variable is empty in script comparisons. The comparison has been modified into string comparison to handle other possible values the variable could assume. The issue can be reproduced with the command: make kselftest TARGETS=net It solves the error: ./tfo_passive.sh: line 98: [: -eq: unary operator expected Signed-off-by: Alessandro Zanni --- Notes: v2: edit condition to handle strings tools/testing/selftests/net/tfo_passive.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tfo_passive.sh b/tools/testing/selftests/net/tfo_passive.sh index 80bf11fdc046..a4550511830a 100755 --- a/tools/testing/selftests/net/tfo_passive.sh +++ b/tools/testing/selftests/net/tfo_passive.sh @@ -95,7 +95,7 @@ wait res=$(cat $out_file) rm $out_file -if [ $res -eq 0 ]; then +if [ "$res" = "0" ]; then echo "got invalid NAPI ID from passive TFO socket" cleanup_ns exit 1 -- 2.43.0