From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ACAD29B8D0; Fri, 3 Oct 2025 23:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759534261; cv=none; b=BCDPNH7W25y9vIYCr+/VTQMTteStVsgUBFHTko8deR/Mv8CsNm9OXybguzLKS9tM3k91zGEsPQ8EZRnw+Xlw7LsssjuTsZgQ4g8KXgYsyvl5FkRafqHReeU/tO9EJMOU0c/BVIqTvAnoVk3YFD+ePHY2IFFOJ7Xu6dd+kJBeAVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759534261; c=relaxed/simple; bh=RzvBYuPoFOcVCR8Wu02ofZBfqwQw9wY33Ux5rMBW8fc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DkYDXbYZVkcPaDjOzKT5vBQ+2eXddZqhZFFaPeT7kGAu9iREiZ9tYjyEBgLBCOtYwnhYQaEPGKRtAKVVTdnlJDJZ358leG5q4wFOrWFlADQNGDhYnLikyN0zNhWows7Gk3bIEJ+8+oS+dQh5t7BqglHXZxb+a7jtzqYgZih0iP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EHU+3CnZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EHU+3CnZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDCABC4CEF5; Fri, 3 Oct 2025 23:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759534260; bh=RzvBYuPoFOcVCR8Wu02ofZBfqwQw9wY33Ux5rMBW8fc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EHU+3CnZTo8SFPiZ+Gapy5/RJywM4p6BOqGDAoaRgtnqw6UNXWnRCLxcxDM9ZmNGZ z/2OFEQX+fH6+Eoinea6rpHP/faTIbOyPPhjWCchU6Yqs9nyhIRr/2gQtdps5ejp+6 jLhmmQ0x+UilL98/NWrF4r7FPRZQDKO1vhBTHm6BZSfdOuwbXssMC6QlYnc0+DEylJ 4veBYgP9XCCecY1xDEeCiS7gmnpez7wNS+hcMZVFIpEr4bELj3XMbdYC/KcMytv7fu 4FvoUe7EPCp+3DFe0lhDhpsrTP9RiW96VmJEEwR3eqsL4I8qRw/8l7AmZgruAuyBo6 vy9QnVRjSVjwA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, bpf@vger.kernel.org, Jakub Kicinski , shuah@kernel.org, johndale@cisco.com, linux-kselftest@vger.kernel.org Subject: [PATCH net 7/9] selftests: drv-net: fix linter warnings in pp_alloc_fail Date: Fri, 3 Oct 2025 16:30:23 -0700 Message-ID: <20251003233025.1157158-8-kuba@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251003233025.1157158-1-kuba@kernel.org> References: <20251003233025.1157158-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix linter warnings, it's a bit hard to check for new ones otherwise. W0311: Bad indentation. Found 16 spaces, expected 12 (bad-indentation) C0114: Missing module docstring (missing-module-docstring) W1514: Using open without explicitly specifying an encoding (unspecified-encoding) C0116: Missing function or method docstring (missing-function-docstring) Signed-off-by: Jakub Kicinski --- CC: shuah@kernel.org CC: johndale@cisco.com CC: linux-kselftest@vger.kernel.org --- .../selftests/drivers/net/hw/pp_alloc_fail.py | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/pp_alloc_fail.py b/tools/testing/selftests/drivers/net/hw/pp_alloc_fail.py index ad192fef3117..fc66b7a7b149 100755 --- a/tools/testing/selftests/drivers/net/hw/pp_alloc_fail.py +++ b/tools/testing/selftests/drivers/net/hw/pp_alloc_fail.py @@ -1,6 +1,10 @@ #!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0 +""" +Test driver resilience vs page pool allocation failures. +""" + import errno import time import os @@ -13,7 +17,8 @@ from lib.py import cmd, tool, GenerateTraffic def _write_fail_config(config): for key, value in config.items(): - with open("/sys/kernel/debug/fail_function/" + key, "w") as fp: + path = "/sys/kernel/debug/fail_function/" + with open(path + key, "w", encoding='ascii') as fp: fp.write(str(value) + "\n") @@ -22,8 +27,7 @@ from lib.py import cmd, tool, GenerateTraffic raise KsftSkipEx("Kernel built without function error injection (or DebugFS)") if not os.path.exists("/sys/kernel/debug/fail_function/page_pool_alloc_netmems"): - with open("/sys/kernel/debug/fail_function/inject", "w") as fp: - fp.write("page_pool_alloc_netmems\n") + _write_fail_config({"inject": "page_pool_alloc_netmems"}) _write_fail_config({ "verbose": 0, @@ -38,8 +42,7 @@ from lib.py import cmd, tool, GenerateTraffic return if os.path.exists("/sys/kernel/debug/fail_function/page_pool_alloc_netmems"): - with open("/sys/kernel/debug/fail_function/inject", "w") as fp: - fp.write("\n") + _write_fail_config({"inject": ""}) _write_fail_config({ "probability": 0, @@ -48,6 +51,10 @@ from lib.py import cmd, tool, GenerateTraffic def test_pp_alloc(cfg, netdevnl): + """ + Configure page pool allocation fail injection while traffic is running. + """ + def get_stats(): return netdevnl.qstats_get({"ifindex": cfg.ifindex}, dump=True)[0] @@ -105,7 +112,7 @@ from lib.py import cmd, tool, GenerateTraffic else: ksft_pr("ethtool -G change retval: did not succeed", new_g) else: - ksft_pr("ethtool -G change retval: did not try") + ksft_pr("ethtool -G change retval: did not try") time.sleep(0.1) check_traffic_flowing() @@ -119,6 +126,7 @@ from lib.py import cmd, tool, GenerateTraffic def main() -> None: + """ Ksft boiler plate main """ netdevnl = NetdevFamily() with NetDrvEpEnv(__file__, nsim_test=False) as cfg: -- 2.51.0