From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Zahka <daniel.zahka@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Boris Pismenny <borisp@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Willem de Bruijn <willemb@google.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Raed Salem <raeds@nvidia.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] net/mlx5e: Add PSP stats support for Rx/Tx flows
Date: Wed, 22 Oct 2025 17:56:02 -0700 [thread overview]
Message-ID: <20251022175602.560ad464@kernel.org> (raw)
In-Reply-To: <20251022193739.1376320-5-daniel.zahka@gmail.com>
On Wed, 22 Oct 2025 12:37:36 -0700 Daniel Zahka wrote:
> mlx5_core_warn(mdev,
> + "fail to create psp rx flow counter err(%ld)\n",
> + PTR_ERR(flow_counter));
> + err = PTR_ERR(flow_counter);
> + goto out_err;
> + }
> + accel_psp->rx_counter = flow_counter;
> +
> + flow_counter = mlx5_fc_create(mdev, false);
> + if (IS_ERR(flow_counter)) {
> + mlx5_core_warn(mdev,
> + "fail to create psp rx auth fail flow counter err(%ld)\n",
> + PTR_ERR(flow_counter));
> + err = PTR_ERR(flow_counter);
> + goto out_counter_err;
> + }
> + accel_psp->rx_auth_fail_counter = flow_counter;
> +
> + flow_counter = mlx5_fc_create(mdev, false);
> + if (IS_ERR(flow_counter)) {
> + mlx5_core_warn(mdev,
> + "fail to create psp rx error flow counter err(%ld)\n",
> + PTR_ERR(flow_counter));
> + err = PTR_ERR(flow_counter);
> + goto out_auth_fail_counter_err;
> + }
> + accel_psp->rx_err_counter = flow_counter;
> +
> + flow_counter = mlx5_fc_create(mdev, false);
> + if (IS_ERR(flow_counter)) {
> + mlx5_core_warn(mdev,
> + "fail to create psp rx auth fail flow counter err(%ld)\n",
> + PTR_ERR(flow_counter));
Coccicheck sayeth (5x):
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c:
WARNING: Consider using %pe to print PTR_ERR()
That's %pe, flow_counter instead of %d, PTR_ERR(flow_counter)
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-23 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 19:37 [PATCH net-next 0/5] psp: track stats from core and provide a driver stats api Daniel Zahka
2025-10-22 19:37 ` [PATCH net-next 1/5] psp: report basic stats from the core Daniel Zahka
2025-10-22 19:37 ` [PATCH net-next 2/5] selftests: drv-net: psp: add assertions on core-tracked psp dev stats Daniel Zahka
2025-10-22 19:37 ` [PATCH net-next 3/5] psp: add stats from psp spec to driver facing api Daniel Zahka
2025-10-22 19:37 ` [PATCH net-next 4/5] net/mlx5e: Add PSP stats support for Rx/Tx flows Daniel Zahka
2025-10-23 0:56 ` Jakub Kicinski [this message]
2025-10-22 19:37 ` [PATCH net-next 5/5] netdevsim: implement psp device stats Daniel Zahka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022175602.560ad464@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).