linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@google.com>
To: lkp@intel.com
Cc: kuniyu@google.com, linux-kselftest@vger.kernel.org,
	 oe-kbuild-all@lists.linux.dev, skhan@linuxfoundation.org
Subject: Re: [PATCH] selftests: harness: Support KCOV.
Date: Tue, 28 Oct 2025 02:37:48 +0000	[thread overview]
Message-ID: <20251028023801.2024155-1-kuniyu@google.com> (raw)
In-Reply-To: <aQAjgRwd8P+YZSa6@rli9-mobl>

From: kernel test robot <lkp@intel.com>
Date: Tue, 28 Oct 2025 09:59:29 +0800
> Hi Kuniyuki,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on shuah-kselftest/next]
> [also build test WARNING on shuah-kselftest/fixes kees/for-next/seccomp linus/master v6.18-rc2 next-20251024]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/selftests-harness-Support-KCOV/20251017-164507
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
> patch link:    https://lore.kernel.org/r/20251017084022.3721950-1-kuniyu%40google.com
> patch subject: [PATCH] selftests: harness: Support KCOV.
> :::::: branch date: 9 days ago
> :::::: commit date: 9 days ago
> config: x86_64-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20251026/202510262116.jwyrgplV-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251026/202510262116.jwyrgplV-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/r/202510262116.jwyrgplV-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from listmount_test.c:14:
>    ../../kselftest_harness.h:188:25: error: initialization of 'void (*)(struct __test_metadata *, struct __fixture_variant_metadata *, char *)' from incompatible pointer type 'void (*)(struct __test_metadata *, struct __fixture_variant_metadata *)' [-Wincompatible-pointer-types]
>      188 |                   .fn = &wrapper_##test_name, \
>          |                         ^
>    ../../kselftest_harness.h:157:25: note: in expansion of macro '__TEST_IMPL'
>      157 | #define TEST(test_name) __TEST_IMPL(test_name, -1)
>          |                         ^~~~~~~~~~~
>    listmount_test.c:23:1: note: in expansion of macro 'TEST'
>       23 | TEST(listmount_forward)
>          | ^~~~

Oh sorry, I missed TEST() as af_unix didn't use it,
but I should've compiled all tests.

Will squash this diff to v2.

Thanks!

---8<---
diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index cba8020853b5..5b7a01722981 100644
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -179,9 +179,12 @@
 	static void test_name(struct __test_metadata *_metadata); \
 	static void wrapper_##test_name( \
 		struct __test_metadata *_metadata, \
-		struct __fixture_variant_metadata __attribute__((unused)) *variant) \
+		struct __fixture_variant_metadata __attribute__((unused)) *variant, \
+		char *test_full_name) \
 	{ \
+		enable_kcov(_metadata); \
 		test_name(_metadata); \
+		disable_kcov(_metadata, test_full_name); \
 	} \
 	static struct __test_metadata _##test_name##_object = \
 		{ .name = #test_name, \
---8<---

      reply	other threads:[~2025-10-28  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17  8:40 [PATCH] selftests: harness: Support KCOV Kuniyuki Iwashima
2025-10-28  0:03 ` Kuniyuki Iwashima
2025-10-28  1:59 ` kernel test robot
2025-10-28  2:37   ` Kuniyuki Iwashima [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028023801.2024155-1-kuniyu@google.com \
    --to=kuniyu@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).