From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] selftests/tracing: Add basic test for trace_marker_raw file
Date: Mon, 3 Nov 2025 12:10:05 -0500 [thread overview]
Message-ID: <20251103121005.6399baf3@gandalf.local.home> (raw)
In-Reply-To: <20251014161403.1443c21f@gandalf.local.home>
Masami,
Ping!
-- Steve
On Tue, 14 Oct 2025 16:14:03 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> Shuah,
>
> After Masami gives an ack, could you take this through your tree.
>
> I don't think it's urgent, but I want to make sure it gets upstream.
>
> -- Steve
>
>
> On Tue, 14 Oct 2025 14:51:49 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > From: Steven Rostedt <rostedt@goodmis.org>
> >
> > Commit 64cf7d058a00 ("tracing: Have trace_marker use per-cpu data to read
> > user space") made an update that fixed both trace_marker and
> > trace_marker_raw. But the small difference made to trace_marker_raw had a
> > blatant bug in it that any basic testing would have uncovered.
> > Unfortunately, the self tests have tests for trace_marker but nothing for
> > trace_marker_raw which allowed the bug to get upstream.
> >
> > Add basic selftests to test trace_marker_raw so that this doesn't happen
> > again.
> >
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> >
next prev parent reply other threads:[~2025-11-03 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 18:51 [PATCH] selftests/tracing: Add basic test for trace_marker_raw file Steven Rostedt
2025-10-14 20:14 ` Steven Rostedt
2025-11-03 17:10 ` Steven Rostedt [this message]
2025-11-04 23:47 ` Masami Hiramatsu
2025-11-06 22:25 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103121005.6399baf3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox