From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>, Shuah Khan <shuah@kernel.org>
Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: [PATCH net-next v3 08/11] selftests/vsock: add BUILD=0 definition
Date: Thu, 06 Nov 2025 16:49:52 -0800 [thread overview]
Message-ID: <20251106-vsock-selftests-fixes-and-improvements-v3-8-519372e8a07b@meta.com> (raw)
In-Reply-To: <20251106-vsock-selftests-fixes-and-improvements-v3-0-519372e8a07b@meta.com>
From: Bobby Eshleman <bobbyeshleman@meta.com>
Add the definition for BUILD and initialize it to zero. This avoids
'bash -u vmtest.sh` from throwing 'unbound variable' when BUILD is not
set to 1 and is later checked for its value.
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
Changes in v2:
- remove fixes tag because it doesn't fix breakage of kselftest, and
just supports otherwise invoking with bash -u
---
tools/testing/selftests/vsock/vmtest.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
index 05cf370a3db4..7962bc40d055 100755
--- a/tools/testing/selftests/vsock/vmtest.sh
+++ b/tools/testing/selftests/vsock/vmtest.sh
@@ -559,6 +559,7 @@ run_shared_vm_test() {
return "${rc}"
}
+BUILD=0
QEMU="qemu-system-$(uname -m)"
while getopts :hvsq:b o
--
2.47.3
next prev parent reply other threads:[~2025-11-07 0:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 0:49 [PATCH net-next v3 00/11] selftests/vsock: refactor and improve vmtest infrastructure Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 01/11] selftests/vsock: improve logging in vmtest.sh Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 02/11] selftests/vsock: make wait_for_listener() work even if pipefail is on Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 03/11] selftests/vsock: reuse logic for vsock_test through wrapper functions Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 04/11] selftests/vsock: avoid multi-VM pidfile collisions with QEMU Bobby Eshleman
2025-11-07 15:08 ` Simon Horman
2025-11-07 15:35 ` Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 05/11] selftests/vsock: do not unconditionally die if qemu fails Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 06/11] selftests/vsock: speed up tests by reducing the QEMU pidfile timeout Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 07/11] selftests/vsock: add check_result() for pass/fail counting Bobby Eshleman
2025-11-07 0:49 ` Bobby Eshleman [this message]
2025-11-07 0:49 ` [PATCH net-next v3 09/11] selftests/vsock: add 1.37 to tested virtme-ng versions Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 10/11] selftests/vsock: add vsock_loopback module loading Bobby Eshleman
2025-11-07 0:49 ` [PATCH net-next v3 11/11] selftests/vsock: disable shellcheck SC2317 and SC2119 Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106-vsock-selftests-fixes-and-improvements-v3-8-519372e8a07b@meta.com \
--to=bobbyeshleman@gmail.com \
--cc=bobbyeshleman@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).