From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A8430F7EE for ; Sun, 16 Nov 2025 17:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313258; cv=none; b=FXamQw+7d3/g4R8LheJ3XZecFRxEuQaY7+sy25vc61oxYDJweYC3uNBRaT7MCllzYgudq37qZKsfk1C5jC7gnHbzooEANQoZLTmpooJ5j+oh7f6LO9KaCCySxI4U9ZpWAq5/GYfkCk7o/8qpy+itaygwJhQ3dvmF/BcGYfSpadM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313258; c=relaxed/simple; bh=h/WMgGuer/rTaYwZTdPaPC720ScIfwyjdiEy9wHdF6o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Be1CXTkNBkHcZUVoVMtxy0Vs1QAGQaDIRlRlVImks6mnUkV0u1BBEzPe6uLSZCeK6mm/3YSyTT5Y+NMy75tjY65iysBpOz0U/c2DjLCkpmQRC6XRgV//MVl9kkdQz24KKoJGjj80B5gpblqI3zqJvhci98eJiLn6cwQdsj1H6qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UpERV2OU; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UpERV2OU" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47118259fd8so25682505e9.3 for ; Sun, 16 Nov 2025 09:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763313254; x=1763918054; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=64c74E2vcVe9LLOPxPVEYauBTLRgO0onhWdcRTaSbWE=; b=UpERV2OU5ItUmi+8JamRwbVXLP5s21V/t/+3HIkaujZG14D/Dz+B1AHvYXRdFXajIN InjQtfGuozTJHQRBGymGlqCOwKr/5SVk3rvr50eGuNdjgXkUlSYW6bv2aml20IG4QeqD 07Q3/pl2yguIHHklMOJwmV2/ksX/gUBvba3wQVLkIhekKB2hun8iKMtEVCYQ8HSnnLMP orJWwSqlDJIAbPuVUBky18lABnWO2W9dtDFxpnEpqZdjUCCGu2QWqTwXjLe7g36/PiPD Pz+zKZMeuqQdMBosE7unvpNRf6qB7O4tvTyOH5BNIIxtSbxytBz1PUMuFRcTT7ySOWWZ fP5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763313254; x=1763918054; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=64c74E2vcVe9LLOPxPVEYauBTLRgO0onhWdcRTaSbWE=; b=QIMUxMskWeUe5MQfODQ30V0vpFF5OXuRgf8csFNlWwccfhNf4O3kWJ6gtG9XUlqhF1 g2L+qKIMwv0MtvV1Dcj/oaG/fQBq62n9RzwzxqtZN6KriUy7DAf+m5dcE7UJNq5ilzx8 55qQyFmrwvhgsDR1WzPQpzVxiIody36KdWxYonLoRgc8gMQnL2LbwbSGWDml5QsifI5t PItcbmnpSHKiuinaq/cuOU5Vv7wF+hC7GDhX0+xXSo81gTdwC/EINvL/MvIyjdZb0Jzc eXkqyiQTlurNwNQBH3EhuoHmJKw9tBWgWc7odB91/fh4Jh2aP/bl2EWvqC9E4Vy0tklm HTXw== X-Forwarded-Encrypted: i=1; AJvYcCXQ63hFTWdejsNX5aHJ3Ei9wZ/SAQfOBxyceNU+xSruRAKLFgi/GXL/uNOzZZRwYYdD4NdxUHixaZ1m+51rcmI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx/WMk0WWaY43ByUlnfvgGsShSrpc8OFDp+jyPbjMSjf/hVi0N 9vQWjx6L3uUB7olTFKgpf0y8OQRl6C7Own0bBSuF1PFZy4EHAaNzDaei X-Gm-Gg: ASbGncuwiJxF1SmkGtPMcTuHk1VbTSFVNvD6BfAd4J8a5Df6PwkFAkEg8bg1jvi+YpD GT4xsY6/MHv15OmI3aTSZTgc9dr/6YbFWbf+51zAt9LqeJatiTNAGdlZEM8O2F3iotuFKvLR7WN bZCHK4Ep7anycxQOKp/2iVMe0iqD6BwDsNPDyU/ELznlZaOy/tUpNeOE5wksIg9f+hPNkdwfzJR G0hpj4wTW+uKxgC6QlmACM1TgQ5Zqmw/yMc2MAXYbdgEihOVR9CwBeXkbhBHkF5zUdekjBjRGwB ii+lN08F6nINuEgnm4q21sTdDdfADakU9Id9WAR0qgEE1eynvrEEE9zpxO1b1x/TidMZ+Z9j3/K bVbBJFQMbxv3BwXUxXnTYAYRCJCa41G2o0OQUjbke80lv4zg45yt3+ukdWIAwO4RsWihW/LegSZ OB+BNw1/H9f34XRls= X-Google-Smtp-Source: AGHT+IFb+5B5it/BKlLtxvXHkY7vJMvOEeaxF2ZqNYkisSLtW0WV6paguq5YZcsz1FUdy3z67xOBVA== X-Received: by 2002:a05:600c:1d19:b0:46e:5100:326e with SMTP id 5b1f17b1804b1-4778fea835dmr84666965e9.23.1763313253937; Sun, 16 Nov 2025 09:14:13 -0800 (PST) Received: from [192.168.1.243] ([143.58.192.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4779d722bc5sm70874245e9.2.2025.11.16.09.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 09:14:13 -0800 (PST) From: Andre Carvalho Date: Sun, 16 Nov 2025 17:14:02 +0000 Subject: [PATCH net-next v4 2/5] netconsole: convert 'enabled' flag to enum for clearer state management Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251116-netcons-retrigger-v4-2-5290b5f140c2@gmail.com> References: <20251116-netcons-retrigger-v4-0-5290b5f140c2@gmail.com> In-Reply-To: <20251116-netcons-retrigger-v4-0-5290b5f140c2@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andre Carvalho X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763313249; l=8901; i=asantostc@gmail.com; s=20250807; h=from:subject:message-id; bh=h/WMgGuer/rTaYwZTdPaPC720ScIfwyjdiEy9wHdF6o=; b=f5CJ8eWnDQx4z556zMb6qphK0mflGJpgOylJuu+5qSjAWGkfzUIW1jyYVnEaXqBsbc4wSeG1P W+YKNHX/zdeD7UHQaICl0YK3+qQ/QghxsdM3wDSHuMyf/c3timchANs X-Developer-Key: i=asantostc@gmail.com; a=ed25519; pk=eWre+RwFHCxkiaQrZLsjC67mZ/pZnzSM/f7/+yFXY4Q= This patch refactors the netconsole driver's target enabled state from a simple boolean to an explicit enum (`target_state`). This allow the states to be expanded to a new state in the upcoming change. Co-developed-by: Breno Leitao Signed-off-by: Breno Leitao Signed-off-by: Andre Carvalho --- drivers/net/netconsole.c | 52 ++++++++++++++++++++++++++---------------------- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 7a7eba041e23..2d15f7ab7235 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -132,12 +132,12 @@ enum target_state { * @sysdata_fields: Sysdata features enabled. * @msgcounter: Message sent counter. * @stats: Packet send stats for the target. Used for debugging. - * @enabled: On / off knob to enable / disable target. + * @state: State of the target. * Visible from userspace (read-write). * We maintain a strict 1:1 correspondence between this and * whether the corresponding netpoll is active or inactive. * Also, other parameters of a target may be modified at - * runtime only when it is disabled (enabled == 0). + * runtime only when it is disabled (state == STATE_DISABLED). * @extended: Denotes whether console is extended or not. * @release: Denotes whether kernel release version should be prepended * to the message. Depends on extended console. @@ -165,7 +165,7 @@ struct netconsole_target { u32 msgcounter; #endif struct netconsole_target_stats stats; - bool enabled; + enum target_state state; bool extended; bool release; struct netpoll np; @@ -257,6 +257,7 @@ static struct netconsole_target *alloc_and_init(void) nt->np.local_port = 6665; nt->np.remote_port = 6666; eth_broadcast_addr(nt->np.remote_mac); + nt->state = STATE_DISABLED; return nt; } @@ -275,7 +276,7 @@ static void netconsole_process_cleanups_core(void) mutex_lock(&target_cleanup_list_lock); list_for_each_entry_safe(nt, tmp, &target_cleanup_list, list) { /* all entries in the cleanup_list needs to be disabled */ - WARN_ON_ONCE(nt->enabled); + WARN_ON_ONCE(nt->state == STATE_ENABLED); do_netpoll_cleanup(&nt->np); /* moved the cleaned target to target_list. Need to hold both * locks @@ -398,7 +399,7 @@ static void trim_newline(char *s, size_t maxlen) static ssize_t enabled_show(struct config_item *item, char *buf) { - return sysfs_emit(buf, "%d\n", to_target(item)->enabled); + return sysfs_emit(buf, "%d\n", to_target(item)->state == STATE_ENABLED); } static ssize_t extended_show(struct config_item *item, char *buf) @@ -565,8 +566,8 @@ static ssize_t enabled_store(struct config_item *item, const char *buf, size_t count) { struct netconsole_target *nt = to_target(item); + bool enabled, current_enabled; unsigned long flags; - bool enabled; ssize_t ret; mutex_lock(&dynamic_netconsole_mutex); @@ -575,9 +576,10 @@ static ssize_t enabled_store(struct config_item *item, goto out_unlock; ret = -EINVAL; - if (enabled == nt->enabled) { + current_enabled = nt->state == STATE_ENABLED; + if (enabled == current_enabled) { pr_info("network logging has already %s\n", - nt->enabled ? "started" : "stopped"); + current_enabled ? "started" : "stopped"); goto out_unlock; } @@ -610,16 +612,16 @@ static ssize_t enabled_store(struct config_item *item, if (ret) goto out_unlock; - nt->enabled = true; + nt->state = STATE_ENABLED; pr_info("network logging started\n"); } else { /* false */ /* We need to disable the netconsole before cleaning it up * otherwise we might end up in write_msg() with - * nt->np.dev == NULL and nt->enabled == true + * nt->np.dev == NULL and nt->state == STATE_ENABLED */ mutex_lock(&target_cleanup_list_lock); spin_lock_irqsave(&target_list_lock, flags); - nt->enabled = false; + nt->state = STATE_DISABLED; /* Remove the target from the list, while holding * target_list_lock */ @@ -648,7 +650,7 @@ static ssize_t release_store(struct config_item *item, const char *buf, ssize_t ret; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); ret = -EINVAL; @@ -675,7 +677,7 @@ static ssize_t extended_store(struct config_item *item, const char *buf, ssize_t ret; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); ret = -EINVAL; @@ -699,7 +701,7 @@ static ssize_t dev_name_store(struct config_item *item, const char *buf, struct netconsole_target *nt = to_target(item); mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); mutex_unlock(&dynamic_netconsole_mutex); @@ -720,7 +722,7 @@ static ssize_t local_port_store(struct config_item *item, const char *buf, ssize_t ret = -EINVAL; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); goto out_unlock; @@ -742,7 +744,7 @@ static ssize_t remote_port_store(struct config_item *item, ssize_t ret = -EINVAL; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); goto out_unlock; @@ -765,7 +767,7 @@ static ssize_t local_ip_store(struct config_item *item, const char *buf, int ipv6; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); goto out_unlock; @@ -790,7 +792,7 @@ static ssize_t remote_ip_store(struct config_item *item, const char *buf, int ipv6; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); goto out_unlock; @@ -839,7 +841,7 @@ static ssize_t remote_mac_store(struct config_item *item, const char *buf, ssize_t ret = -EINVAL; mutex_lock(&dynamic_netconsole_mutex); - if (nt->enabled) { + if (nt->state == STATE_ENABLED) { pr_err("target (%s) is enabled, disable to update parameters\n", config_item_name(&nt->group.cg_item)); goto out_unlock; @@ -1330,7 +1332,7 @@ static void drop_netconsole_target(struct config_group *group, * The target may have never been enabled, or was manually disabled * before being removed so netpoll may have already been cleaned up. */ - if (nt->enabled) + if (nt->state == STATE_ENABLED) netpoll_cleanup(&nt->np); config_item_put(&nt->group.cg_item); @@ -1459,7 +1461,7 @@ static int netconsole_netdev_event(struct notifier_block *this, case NETDEV_RELEASE: case NETDEV_JOIN: case NETDEV_UNREGISTER: - nt->enabled = false; + nt->state = STATE_DISABLED; list_move(&nt->list, &target_cleanup_list); stopped = true; } @@ -1726,7 +1728,8 @@ static void write_ext_msg(struct console *con, const char *msg, spin_lock_irqsave(&target_list_lock, flags); list_for_each_entry(nt, &target_list, list) - if (nt->extended && nt->enabled && netif_running(nt->np.dev)) + if (nt->extended && nt->state == STATE_ENABLED && + netif_running(nt->np.dev)) send_ext_msg_udp(nt, msg, len); spin_unlock_irqrestore(&target_list_lock, flags); } @@ -1746,7 +1749,8 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) spin_lock_irqsave(&target_list_lock, flags); list_for_each_entry(nt, &target_list, list) { - if (!nt->extended && nt->enabled && netif_running(nt->np.dev)) { + if (!nt->extended && nt->state == STATE_ENABLED && + netif_running(nt->np.dev)) { /* * We nest this inside the for-each-target loop above * so that we're able to get as much logging out to @@ -1902,7 +1906,7 @@ static struct netconsole_target *alloc_param_target(char *target_config, */ goto fail; } else { - nt->enabled = true; + nt->state = STATE_ENABLED; } populate_configfs_item(nt, cmdline_count); -- 2.51.2