From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC1130F812 for ; Sun, 16 Nov 2025 17:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313259; cv=none; b=Ng/CTuz+CJ6exTmUjdBlQ+QwDzRhV3+HHMqv0XrXcNkh8ow0qcsAGdqjSf+lCb/6zPMfzOiIYU27P5F2cNIFnKMMmZMCEB8kdxxfpb8uL42Zd1cWg5gCmM7BNAH3pmGcfxfPLZ68vzRFI0J2KoySt8pdkmSG6uLQKwGwkM8yYMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313259; c=relaxed/simple; bh=Sl57n5h3qnQFQNcmwKkS4S8dI3DCYu3TXVSej6Ds+H8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I8mouxfSPkRQ9C78FGY3I7CZ5gjviYdDVdVZ+ckQ2dJXd0q4pJPxOi/3rb1aozvMaAlB97Hz9tnB1I+qI/+RYlHlVZ5mY5vrvyofMFpGVCG2nhY1VI/gXdAlGLMmpvgwmDeLpH2g4Ao3btnxiFy4VpHTOvvRVOsuGp89eyJRpws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DU52QHdf; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DU52QHdf" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47755de027eso25430625e9.0 for ; Sun, 16 Nov 2025 09:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763313255; x=1763918055; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=85FBK1N7968Zf3zmy7BJUL2wfVMtCnOsN9wdrJDgfgc=; b=DU52QHdfZ3c9LoJ/OpeuWPZNyiXGETJ2vqM0Fw3xUS3H6cp12wIKIXM8Jvn7L+kRbd yrhBz6fCyn9jwyIDzWBBFOtQzWkzfkiD6ovw5n9QjelYHpxI49udNO7YM2uUg+SIhaJI VcK4kbPvnMalPJkRTcizVfNVGydAiinxNeBUO/4tNtOwf7UaJavWo+wEsw2CHgdESYec mnPAJvD0en/1WvL+ranPVoP8BoDKIS1ayVeYQ/hGSuvXMG6QdJ8gSnuVw1+BXi5EYJPH 6r8IKMYzk97oP/g88v3XNQ4m4PLE8n1TXabxYf1kUg5TEebRBSmnrBh6xxhYru4VJH9E l02w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763313255; x=1763918055; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=85FBK1N7968Zf3zmy7BJUL2wfVMtCnOsN9wdrJDgfgc=; b=XnomqhCqeCpdG2DNkziPuWeqox+l6cg0YVWoOoH9enyrPyXCL8f6I84Jb5KQ/wxKFh lrL8jIjYf9PCVeFoTHZTZ4oBos0VN+QREt10qej8DQQyKGmFrImoVjvqb7Fy3qAWAQGt 0yEDeKlkRSSXPL3wjYmkL2F7JIi9EIUq9LOsEwQtLV+MnwL4/dpxEfrX5esxmr4Jdcsu VZxErlruk6UO3vXWXpjQe+SH//A18HHl2VnEE30//hVBbRupMagdY6q1Tq/8U+ACFPfR PBdk+lVXPcY/hgeCw2xD/Jr1AhJaPj8w8g9/B/Nk+WGfKXSrsg1KinCRZ5Cx64HiHJlk MRvA== X-Forwarded-Encrypted: i=1; AJvYcCXqzE9CN3jhupgN82jL73THQZzhrFxPFWcrrSnWKwzZhz6A3W3f96yJsDWhAoNRIMmSjVHMT+0urHRtqMJkhXU=@vger.kernel.org X-Gm-Message-State: AOJu0YzAQB8EObgGRTg/2AhwrOiuRsNAqxUsljzyfh/NEID1Vl48i8Hg Vg7wc0phHMITHrhldW2JvYldc/IUfmTLMKHf5VerT6D7ke9tSW9Ny/ewjVykg0El4gw= X-Gm-Gg: ASbGncuGqb1Usl5Om0fLMqHGao5B0QsNF0LahCA4/ythEctXD0hmY9l8CxLshw2vDvJ wJp4Vl17VJAWOJaYiiFwTHDuRyJa4jOMG8s0p7L7ZHMf2tnfXKgYDSTdMvruN5aRzFJPoUSErIU g9jN+unWCdZp0pwKnusTaSPQYK2qkqhTcKZ19f1dSS1LAV/CiitsoybNLJgVI5PCKXN8eLPBVUJ zYql7CtVlfBiDZzeULQoHepXTnHsfNB5J2XqdQDL5kuSG+dyf7lDWfWdd7qxlqBHAcFUg3MRg9l 6M77vC4274FeSLjJxLupvxizer9UqOOVy+oMpu/7QVnuv3mRLoV00FddVxewIOnZWJA0Q9bqlet yCt8EId81DSUb4HdmCbvNsR/88Mfg2nANX4erZ7hMUMRyY9u0/CBDQ+oeCYwEqMHY8n2tudMR8z gjCZD7DkG+b8WrAy4xkbe/UHHUqQ== X-Google-Smtp-Source: AGHT+IHNZQXmYL/sgtAzAPtdMkKKiWh8eiU8KGkxT2ZXpK/uFgFhXC8dYE5EiHJesoW2Umma6C8TLQ== X-Received: by 2002:a05:600c:3593:b0:477:557b:6917 with SMTP id 5b1f17b1804b1-4778fe4fdecmr98962925e9.18.1763313255263; Sun, 16 Nov 2025 09:14:15 -0800 (PST) Received: from [192.168.1.243] ([143.58.192.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4779d722bc5sm70874245e9.2.2025.11.16.09.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 09:14:14 -0800 (PST) From: Andre Carvalho Date: Sun, 16 Nov 2025 17:14:03 +0000 Subject: [PATCH net-next v4 3/5] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251116-netcons-retrigger-v4-3-5290b5f140c2@gmail.com> References: <20251116-netcons-retrigger-v4-0-5290b5f140c2@gmail.com> In-Reply-To: <20251116-netcons-retrigger-v4-0-5290b5f140c2@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andre Carvalho X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763313249; l=2028; i=asantostc@gmail.com; s=20250807; h=from:subject:message-id; bh=C8sdELlfliWx0wFIHhmVjWXm2jGpSIoVSQHcSClL97Y=; b=bABY7arpLv8yYqtvmlKZTWMAJKTRxUUlExT7Ut5NXwA7l6L9/NebZ+VsPtz1yWJMHcaHwUv+9 okBlPQZOD/wByUwI7CzxN5iwFeFjLLq2oH693R/I6r35NTIA4MkKadv X-Developer-Key: i=asantostc@gmail.com; a=ed25519; pk=eWre+RwFHCxkiaQrZLsjC67mZ/pZnzSM/f7/+yFXY4Q= From: Breno Leitao When the low level interface brings a netconsole target down, record this using a new STATE_DEACTIVATED state. This allows netconsole to distinguish between targets explicitly disabled by users and those deactivated due to interface state changes. It also enables automatic recovery and re-enabling of targets if the underlying low-level interfaces come back online. >From a code perspective, anything that is not STATE_ENABLED is disabled. Mark the device that is down due to NETDEV_UNREGISTER as STATE_DEACTIVATED, this, should be the same as STATE_DISABLED from a code perspective. Signed-off-by: Breno Leitao Signed-off-by: Andre Carvalho --- drivers/net/netconsole.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 2d15f7ab7235..5a374e6d178d 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -120,6 +120,7 @@ enum sysdata_feature { enum target_state { STATE_DISABLED, STATE_ENABLED, + STATE_DEACTIVATED, }; /** @@ -575,6 +576,14 @@ static ssize_t enabled_store(struct config_item *item, if (ret) goto out_unlock; + /* When the user explicitly enables or disables a target that is + * currently deactivated, reset its state to disabled. The DEACTIVATED + * state only tracks interface-driven deactivation and should _not_ + * persist when the user manually changes the target's enabled state. + */ + if (nt->state == STATE_DEACTIVATED) + nt->state = STATE_DISABLED; + ret = -EINVAL; current_enabled = nt->state == STATE_ENABLED; if (enabled == current_enabled) { @@ -1461,7 +1470,7 @@ static int netconsole_netdev_event(struct notifier_block *this, case NETDEV_RELEASE: case NETDEV_JOIN: case NETDEV_UNREGISTER: - nt->state = STATE_DISABLED; + nt->state = STATE_DEACTIVATED; list_move(&nt->list, &target_cleanup_list); stopped = true; } -- 2.51.2