From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Shuah Khan <shuah@kernel.org>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH] selftests: mptcp: initialize raw_addr to Null
Date: Thu, 27 Nov 2025 17:00:41 -0800 [thread overview]
Message-ID: <20251127170041.0613c50e@kernel.org> (raw)
In-Reply-To: <795a8f3c-eff7-46d9-9175-a4ebe3f9ffd8@kernel.org>
On Wed, 26 Nov 2025 17:55:14 +0100 Matthieu Baerts wrote:
> I confirm this, I can reproduce the warning with Clang 21.
>
> It is indeed a false positive, because the code does that:
>
>
> if (addr.ss_family == AF_INET)
> raw_addr = &(((struct sockaddr_in *)&addr)->sin_addr);
> else if (addr.ss_family == AF_INET6)
> raw_addr = &(((struct sockaddr_in6 *)&addr)->sin6_addr);
> else
> xerror("bad family");
>
>
> "xerror()" calls "exit(1)", so "raw_addr" is never used uninitialized.
>
> I'm not sure why Clang 21 reports that now, and not before, but well,
> the modification you did in the selftests doesn't hurt:
I think annotating xerror with __noreturn is a better fix.
Including kselftest.h will be needed.
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-28 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 16:30 [PATCH] selftests: mptcp: initialize raw_addr to Null Ankit Khushwaha
2025-11-26 16:55 ` Matthieu Baerts
2025-11-28 1:00 ` Jakub Kicinski [this message]
2025-11-28 10:34 ` Matthieu Baerts
2025-11-28 18:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127170041.0613c50e@kernel.org \
--to=kuba@kernel.org \
--cc=ankitkhushwaha.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=morbo@google.com \
--cc=mptcp@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).