From: Caleb Sander Mateos <csander@purestorage.com>
To: Ming Lei <ming.lei@redhat.com>, Shuah Khan <shuah@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Caleb Sander Mateos <csander@purestorage.com>
Subject: [PATCH v3 2/9] selftests: ublk: correct last_rw map type in seq_io.bt
Date: Fri, 12 Dec 2025 10:17:00 -0700 [thread overview]
Message-ID: <20251212171707.1876250-3-csander@purestorage.com> (raw)
In-Reply-To: <20251212171707.1876250-1-csander@purestorage.com>
The last_rw map is initialized with a value of 0 but later assigned the
value args.sector + args.nr_sector, which has type sector_t = u64.
bpftrace complains about the type mismatch between int64 and uint64:
trace/seq_io.bt:18:3-59: ERROR: Type mismatch for @last_rw: trying to assign value of type 'uint64' when map already contains a value of type 'int64'
@last_rw[$dev, str($2)] = (args.sector + args.nr_sector);
Cast the initial value to uint64 so bpftrace will load the program.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
---
tools/testing/selftests/ublk/trace/seq_io.bt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ublk/trace/seq_io.bt b/tools/testing/selftests/ublk/trace/seq_io.bt
index 272ac54c9d5f..507a3ca05abf 100644
--- a/tools/testing/selftests/ublk/trace/seq_io.bt
+++ b/tools/testing/selftests/ublk/trace/seq_io.bt
@@ -2,11 +2,11 @@
$1: dev_t
$2: RWBS
$3: strlen($2)
*/
BEGIN {
- @last_rw[$1, str($2)] = 0;
+ @last_rw[$1, str($2)] = (uint64)0;
}
tracepoint:block:block_rq_complete
{
$dev = $1;
if ((int64)args.dev == $1 && !strncmp(args.rwbs, str($2), $3)) {
--
2.45.2
next prev parent reply other threads:[~2025-12-12 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 17:16 [PATCH v3 0/9] selftests: ublk: add user copy test cases Caleb Sander Mateos
2025-12-12 17:16 ` [PATCH v3 1/9] selftests: ublk: fix overflow in ublk_queue_auto_zc_fallback() Caleb Sander Mateos
2025-12-12 17:17 ` Caleb Sander Mateos [this message]
2025-12-12 17:17 ` [PATCH v3 3/9] selftests: ublk: remove unused ios map in seq_io.bt Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 4/9] selftests: ublk: fix fio arguments in run_io_and_recover() Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 5/9] selftests: ublk: use auto_zc for PER_IO_DAEMON tests in stress_04 Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 6/9] selftests: ublk: don't share backing files between ublk servers Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 7/9] selftests: ublk: forbid multiple data copy modes Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 8/9] selftests: ublk: add support for user copy to kublk Caleb Sander Mateos
2025-12-12 17:17 ` [PATCH v3 9/9] selftests: ublk: add user copy test cases Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212171707.1876250-3-csander@purestorage.com \
--to=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox