From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D33220296E for ; Tue, 6 Jan 2026 00:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767661091; cv=none; b=UKjiudPE85JOXJ8CdvjrAnK7xPsdYxrJCxShnxUbuyREiYEUJnKyQNnwUIT+KI+RsrZYRVbB3M+TEAycZRXdw4/BsJrfJtRstmc+f8YKrke8jpn7S0FbIczzrg7ZkH8tj+I+jedjo5okXyK0bIymmEb1yV7zKs2dCnWJM6gsQZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767661091; c=relaxed/simple; bh=RSIk539QU0YeMD2OF+ndA/QgOH1sYpMVe11eirRJlyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t8BRMe3RYrVHUe7dnjdhBxD9BcJSL+sTWiCZ6MnVenEEPaa1O5GSjEFW50ji55kK9AFI48nzRSiM0v+OaOzayRbubhdoprQ7G+jDsFShv1w3kdHSPa7BDnuvXd/Tvr6A+mYmhGgdbvntfS6brewzAhV3dh7pcadzaXl4fNzy7Ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=BrX4KviQ; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="BrX4KviQ" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2a31d7107faso564735ad.0 for ; Mon, 05 Jan 2026 16:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767661088; x=1768265888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mNgOa//j6HpxCA/+vGAeV8sKsy7oyXQnnYVexO4WVVc=; b=BrX4KviQsz+XG4J9E3zXQAD/ol+fsN7fTiwHMP6mCOP9vuaEqPtosgAag4llHOaFX7 1sVuzEJWzUNDccetaHTxYGSNFVlObsJmt8cgsgE8O63vQkV7bntKD0jJ6nJUsoRtJa16 7lbfkeObnE/HTvBQu9TWTGOyvbNjM/fmlZ3/NS6HtzwttbUCYg30oC/lJWidpUlYxNx6 39DqqCx9mQhSpno9JS6KvARCSIR+eneyk4oza7bO7UWIayX/dwYQ48PuZkFFl7BbnMlz 5rcB3GMq0oNskhKn2Gq/g+XRelzZypqSbFEjNVd1xpEmlGGUiJCtmjicXteifZqfmHX2 p8QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767661088; x=1768265888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mNgOa//j6HpxCA/+vGAeV8sKsy7oyXQnnYVexO4WVVc=; b=hrZF2yulc9XVwYFQ86X1N/o7z1xAuNlGrtvVhyvLWxvb0GX7NTs+XfdYX8AyZ12vu9 7B3h1tIopQHYBZI1TdyLmo/ioFl+c4+cE1I5CJZMO0zXU1+dsvR59ppYuBm5wbhKMohu /cNjH/IDQ34cDT+VSGtI3eY9DijbcZ1qc111/w6rZzqTLAUsBvtmX2jNfSBS/d35pYOi vDA+FdHWJNV96ypUqNkkxTfm8lVsNEVL5XPDWWCTV1wYtMOTyPAPd9QdmsaphNW+0E3h 3SQvRO+FEwVVOkfHv6yF8EJ1gqN6MXNAPnvvX9ArkwFK1EPTjk5MFJM6N0ACRE9TBBGz r1RQ== X-Forwarded-Encrypted: i=1; AJvYcCXkICwA36BQhzD1tqyMcnUYixdcnQI/9S0JmrS+u55X1czax21JvtOPAIolUyHjzNxrePZzEPuaR0umCUn/hlg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+nudT6n386+JDbCniEm834k3cyiIT4M3cgppw/oiGfXtwDjJh HIdQJ1/HH3Otu/V8JUAAoseo4JGJDvRSqsuRtvNi/QR1ax1TdXnMRLeggJauimDkCgfEVh0rDVQ w2q2OJMUrbDJqA9+fspqGJPsM5JNRVU3gb7zP X-Gm-Gg: AY/fxX4/Z1PO/X7+rWj+Y4DJf9zSlPad1Yd1qDuulVz9MLYBY1skapVu08g4Va6NVFP 1aoTL858/2iHSow30kU5GTabGpaJu4Y7+QHDEgZG11f5pSWyFXgWLDrh4CqBvQbxmXUCuQrnIMW 69sak7q6uHikO1vhoGyPmpZ6mNEicK2wuoGPvQWyk3M/7B0cNnVwyWlg4z4HeKkpkRX56YBA2Bq AsYnlRjJJTeS0zDJkjQhf+KNeMjt/zNe9PdwUobUcYZ3HDSgp+nNNvIIxkXjnx7poo7bOiBRhRk wipkCpv38tZnRTeHnHfSa7qNsIINoTSaiYkvK/HzUUGb++E989xW49/E+wCewdEsjPab9aIykek VNYt4ROUa4nD6RC9hf65YxhOKhi+XqEKFZpXA05+K9Q== X-Google-Smtp-Source: AGHT+IHKb22UjylnDKoA0W9fny7bybwLOIO7bAf/WzC4axVyVJ8PaetqijQugZHk6m8KpWwx3aSCOjDDD8PD X-Received: by 2002:a17:902:e741:b0:29e:3822:5763 with SMTP id d9443c01a7336-2a3e2e5c956mr9922685ad.9.1767661088568; Mon, 05 Jan 2026 16:58:08 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2a3e3cc4ab4sm821145ad.44.2026.01.05.16.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 16:58:08 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.49.34.222]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 07BFB340960; Mon, 5 Jan 2026 17:58:08 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id EC714E44554; Mon, 5 Jan 2026 17:58:07 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Stanley Zhang , Uday Shankar , "Martin K . Petersen" , Caleb Sander Mateos Subject: [PATCH v3 02/19] ublk: move ublk flag check functions earlier Date: Mon, 5 Jan 2026 17:57:34 -0700 Message-ID: <20260106005752.3784925-3-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260106005752.3784925-1-csander@purestorage.com> References: <20260106005752.3784925-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ublk_dev_support_user_copy() will be used in ublk_validate_params(). Move these functions next to ublk_{dev,queue}_is_zoned() to avoid needing to forward-declare them. Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- drivers/block/ublk_drv.c | 60 ++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 837fedb02e0d..8e3da9b2b93a 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -273,10 +273,40 @@ static inline struct ublksrv_io_desc * ublk_get_iod(const struct ublk_queue *ubq, unsigned tag) { return &ubq->io_cmd_buf[tag]; } +static inline bool ublk_support_zero_copy(const struct ublk_queue *ubq) +{ + return ubq->flags & UBLK_F_SUPPORT_ZERO_COPY; +} + +static inline bool ublk_dev_support_zero_copy(const struct ublk_device *ub) +{ + return ub->dev_info.flags & UBLK_F_SUPPORT_ZERO_COPY; +} + +static inline bool ublk_support_auto_buf_reg(const struct ublk_queue *ubq) +{ + return ubq->flags & UBLK_F_AUTO_BUF_REG; +} + +static inline bool ublk_dev_support_auto_buf_reg(const struct ublk_device *ub) +{ + return ub->dev_info.flags & UBLK_F_AUTO_BUF_REG; +} + +static inline bool ublk_support_user_copy(const struct ublk_queue *ubq) +{ + return ubq->flags & UBLK_F_USER_COPY; +} + +static inline bool ublk_dev_support_user_copy(const struct ublk_device *ub) +{ + return ub->dev_info.flags & UBLK_F_USER_COPY; +} + static inline bool ublk_dev_is_zoned(const struct ublk_device *ub) { return ub->dev_info.flags & UBLK_F_ZONED; } @@ -671,40 +701,10 @@ static void ublk_apply_params(struct ublk_device *ub) if (ub->params.types & UBLK_PARAM_TYPE_ZONED) ublk_dev_param_zoned_apply(ub); } -static inline bool ublk_support_zero_copy(const struct ublk_queue *ubq) -{ - return ubq->flags & UBLK_F_SUPPORT_ZERO_COPY; -} - -static inline bool ublk_dev_support_zero_copy(const struct ublk_device *ub) -{ - return ub->dev_info.flags & UBLK_F_SUPPORT_ZERO_COPY; -} - -static inline bool ublk_support_auto_buf_reg(const struct ublk_queue *ubq) -{ - return ubq->flags & UBLK_F_AUTO_BUF_REG; -} - -static inline bool ublk_dev_support_auto_buf_reg(const struct ublk_device *ub) -{ - return ub->dev_info.flags & UBLK_F_AUTO_BUF_REG; -} - -static inline bool ublk_support_user_copy(const struct ublk_queue *ubq) -{ - return ubq->flags & UBLK_F_USER_COPY; -} - -static inline bool ublk_dev_support_user_copy(const struct ublk_device *ub) -{ - return ub->dev_info.flags & UBLK_F_USER_COPY; -} - static inline bool ublk_need_map_io(const struct ublk_queue *ubq) { return !ublk_support_user_copy(ubq) && !ublk_support_zero_copy(ubq) && !ublk_support_auto_buf_reg(ubq); } -- 2.45.2