From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44EB19DFAB for ; Sun, 11 Jan 2026 06:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768114013; cv=none; b=M21dPu3I5uZ5XTWzRZqvGaWUEVMvXOUm71Lc/HIz+dG9WHuFg7+4rXP4qKtSUUzyzTpBI3InPpPvYEKD6rXG7lXvP8H5cVzp+fzVEKU8n/ZxqeBNYxffnyf/QnmjFjnmcdPs/0JC6A17WtR5tzEs+sGSFmAFR8VFkqTkEMJBET0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768114013; c=relaxed/simple; bh=oJg0P4BTaPqRMdngCealJvjnKfXREQ/BhzD4UuLebrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EQAoKW/1HCYGxvXNVacVXU/Sj0o+duEWWAiXsxjEK/QyVbIAzT7NC//aE5YYeiY8F4EhHZZjFvc6sMBXVcSfNOQisgBCxGoih2h40nqsibmLcvYd74SgC1XPOil4zGqI9dSTTwvHgGmE8gITTN/NNfKS6tCx+ml+qoTBMJsUWrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O10Je4S/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BVQkdGxl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O10Je4S/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BVQkdGxl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768114010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=O10Je4S/0mj3/LPejRBE7XpZW6dJZxWq7pdBqjSJ+NgpqtMdnLJa7kV148aeccSpUFP2ZL mfTtlZwZUnbujfXpqUHVVbEcM33Hnl53hNAIUIFn0gpF1N82jwnhhspOsD40Wk9KPeSkna etzSTUabdkMMByVjIfj1kCGJokTBzf4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-uLFpA24NOhmDgFd7OvBe7g-1; Sun, 11 Jan 2026 01:46:49 -0500 X-MC-Unique: uLFpA24NOhmDgFd7OvBe7g-1 X-Mimecast-MFC-AGG-ID: uLFpA24NOhmDgFd7OvBe7g_1768114008 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477a11d9e67so36434945e9.2 for ; Sat, 10 Jan 2026 22:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768114008; x=1768718808; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=BVQkdGxlmes97/Xxz8ptRBGThZdXBaCNR0MDLkKbuAF+QAWaRq0aWy6rM5ANq0Ci8F ttKuQoJcdSZQ1K28OhZw520jH236Z1kKM63E9pHXMgmwg5S0jTZcCPyJ1l9kymFpk8og r0XSKqzB4ARKbQ7a2fy8jFmmIO2wzpmEDyldZtuEN4ahgEg9QA9y2UEtG8rV1Xz43BB2 z/1wrmbU996DGFBmBP3s5unkBEen2DHH+khnjxTV43UQXvukTqjg8bAjBnPLjdrsxnNI eCrI6+RnKHWIF+7UTKptHPiL65vXp8VbyuBhTuzFiobXPBsK/QNUEaTKCgjSBFg/sPsk wktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768114008; x=1768718808; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iQ7hDBixKgHX7F8NTcaObvBvSlkQPDzeM4vIOMax5Nk=; b=M/O1yX6aeW1YZj2/0NBesDknqxjCbX6i2HbsnsX3pp2BVuhgKEYUeaiMa/qyqW+a/5 NGvQcDRvyDn60bD8Tx2Z8I6wNrW5q8A3bruHDPPIby4sxV2qaSqPJCGyPoLMTquUX+Bh z28ZXZAQOg5/SqaNBzalDIxHNugd3WtTQXepvnbB7/LVZdNnZBwLeEOUSwOlkIcei8wb whJDFFz0Hxm68u0GtCZLbTqNuSsU1xJr3R1NvLT6BtYiKXwcu50KFSoFDz+lTiE2bNIN F5Whhj68rU74OTCcxKHl5Hbor8HZM6t/aur+rvTHfjNnlpKoT0g+Deaym6qAL6I2rhso Yk1w== X-Forwarded-Encrypted: i=1; AJvYcCX97UgPY2LJuK5MOlSLBRCAiiX7fMlFDo6lc30xNCIqPMoOajwzWJj9C11yERusagyOI4WSr0K1VOw2/ofw7U4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe4hfyMWpLiuTk8CL+uofuyF2UZ3I3qVRfD02lAT2FQ0POBVsN 6y0H/wRczaxlOcH3LWptkOvP4ikwB0RFb9zqmA1NeDZ5yJY/xhV/BfxAuRtgI6COXH04BFEc74g jtaRDlcKg2OlcVmmHqopUfKhTXiPXzdD1+aaCTWFVxjvPmFSt4T/K7UwVylG4XzLCCLkM3w== X-Gm-Gg: AY/fxX6mm8RaUBzTiox9RfPSYT4Yn8cAlg6lX0VfR9bbVjpNNFV2B7Trbci8kB5SFqj oLppzeLR543we4MI04/rWUUkml/jB4K5kCZohki8RsjLZ/rF30MOCN3dTCrAjoLkXbNFrybvVrt SxgYmyTpjD7AbnbS7+Lp+MfATzMfAOSJNX/1hzmtOu/QxfbZbs/ITf4D3b5oREMSU5ZQ3uDMKX1 NtaO0Ay6LC/lwBZVH6jb0BooqN38yQanQufD/BR6dhAZByHaShB0UQgN4B8PGQxDBp8SXFQ48YV r+hCU3IrGx45BYu30GqnNfZRF2AXlSBOj0JNn8hVoX1DZxCTcUBeg1hCDOmYpqZ8EV8WXC5UuPM TDaCx2fyACoakr+sB8sdP09bq4eSCvO8= X-Received: by 2002:a05:600c:444c:b0:477:7b16:5f77 with SMTP id 5b1f17b1804b1-47d84b0b303mr138047745e9.3.1768114008101; Sat, 10 Jan 2026 22:46:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2KhXxY5wNvI0FhPEnxgIqYrJLuszMdozjkRjhQaSurG33CO00c2A2r97DP2kFBqnSLT0brQ== X-Received: by 2002:a05:600c:444c:b0:477:7b16:5f77 with SMTP id 5b1f17b1804b1-47d84b0b303mr138047395e9.3.1768114007653; Sat, 10 Jan 2026 22:46:47 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d865e3d22sm102237315e9.1.2026.01.10.22.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 22:46:47 -0800 (PST) Date: Sun, 11 Jan 2026 01:46:43 -0500 From: "Michael S. Tsirkin" To: Bobby Eshleman Cc: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH RFC net-next v13 03/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply Message-ID: <20260111014500-mutt-send-email-mst@kernel.org> References: <20251223-vsock-vmtest-v13-0-9d6db8e7c80b@meta.com> <20251223-vsock-vmtest-v13-3-9d6db8e7c80b@meta.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251223-vsock-vmtest-v13-3-9d6db8e7c80b@meta.com> On Tue, Dec 23, 2025 at 04:28:37PM -0800, Bobby Eshleman wrote: > From: Bobby Eshleman > > Associate reply packets with the sending socket. When vsock must reply > with an RST packet and there exists a sending socket (e.g., for > loopback), setting the skb owner to the socket correctly handles > reference counting between the skb and sk (i.e., the sk stays alive > until the skb is freed). > > This allows the net namespace to be used for socket lookups for the > duration of the reply skb's lifetime, preventing race conditions between > the namespace lifecycle and vsock socket search using the namespace > pointer. > > Reviewed-by: Stefano Garzarella > Signed-off-by: Bobby Eshleman > --- > Changes in v11: > - move before adding to netns support (Stefano) can you explain about the revert please? I looked at feedback from Stefano and all he said aparently was not to break bisect. > Changes in v10: > - break this out into its own patch for easy revert (Stefano) > --- > net/vmw_vsock/virtio_transport_common.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index fdb8f5b3fa60..718be9f33274 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -1165,6 +1165,12 @@ static int virtio_transport_reset_no_sock(const struct virtio_transport *t, > .op = VIRTIO_VSOCK_OP_RST, > .type = le16_to_cpu(hdr->type), > .reply = true, > + > + /* Set sk owner to socket we are replying to (may be NULL for > + * non-loopback). This keeps a reference to the sock and > + * sock_net(sk) until the reply skb is freed. > + */ > + .vsk = vsock_sk(skb->sk), > }; > struct sk_buff *reply; > > > -- > 2.47.3