From: zishun yi <zishun.yi.dev@gmail.com>
To: shuah@kernel.org
Cc: vivek.kasireddy@intel.com, akpm@linux-foundation.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.weiyang@gmail.com, reddybalavignesh9979@gmail.com,
zishun yi <zishun.yi.dev@gmail.com>
Subject: [PATCH v1] selftests: udmabuf: fix hugepage size calculation
Date: Sun, 18 Jan 2026 21:51:26 +0800 [thread overview]
Message-ID: <20260118135126.102472-1-zishun.yi.dev@gmail.com> (raw)
udmabuf's test 6 and 7 is intended to verify the behavior of 2MB huge pages migration,
but the helper function still calculates the size using standard (4KB) pages.
Signed-off-by: zishun yi <zishun.yi.dev@gmail.com>
---
tools/testing/selftests/drivers/dma-buf/udmabuf.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/drivers/dma-buf/udmabuf.c b/tools/testing/selftests/drivers/dma-buf/udmabuf.c
index d78aec662586..8887fb9b79df 100644
--- a/tools/testing/selftests/drivers/dma-buf/udmabuf.c
+++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c
@@ -69,7 +69,7 @@ static int create_udmabuf_list(int devfd, int memfd, off64_t memfd_size)
for (i = 0; i < NUM_ENTRIES; i++) {
list->list[i].memfd = memfd;
list->list[i].offset = i * (memfd_size / NUM_ENTRIES);
- list->list[i].size = getpagesize() * NUM_PAGES;
+ list->list[i].size = page_size * NUM_PAGES;
}
list->count = NUM_ENTRIES;
@@ -115,8 +115,8 @@ static int compare_chunks(void *addr1, void *addr2, off64_t memfd_size)
while (i < NUM_ENTRIES) {
off = i * (memfd_size / NUM_ENTRIES);
for (j = 0; j < NUM_PAGES; j++, k++) {
- char1 = *((char *)addr1 + off + (j * getpagesize()));
- char2 = *((char *)addr2 + (k * getpagesize()));
+ char1 = *((char *)addr1 + off + (j * page_size));
+ char2 = *((char *)addr2 + (k * page_size));
if (char1 != char2) {
ret = -1;
goto err;
@@ -126,7 +126,7 @@ static int compare_chunks(void *addr1, void *addr2, off64_t memfd_size)
}
err:
munmap(addr1, memfd_size);
- munmap(addr2, NUM_ENTRIES * NUM_PAGES * getpagesize());
+ munmap(addr2, NUM_ENTRIES * NUM_PAGES * page_size);
return ret;
}
@@ -240,7 +240,7 @@ int main(int argc, char *argv[])
addr1 = mmap_fd(memfd, size);
write_to_memfd(addr1, size, 'a');
buf = create_udmabuf_list(devfd, memfd, size);
- addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * getpagesize());
+ addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * page_size);
write_to_memfd(addr1, size, 'b');
ret = compare_chunks(addr1, addr2, size);
if (ret < 0)
@@ -256,7 +256,7 @@ int main(int argc, char *argv[])
size = MEMFD_SIZE * page_size;
memfd = create_memfd_with_seals(size, true);
buf = create_udmabuf_list(devfd, memfd, size);
- addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * getpagesize());
+ addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * page_size);
addr1 = mmap_fd(memfd, size);
write_to_memfd(addr1, size, 'a');
write_to_memfd(addr1, size, 'b');
--
2.52.0
next reply other threads:[~2026-01-18 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 13:51 zishun yi [this message]
2026-01-18 20:38 ` [PATCH v1] selftests: udmabuf: fix hugepage size calculation Andrew Morton
2026-01-22 6:47 ` Kasireddy, Vivek
2026-01-22 21:45 ` Andrew Morton
2026-01-23 0:21 ` zishun yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260118135126.102472-1-zishun.yi.dev@gmail.com \
--to=zishun.yi.dev@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reddybalavignesh9979@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=shuah@kernel.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox