public inbox for linux-kselftest@vger.kernel.org
 help / color / mirror / Atom feed
From: Hubert Mazur <hmazur@google.com>
To: Shuah Khan <shuah@kernel.org>, Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Cc: Slawomir Rosek <srosek@google.com>,
	Lukasz Majczak <lmajczak@google.com>,
	 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Hubert Mazur <hmazur@google.com>
Subject: [PATCH v1 0/1] Make the script complaint with 'sh' shell
Date: Wed, 18 Mar 2026 08:08:24 +0000	[thread overview]
Message-ID: <20260318080825.3063959-1-hmazur@google.com> (raw)

Hello,

I'm sending a change that modifies the script a bit to make it
compliant with the 'sh' shell. The reason behind it is that the test
cannot be executed on x86 embedded devices without bash. The introduced
changes are:
- /bin/bash -> /bin/sh
- Usage of env $UID changed to command execution $(id -u)
- $FUNCNAME env changed to local variables with function names

I'm aware that the last one may be the most controversial since it is
not the most elegant one, though I didn't find any better solution
to retrieve the name of currently executed function in 'sh'.

Please take a look.

Regards,
Hubert

Hubert Mazur (1):
  selftests/cpu-hotplug: Make the script complaint with sh shell

 tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.53.0.959.g497ff81fa9-goog


             reply	other threads:[~2026-03-18  8:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  8:08 Hubert Mazur [this message]
2026-03-18  8:08 ` [PATCH v1 1/1] selftests/cpu-hotplug: Make the script complaint with sh shell Hubert Mazur
2026-03-31 21:52   ` Shuah Khan
2026-04-01 11:56     ` Hubert Mazur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318080825.3063959-1-hmazur@google.com \
    --to=hmazur@google.com \
    --cc=jihed.chaibi.dev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lmajczak@google.com \
    --cc=shuah@kernel.org \
    --cc=srosek@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox