Re: [PATCH net-next v3 6/7] net: team: Decouple rx and tx enablement in the team driver

Jiri Pirko
2026-04-02T12:54:59Z

Thu, Apr 02, 2026 at 08:24:19AM +0200, marcharvey@google.com wrote:
>There are use cases where an aggregated port should send traffic, but
>not receive traffic, and vice versa. For example, in the IEEE
>802.3ad-2000 specification, there is an optional "Independent Control"
>version of the mux machine. Currently there is no way create
>implementations like this for the team driver.
>
>Separate the existing "enabled" per-port option into tx and rx
>specific enablement options, but do so without breaking the existing
>"enabled" option. The existing "enabled" option is now defined as
>(rx_enabled AND tx_enabled), so if one is independently disabled, then
>the old "enabled" option will also not be enabled. However, setting
>the old "enabled" option affects both the rx_enabled and tx_enabled
>options. This is the first case where setting an option can affect
>another option.
>
>Note that teamd and any other software that exclusively uses "coupled"
>enablement will continue to work without any changes.
>
>Signed-off-by: Marc Harvey <marcharvey@google.com>
>---
>Changes in v3:
>- None
>
>Changes in v2:
>- None
>---
> drivers/net/team/team_core.c | 238 ++++++++++++++++++++++++++-----
> drivers/net/team/team_mode_loadbalance.c | 4 +-
> drivers/net/team/team_mode_random.c | 4 +-
> drivers/net/team/team_mode_roundrobin.c | 2 +-
> include/linux/if_team.h | 60 +++++---
> 5 files changed, 245 insertions(+), 63 deletions(-)

I see multiple patches squashed here. Could you please split for
easier review?

Renames separate, preparations separate, adding rx_en separate, adding
tx_en separata etc?

Thanks!