Re: [PATCH net-next v7] selftests: net: add tests for PPP

Andrew Lunn
2026-04-02T14:37:24Z

On Thu, Apr 02, 2026 at 08:04:23PM +0800, Qingfang Deng wrote:
> On Thu, Apr 2, 2026 at 7:17 PM Paolo Abeni <pabeni@redhat.com> wrote:
> >
> > On 4/2/26 12:13 PM, Qingfang Deng wrote:
> >
> > > What distro do you run CI tests on? On Ubuntu 24.04, "rp-pppoe.so" is
> > > a symlink to "pppoe.so" in apt package "ppp". Maybe an additional
> > > package is required for the distro you use, or I may work around that
> > > by manually creating the symlink.
> >
> > It's fedora 43 with ppp and pppoe installed.
> >
> > ppp provides pppoe.so, and AFAICS nothink provides rp-pppoe.so, and the
> > pppoe-server is looking for a non existing /etc/ppp/plugins/rp-pppoe.so
> > plugin.
> >
> > Before I mess with the nipa testbed, could you please double check that
> >
> > ln -n /usr/lib64/pppd/2.5.1/pppoe.so /etc/ppp/plugins/rp-pppoe.so
> >
> > should solve?
>
> Hard links will also work.
> Alternatively, if your rp-pppoe version is 4.0, you can use the new
> option `-g` to specify the full path of the pppoe.so plugin.

It should be possible for anybody to run these self tests. So we don't
want specially crafted setups, but generic setups which will work for
as many people as possible.

It looks like v4.0 we released 2024-09-09. So can we make that the
minimum version? Fail the test if an older version is found? Can the
test poke around the file system and find rp-pppoe.so and pass it
using -g?

Andrew