Re: [PATCH 07/53] selftests/mm: hugetlb-shm: use kselftest framework

Mike Rapoport
2026-04-13T10:19:04Z

Hi,

On Thu, Apr 09, 2026 at 03:19:45PM +0530, Donet Tom wrote:
> Hi Mike
>
> On 4/6/26 7:46 PM, Mike Rapoport wrote:
> > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> >
> > Convert hugetlb-shm test to use kselftest framework for reporting and
> > tracking successful and failing runs.
> >
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> > ---
> > tools/testing/selftests/mm/hugetlb-shm.c | 46 ++++++++++++------------
> > 1 file changed, 23 insertions(+), 23 deletions(-)

...

> > - dprintf("\n");
> > - dprintf("Starting the Check...");
> > + ksft_print_msg("Starting the Check...");
>
>
> Do we need to add a newline (\n) here? The output is currently printed as:
> # Starting the Check...# Done.
> If this is intentional, please ignore this comment. Otherwise, it looks good
> to me.

The original would print

# Starting the Check...Done

I don't think the extra # is important enough to change something here.

> ./hugetlb-shm
> TAP version 13
> 1..1
> # shmid: 0x1
> # shmaddr: 0x7ffface00000
> # Starting the writes:
> # Starting the Check...# Done.
> ok 1 hugepage using SysV shmget/shmat
> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Reviewed by: Donet Tom <donettom@linux.ibm.com>
>
> -Donet

--
Sincerely yours,
Mike.