Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yuwen Chen <ywen.chen@foxmail.com>
Cc: andrealmeid@igalia.com, bigeasy@linutronix.de,
	colin.i.king@gmail.com, dave@stgolabs.net, dvhart@infradead.org,
	edliaw@google.com, justinstitt@google.com,
	kernel-team@android.com, licayy@foxmail.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	luto@mit.edu, mingo@redhat.com, morbo@google.com,
	nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org,
	shuah@kernel.org, tglx@kernel.org, usama.anjum@collabora.com,
	wakel@google.com
Subject: Re: [RESEND PATCH v3] selftests/futex: fix the failed futex_requeue test issue
Date: Thu, 30 Apr 2026 16:41:27 -0700	[thread overview]
Message-ID: <20260430164127.b8d68639a5c1708411cf7508@linux-foundation.org> (raw)
In-Reply-To: <tencent_1BF14BBF2BBF088E3B609CC155EC7C206F05@qq.com>

On Mon, 27 Apr 2026 18:18:38 +0800 Yuwen Chen <ywen.chen@foxmail.com> wrote:

> This test item has extremely high requirements for timing and can only
> pass the test under specific conditions. The following situations will
> lead to test failure:
> 
>     MainThread                  Thread1
>         │
>   pthread_create-------------------┐
>         │                          │
>  futex_cmp_requeue                 │
>         │                     futex_wait
>         │                          │
> 
> If the child thread is not waiting in the futex_wait function when the
> main thread reaches the futex_cmp_requeue function, the test will fail.

So you're saying that this test is generally flakey and annoying?

Yup, we would like to fix that.

> This patch avoids this problem by checking whether the child thread is
> in a sleeping state in the main thread.

Thanks! 

AI review asked some questions, as it likes to do:
	https://sashiko.dev/#/patchset/tencent_1BF14BBF2BBF088E3B609CC155EC7C206F05@qq.com

  parent reply	other threads:[~2026-04-30 23:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  7:16 [PATCH v3] selftests/futex: fix the failed futex_requeue test issue Yuwen Chen
2026-04-27 10:18 ` [RESEND PATCH " Yuwen Chen
2026-04-28 10:58   ` Sebastian Andrzej Siewior
2026-04-29  1:40     ` Yuwen Chen
2026-04-30 23:41   ` Andrew Morton [this message]
2026-05-06  3:35     ` Yuwen Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430164127.b8d68639a5c1708411cf7508@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andrealmeid@igalia.com \
    --cc=bigeasy@linutronix.de \
    --cc=colin.i.king@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=edliaw@google.com \
    --cc=justinstitt@google.com \
    --cc=kernel-team@android.com \
    --cc=licayy@foxmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tglx@kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=wakel@google.com \
    --cc=ywen.chen@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox