From: Jakub Kicinski <kuba@kernel.org>
To: "Íñigo Huguet" <ihuguet@riseup.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Sabrina Dubroca <sd@queasysnail.net>,
Filip Pokryvka <fpokryvk@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 0/5] netdevsim: get link via ethtool, set via sysfs
Date: Sun, 10 May 2026 09:52:46 -0700 [thread overview]
Message-ID: <20260510095246.5c8f6d0b@kernel.org> (raw)
In-Reply-To: <20260510164337.7611-1-ihuguet@riseup.net>
On Sun, 10 May 2026 18:43:32 +0200 Íñigo Huguet wrote:
> Allow to read the carrier status of a netdevsim device via ethtool, like
> most of Ethernet devices allow.
>
> Also, allow to set its carrier status via sysfs. Currently it's only
> possible by linking a peer device and setting its admin state to
> UP/DOWN. By editing the carrier status via sysfs tests that need to
> check carrier related stuff may be simpler.
>
> The third patch add the proper selftest for both things, and the fourth
> and fifth fix a few small bugs in the selftest itself.
Could you please explain your motivation? Feels quite trivial,
so it's not immediately obvious why we need tests.
prev parent reply other threads:[~2026-05-10 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 16:43 [PATCH net-next 0/5] netdevsim: get link via ethtool, set via sysfs Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 1/5] netdevsim: Add ethtool get_link support Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 2/5] netdevsim: allow changing carrier state via sysfs Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 3/5] selftest: netdevsim: test carrier change " Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 4/5] selftest: netdevsim: cleanup the devices and module on failure Íñigo Huguet
2026-05-10 16:43 ` [PATCH net-next 5/5] selftest: netdevsim: suppress socat warnings Íñigo Huguet
2026-05-10 16:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510095246.5c8f6d0b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fpokryvk@redhat.com \
--cc=ihuguet@riseup.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox