From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE63356A0A for ; Wed, 13 May 2026 07:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778657483; cv=none; b=cJpkrVZHVim99P2bT1clRWxt+jvO92ubc+SinnceYAOL0JQhRNOdqhpEeefPzdumOsTU9hgQGEgrAkJPuDRDxA/XOrUqr5L3oTRdsywa8StGTW5PBVNR+mJv+5v87G5Ou1k+a7eFJ5Z5t3lzz1SXBlGP5I9uC+hzwnNbN1yS9T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778657483; c=relaxed/simple; bh=L5Yg5uVqrkobj7bmXCB6WQm8iYeZIrVy6jTHOY+8NLc=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=u7jPvBstvvqCGLIG/QAsS4JqpQXxnwOSPB/1g0Lmo6cafFTTgmyg1evv98mUqTCXDMtfEfW1z2LwTG+occSjEUHZXTBXuNKcDTlSYYLzgOgwZEOo5SOaNacfmSKahxfhDSgNjf1wKCyAWPyTs15ae/We8nurP1/1OseUOzRJkqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GRzK3ieB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GRzK3ieB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778657480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jKqEdpwEL44n322oM5dzYdh/fnpCSr+Dp2MnzVEGH7E=; b=GRzK3ieBD6PwIQHOwOntCyTdhYq3MxROgfHa9k9MhmtfxxakzLN+/S5PGZBc/sqUktMkXE p+3iD9VFnLBFuIoo4UL8rrBqS7wrCNZJOJ+67S2Xhs3HjYkNHyhEjbQ2s5kRqYqroXRpiT 2zsaIR79PdEybJkK2hCwPZi//1TwXJs= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-31-DPwmEbudOqCZ0DsZ6xBCTQ-1; Wed, 13 May 2026 03:31:16 -0400 X-MC-Unique: DPwmEbudOqCZ0DsZ6xBCTQ-1 X-Mimecast-MFC-AGG-ID: DPwmEbudOqCZ0DsZ6xBCTQ_1778657471 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B01B1956089; Wed, 13 May 2026 07:31:09 +0000 (UTC) Received: from [192.168.1.153] (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C8B618004A3; Wed, 13 May 2026 07:30:59 +0000 (UTC) From: Albert Esteve Subject: [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Date: Wed, 13 May 2026 09:30:50 +0200 Message-Id: <20260513-kunit_add_support-v10-0-e379d206c8cd@redhat.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/23Oy2rDMBCF4VcJWldhJEW3rPoeJQTZM6pF8QXZM SnB7145EJISL8/AfPw3NlJONLLj7sYyzWlMfVeGgI8dq5vQfRNPWA5MgjSghOQ/ly5N54B4Hi/ D0OeJy6i0A1MJj8jK35Appusd/TqVHXPf8qnJFB6SBi2NUNJqvRfGCA1c8FCH3KYufGbCJkz7u m9XrUnj1Offe+FsVvPRYjdaZsOBI0oZqFKRNL5qa8xsn8RBwhZhC0Guqg1BtID0RrgnoeGwRbh CKNJe27rEKP1G+FfCbRG+EN5jtCE4B9H8I5Zl+QOenrtpuwEAAA== X-Change-ID: 20260312-kunit_add_support-2f35806b19dd To: Arnd Bergmann , Brendan Higgins , David Gow , Rae Moar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Andrew Morton , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, workflows@vger.kernel.org, linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org, peterz@infradead.org, Alessandro Carminati , Guenter Roeck , Kees Cook , Albert Esteve , Linux Kernel Functional Testing , =?utf-8?q?Ma=C3=ADra_Canal?= , Dan Carpenter , Kees Cook , Simona Vetter X-Developer-Signature: v=1; a=ed25519-sha256; t=1778657458; l=9933; i=aesteve@redhat.com; s=20260303; h=from:subject:message-id; bh=L5Yg5uVqrkobj7bmXCB6WQm8iYeZIrVy6jTHOY+8NLc=; b=o5eNnkqZLZkFTzUigTvAZt6LJyE7V61s14nT3qQcdkFHBwZW4RelppieMjiHpLDlrmV3syVSN obfW5Fc9iGnA38sJNEdMiOTdrD+2vCbEufQuVH1qDVDuc0wGaeHeCqb X-Developer-Key: i=aesteve@redhat.com; a=ed25519; pk=YSFz6sOHd2L45+Fr8DIvHTi6lSIjhLZ5T+rkxspJt1s= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful for a number of reasons: - They can result in overlooked real problems. - A warning that suddenly starts to show up in unit tests needs to be investigated and has to be marked to be ignored, for example by adjusting filter scripts. Such filters are ad hoc because there is no real standard format for warnings. On top of that, such filter scripts would require constant maintenance. One option to address the problem would be to add messages such as "expected warning backtraces start/end here" to the kernel log. However, that would again require filter scripts, might result in missing real problematic warning backtraces triggered while the test is running, and the irrelevant backtrace(s) would still clog the kernel log. Solve the problem by providing a means to suppress warning backtraces originating from the current kthread while executing test code. Since each KUnit test runs in its own kthread, this effectively scopes suppression to the test that enabled it, without requiring any architecture-specific code. Overview: Patch#1 Introduces the suppression infrastructure integrated into KUnit's hook mechanism. Patch#2 Adds selftests to validate the functionality. Patch#3 Demonstrates real-world usage in the DRM subsystem. Patch#4 Documents the new API and usage guidelines. Design Notes: Suppression is integrated into the existing KUnit hooks infrastructure, reusing the kunit_running static branch for zero overhead when no tests are running. The implementation lives entirely in the kunit module; only a static-inline wrapper and a function pointer slot are added to built-in code. Suppression is checked at three points in the warning path: - In `warn_slowpath_fmt()` (kernel/panic.c), for architectures without __WARN_FLAGS. The check runs before any output, fully suppressing both message and backtrace. - In `__warn_printk()` (kernel/panic.c), for architectures that define __WARN_FLAGS but not their own __WARN_printf (arm64, loongarch, parisc, powerpc, riscv, sh). The check suppresses the warning message text that is printed before the trap enters __report_bug(). - In `__report_bug()` (lib/bug.c), for architectures that define __WARN_FLAGS. The check runs before `__warn()` is called, suppressing the backtrace and stack dump. To avoid double-counting on architectures where both `__warn_printk()` and `__report_bug()` run for the same warning, the hook takes a bool parameter: true to increment the suppression counter, false to suppress without counting. The suppression state is dynamically allocated via kunit_kzalloc() and tied to the KUnit test lifecycle via `kunit_add_action()`, ensuring automatic cleanup at test exit. Writer-side access to the global suppression list is serialized with a spinlock; readers use RCU. Two API forms are provided: - kunit_warning_suppress(test) { ... }: scoped blocks with automatic cleanup. The suppression handle is not accessible outside the block, so warning counts (if needed) must be checked inside. Multiple suppression blocks are allowed. - kunit_start/end_suppress_warning(test): direct functions that return an explicit handle. Use when the handle needs to be retained, or passed across helpers. Multiple suppression blocks are allowed. This series is based on the RFC patch and subsequent discussion at https://patchwork.kernel.org/project/linux-kselftest/patch/02546e59-1afe-4b08-ba81-d94f3b691c9a@moroto.mountain/ and offers a more comprehensive solution of the problem discussed there. Changes since RFC: - Introduced CONFIG_KUNIT_SUPPRESS_BACKTRACE - Minor cleanups and bug fixes - Added support for all affected architectures - Added support for counting suppressed warnings - Added unit tests using those counters - Added patch to suppress warning backtraces in dev_addr_lists tests Changes since v1: - Rebased to v6.9-rc1 - Added Tested-by:, Acked-by:, and Reviewed-by: tags [I retained those tags since there have been no functional changes] - Introduced KUNIT_SUPPRESS_BACKTRACE configuration option, enabled by default. Changes since v2: - Rebased to v6.9-rc2 - Added comments to drm warning suppression explaining why it is needed. - Added patch to move conditional code in arch/sh/include/asm/bug.h to avoid kerneldoc warning - Added architecture maintainers to Cc: for architecture specific patches - No functional changes Changes since v3: - Rebased to v6.14-rc6 - Dropped net: "kunit: Suppress lock warning noise at end of dev_addr_lists tests" since 3db3b62955cd6d73afde05a17d7e8e106695c3b9 - Added __kunit_ and KUNIT_ prefixes. - Tested on interessed architectures. Changes since v4: - Rebased to v6.15-rc7 - Dropped all code in __report_bug() - Moved all checks in WARN*() macros. - Dropped all architecture specific code. - Made __kunit_is_suppressed_warning nice to noinstr functions. Changes since v5: - Rebased to v7.0-rc3 - Added RCU protection for the suppressed warnings list. - Added static key and branching optimization. - Removed custom `strcmp` implementation and reworked __kunit_is_suppressed_warning() entrypoint function. Changes since v6: - Moved suppression checks from WARN*() macros to warn_slowpath_fmt() and __report_bug(). - Replaced stack-allocated suppression struct with kunit_kzalloc() heap allocation tied to the KUnit test lifecycle. - Changed suppression strategy from function-name matching to task-scoped: all warnings on the current task are suppressed between START and END, rather than only warnings originating from a specific named function. - Simplified macro API: removed KUNIT_DECLARE_SUPPRESSED_WARNING(), the START macro now takes (test) and handles allocation internally. - Removed static key and branching optiomization, as by the time it was executed, callers are already in warn slowpaths. - Link to v6: https://lore.kernel.org/r/20260317-kunit_add_support-v6-0-dd22aeb3fe5d@redhat.com Changes since v7: - Integrated suppression into existing KUnit hooks infrastructure - Removed CONFIG_KUNIT_SUPPRESS_BACKTRACE - Added suppression check in __warn_printk() - Added spinlock for writer-side RCU protection - Replaced explicit rcu_read_lock/unlock with guard(rcu)() - Added scoped API (kunit_warning_suppress) using __cleanup attribute - Updated DRM patch to use scoped API - Expanded self-tests: incremental counting, cross-kthread isolation - Rewrote documentation covering all three API forms with examples - Link to v7: https://lore.kernel.org/r/20260420-kunit_add_support-v7-0-e8bc6e0f70de@redhat.com Changes since v8: - Rebased to v7.1-rc2 - Remove KUNIT_START/END_SUPPRESSED_WARNING() macros - Add KUNIT_EXPECT_SUPPRESSED_WARNING_COUNT checks to drm tests - Link to v8: https://lore.kernel.org/r/20260504-kunit_add_support-v8-0-3e5957cdd235@redhat.com Changes since v9: - Fix silent false-pass when kunit_start_suppress_warning() returns NULL - Fix RCU lockdep splat for kunit_is_suppressed_warning() calls - Move disable_trace_on_warning() in __report_bug() - Make suppress counter atomic - Mark helper warn functions in selftest as noinline - Add kunit_skip() for CONFIG_BUG=n in selftests - Fix potentially uninitialized data.was_active in kthread seltest - Add kthread_stop() in kthread selftest early exit - Initialize scaling_factor to INT_MIN in DRM scaling tests - Add include for bool in test-bug.h to fix CONFIG_KUNIT=n case - Link to v9: https://lore.kernel.org/r/20260508-kunit_add_support-v9-0-99df7aa880f6@redhat.com -- 2.34.1 --- To: Brendan Higgins To: David Gow To: Rae Moar To: Andrew Morton To: Paul Walmsley To: Palmer Dabbelt To: Albert Ou To: Alexandre Ghiti To: Maarten Lankhorst To: Maxime Ripard To: Thomas Zimmermann To: David Airlie To: Simona Vetter To: Jonathan Corbet To: Shuah Khan Cc: linux-kernel@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: kunit-dev@googlegroups.com Cc: linux-riscv@lists.infradead.org Cc: dri-devel@lists.freedesktop.org Cc: workflows@vger.kernel.org Cc: linux-doc@vger.kernel.org --- Alessandro Carminati (1): bug/kunit: Core support for suppressing warning backtraces Guenter Roeck (3): kunit: Add backtrace suppression self-tests drm: Suppress intentional warning backtraces in scaling unit tests kunit: Add documentation for warning backtrace suppression API Documentation/dev-tools/kunit/usage.rst | 46 +++++++- drivers/gpu/drm/tests/drm_rect_test.c | 32 +++++- include/kunit/test-bug.h | 26 +++++ include/kunit/test.h | 98 ++++++++++++++++ kernel/panic.c | 11 ++ lib/bug.c | 14 ++- lib/kunit/Makefile | 4 +- lib/kunit/backtrace-suppression-test.c | 196 ++++++++++++++++++++++++++++++++ lib/kunit/bug.c | 119 +++++++++++++++++++ lib/kunit/hooks-impl.h | 2 + 10 files changed, 538 insertions(+), 10 deletions(-) --- base-commit: 74fe02ce122a6103f207d29fafc8b3a53de6abaf change-id: 20260312-kunit_add_support-2f35806b19dd Best regards, -- Albert Esteve