From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77F531624C0; Thu, 14 May 2026 23:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778801070; cv=none; b=cpRr6SxIdDhgHeJf9bpXP1HP4ijifvdLO/8EPfYrRho6nDYsEIkJ4vP4dDguT2OPc9mGzdnx3n/EMBmm0VO0Hi/PikcpZL8Jm+YamNu7wH+PemaJl1Meewm3wxnzW9j3qGHG2mXFDNfui9HQEueASSaSHRF5L8nb21CNObt2lUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778801070; c=relaxed/simple; bh=abcUdZkExVsC3g0gsn6E8bZW1UNFsj1zLdTe3Vx+fWQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A+3xnEBPNrG19IdV+C62Ob08shD86Axc4U57qZZI6XhFbWXplqEBZJUgVFXXhg9tWkTdRJ5L2FQxareKFLFwteltV1av8DSIcXkNiyaImruq0sWAcGsl2Z2vMdA6Fvk9rT0+cMfVuet47N/Kgb/G+aMxq069J8T4Hkcdk+GOQac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mfTQnb53; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mfTQnb53" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBC2BC2BCB3; Thu, 14 May 2026 23:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778801070; bh=abcUdZkExVsC3g0gsn6E8bZW1UNFsj1zLdTe3Vx+fWQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mfTQnb53M/gyo+fqzJfJZzTPxPGmKkT3RJ4+AAzP+QvQ2ie+CIukFB7Fq7i7WZTvZ WVPgFSWJzDnRN7dEhuTu1aui7NZnx+ffCTrHYIlBx24UEoNvJxcfYgFWEPPij69/fC Ha19o3Cpd2GAbRN483e+tDZZzK/qKWd6xHLupty+MF45q5u4NoRHCZLx4DgFTOhHTO P/5ykig/fy3JB2/H/lnQUD9+F7PjRwDwyCreZ6nMdgwRNE2/mL3HqDFqOdz5Ir3Fgm 7XCYcWiSI5TZUMFI/OffqPM4jq/kRK2c/IiI5xiiqKv6qypIVgTFgwVw11pYe3YcKa OeDqr0uZm7Anw== Date: Thu, 14 May 2026 16:24:29 -0700 From: Jakub Kicinski To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, edumazet@google.com, dsahern@kernel.org, davem@davemloft.net Subject: Re: [PATCH 3/3 net-next v4] selftests: net: add test for IPv4 devconf netlink notifications Message-ID: <20260514162429.366b94c9@kernel.org> In-Reply-To: References: <20260510081528.5257-1-fmancera@suse.de> <20260510081528.5257-3-fmancera@suse.de> <20260513193544.47970cb8@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 14 May 2026 11:42:16 +0200 Fernando Fernandez Mancera wrote: > On 5/14/26 4:35 AM, Jakub Kicinski wrote: > > On Sun, 10 May 2026 10:15:28 +0200 Fernando Fernandez Mancera wrote: > >> Introduce a new test, `ipv4_devconf_notify`, to verify that the kernel > >> sends the appropriate netlink notifications when IPv4 devconf parameters > >> are modified. > >> > >> Since YNL currently has a bug where it declares an array of u32 values > >> instead of the nested attributes expected by the kernel for devconf set > >> operations, a temporary hack (`patched_add_attr`) is included to > >> pack the netlink attributes correctly. > > > > Right, YNL doesn't really support the level or weirdness that netconf > > requires. Why use YNL? Can't we test this with iproute2? > > No, AFAIU, iproute2 does not expose devconf settings. The main user of > IFLA_INET_CONF are netlink libraries and other userspace tools that > heavily rely on netlink operations like NetworkManager, nmstate, nispor, > rust-netlink.. Isn't this ip netconf ? > FWIW, I plan to fix the YNL side of things so we have this fixed > properly. If it adds any hacks or new concepts to YNL it's unlikely to be accepted :( > But I would prefer if this isn't blocked. Another patchset > introducing IFLA_INET6_CONF support is also coming.. being able to avoid > sysctl usage is quite useful for these userspace tools.