From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: Dev Jain <dev.jain@arm.com>,
david@kernel.org, ljs@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: close fd on write error
Date: Thu, 21 May 2026 17:49:51 -0700 [thread overview]
Message-ID: <20260521174951.d16f76cc39cca19bb5d6ee70@linux-foundation.org> (raw)
In-Reply-To: <20260520093824.eannlavh64fpxyrz@master>
On Wed, 20 May 2026 09:38:24 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:
>
> Subject: [PATCH] selftests/mm: close fd on write error
>
selftest/mm is a big place nowadays. I'll rewrite this to
"selftests/mm/split_huge_page_test.c: ...".
> >I asked AI and it points to another problem:
> >
> >for (i = 0; i < nr_thps; i++) {
> > if (is_backed_by_folio(page_area + i * pagesize, 0,
> > pagemap_fd, kpageflags_fd))
> > continue;
> > ksft_test_result_fail("THP %zu not split\n", i);
> >}
> >
> >ksft_test_result_pass("Split PTE-mapped huge pages successful\n");
> >
> >"If one THP is not split, it prints FAIL, but then falls through and also prints PASS.
> >
> >It should probably jump to out after the failure".
> >
https://sashiko.dev/#/patchset/20260520020336.28914-1-richard.weiyang@gmail.com
doesn't say this?
> Thanks for AI.
>
> It looks we should "goto out" after ksft_test_result_fail().
I'll assume that's a separate patch.
next prev parent reply other threads:[~2026-05-22 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 2:03 [PATCH] selftests/mm: close fd on write error Wei Yang
2026-05-20 3:51 ` Dev Jain
2026-05-20 9:38 ` Wei Yang
2026-05-22 0:49 ` Andrew Morton [this message]
2026-05-24 1:48 ` Wei Yang
2026-05-21 0:54 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521174951.d16f76cc39cca19bb5d6ee70@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox