From: Jinseok Kim <always.starving0@gmail.com>
To: rafael@kernel.org, viresh.kumar@linaro.org, shuah@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] selftests/cpufreq: Remove unnecessary sudo from quick_shuffle()
Date: Mon, 6 Jul 2026 23:38:54 +0900 [thread overview]
Message-ID: <20260706143857.3306-2-always.starving0@gmail.com> (raw)
In-Reply-To: <20260706143857.3306-1-always.starving0@gmail.com>
The cpufreq selftests are always executed through main.sh, which verifies
that the test is run as root before dispatching any test case.
Therefore, invoking sudo inside quick_shuffle() is redundant and may cause
failures in environments where sudo is unavailable.
Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
---
tools/testing/selftests/cpufreq/special-tests.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/cpufreq/special-tests.sh b/tools/testing/selftests/cpufreq/special-tests.sh
index 8d40505dc468..f45eb525f3b1 100755
--- a/tools/testing/selftests/cpufreq/special-tests.sh
+++ b/tools/testing/selftests/cpufreq/special-tests.sh
@@ -65,8 +65,8 @@ quick_shuffle()
# this is called concurrently from governor_race
for I in `seq 1000`
do
- echo ondemand | sudo tee $CPUFREQROOT/policy*/scaling_governor &
- echo userspace | sudo tee $CPUFREQROOT/policy*/scaling_governor &
+ echo ondemand | tee $CPUFREQROOT/policy*/scaling_governor &
+ echo userspace | tee $CPUFREQROOT/policy*/scaling_governor &
done
}
--
2.43.0
next prev parent reply other threads:[~2026-07-06 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 14:38 [PATCH 1/2] selftests/cpufreq: Remove unused local variables from switch_show_governor() Jinseok Kim
2026-07-06 14:38 ` Jinseok Kim [this message]
2026-07-07 5:12 ` [PATCH 2/2] selftests/cpufreq: Remove unnecessary sudo from quick_shuffle() Viresh Kumar
2026-07-07 5:10 ` [PATCH 1/2] selftests/cpufreq: Remove unused local variables from switch_show_governor() Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706143857.3306-2-always.starving0@gmail.com \
--to=always.starving0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox