Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Chuck Lever" <cel@kernel.org>
Cc: "Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Sabrina Dubroca" <sd@queasysnail.net>,
	"Shuah Khan" <shuah@kernel.org>,
	"Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	"Olga Kornievskaia" <okorniev@redhat.com>,
	"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
	netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev,
	linux-kselftest@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/6] net: Introduce read_sock_rectype proto_ops for control record delivery
Date: Tue, 28 Jul 2026 19:30:58 -0700	[thread overview]
Message-ID: <20260728193058.7f6b453b@kernel.org> (raw)
In-Reply-To: <480a8337-a91e-40e5-8dbd-d165599fba4b@app.fastmail.com>

On Tue, 28 Jul 2026 21:57:21 -0400 Chuck Lever wrote:
> > To me this is an ugly one-off workaround that doesn't fit into 
> > the proto_ops (only TLS will use it). And you seem to net out
> > to the same LOC on SUNRPC side with and without this?  
> 
> It’s not about LOC. It’s about not cluttering the normal I/O
> path with a lot of exception processing to handle TLS Alert
> records. The CMSG API is very difficult to use and leaks the
> alert messages into I/O buffers (which for in-kernel consumers
> are page cache pages). It’s piss-poor API design.

I'm not arguing that it's amazing. Doesn't mean we will YOLO
a special proto callback for every protocol stacking :/

> > There needs to be a very strong reason for us to add APIs for
> > in kernel consumers.  
> 
> This is not a helpful position. Your objection is the same
> every time, treating the in-kernel users as second-class
> citizens.

No, it's not a second class citizen. But kernel consumers have a
tendency to break all abstractions and insert hacks all over the place
just because they are not forced to go via uAPI boundary which forces
people to think about the API design.

You just need to try a little harder to produce a better solution.
Rework or augment existing callbacks to let your achieve the behavior
you want.

> You haven’t provided a single alternative to address
> our concerns, and you have not explained why an additional API
> is a problem.
> 
> Please put down your hostility and elaborate. You seem to be
> the only one who has a problem with any of this.

True. We should remove maintainers and just commit obvious LLM slop.

  reply	other threads:[~2026-07-29  2:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 14:27 [PATCH net-next v2 0/6] Deliver TLS control records to kernel read_sock consumers Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 1/6] net/tls: Bound consecutive no-data records in tls_sw_read_sock() Chuck Lever
2026-07-23  7:11   ` Hannes Reinecke
2026-07-23 13:24     ` Chuck Lever
2026-07-23 14:23       ` Sabrina Dubroca
2026-07-23 14:29         ` Chuck Lever
2026-07-23 22:05           ` Sabrina Dubroca
2026-07-29  1:47   ` Jakub Kicinski
2026-07-29  3:17     ` Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 2/6] net: Introduce read_sock_rectype proto_ops for control record delivery Chuck Lever
2026-07-23  7:14   ` Hannes Reinecke
2026-07-29  1:51   ` Jakub Kicinski
2026-07-29  1:57     ` Chuck Lever
2026-07-29  2:30       ` Jakub Kicinski [this message]
2026-07-29  2:51         ` Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 3/6] tls: Implement read_sock_rectype for kTLS software path Chuck Lever
2026-07-23  7:14   ` Hannes Reinecke
2026-07-20 14:27 ` [PATCH net-next v2 4/6] selftests/tls: Add tests for data/control record interleaving Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 5/6] SUNRPC: Use read_sock_rectype for svcsock TCP receives Chuck Lever
2026-07-20 14:28 ` [PATCH net-next v2 6/6] SUNRPC: Remove sock_recvmsg path from " Chuck Lever
2026-07-23  7:19 ` [PATCH net-next v2 0/6] Deliver TLS control records to kernel read_sock consumers Hannes Reinecke
2026-07-29  1:43 ` Jakub Kicinski
2026-07-29  1:46   ` Chuck Lever
2026-07-29  1:55     ` Jakub Kicinski
2026-07-29  2:16       ` Chuck Lever
2026-07-29  2:24         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728193058.7f6b453b@kernel.org \
    --to=kuba@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=cel@kernel.org \
    --cc=horms@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-tls-handshake@lists.linux.dev \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=okorniev@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=shuah@kernel.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox