Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Deep Shah <deepshah146@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH v2 net 2/2] selftests: ptp: add a regression test for the frequency adjustment overflow
Date: Sat,  1 Aug 2026 22:33:34 +0000	[thread overview]
Message-ID: <20260801223334.39150-1-deepshah146@gmail.com> (raw)
In-Reply-To: <20260727112823.106914-1-horms@kernel.org>

Thanks Simon. v3 drops the #if and casts to the type of tx.freq instead, so
the assignment still happens where tx.freq is 64-bit but long isn't.

I went with the cast rather than just dropping the #if, since dropping it on
its own would bring back the -Woverflow you flagged on v1.

I also ran the sashiko prompts over the series myself before sending. The
only other thing it turned up was the missing .gitignore entry for the test
binary, which v3 adds too.

https://lore.kernel.org/netdev/20260801222923.39017-1-deepshah146@gmail.com/

       reply	other threads:[~2026-08-01 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260727112823.106914-1-horms@kernel.org>
2026-08-01 22:33 ` Deep Shah [this message]
2026-07-21  1:42 [PATCH v2 net 0/2] ptp: fix scaled_ppm_to_ppb() overflow bypassing the max_adj check Deep Shah
2026-07-21  1:42 ` [PATCH v2 net 2/2] selftests: ptp: add a regression test for the frequency adjustment overflow Deep Shah
2026-07-27 11:28   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260801223334.39150-1-deepshah146@gmail.com \
    --to=deepshah146@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox