From: Jakub Kicinski <kuba@kernel.org>
To: chanyoung <ppoo1220@gmail.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
David Howells <dhowells@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] tls: don't over-fill the plaintext sk_msg ring in tls_sw_sendmsg_splice()
Date: Mon, 3 Aug 2026 15:13:29 -0700 [thread overview]
Message-ID: <20260803151329.40ec5aa8@kernel.org> (raw)
In-Reply-To: <20260727125804.2889161-1-ppoo1220@gmail.com>
On Mon, 27 Jul 2026 21:58:04 +0900 chanyoung wrote:
> 2026-07-27, 12:30:48 +0200, Sabrina Dubroca wrote:
> > This should never happen. We need to fix whatever path leads to that
> > invalid condition.
>
> Your diff is right. Tested on net (53658c6f3682), stock config: without it
> the test in 2/2 oopses in the AEAD walk, with it applied there is no oops
> and no regression in the tls selftests.
>
> Agreed, my patch was treating the symptom.
>
> Sorry about the verbosity of v1.
>
> Happy to send a v2 with your diff if you'd like me to carry it, or leave
> it to you. Should Fixes: stay at fe1e81d4f73b?
Please send a v2, I don't see anyone else sending a fix for this.
next prev parent reply other threads:[~2026-08-03 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 10:55 [PATCH net 0/2] tls: fix plaintext sk_msg ring over-fill in tls_sw_sendmsg_splice() chanyoung
2026-07-26 10:55 ` [PATCH net 1/2] tls: don't over-fill the plaintext sk_msg ring " chanyoung
2026-07-27 10:30 ` Sabrina Dubroca
2026-07-27 12:58 ` chanyoung
2026-08-03 22:13 ` Jakub Kicinski [this message]
2026-07-26 10:55 ` [PATCH net 2/2] selftests: tls: add a test for splicing onto a full plaintext record chanyoung
2026-07-27 11:55 ` Sabrina Dubroca
2026-07-27 12:59 ` chanyoung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803151329.40ec5aa8@kernel.org \
--to=kuba@kernel.org \
--cc=dhowells@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ppoo1220@gmail.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox