From: Hongfu Li <hongfu.li@linux.dev>
To: akpm@linux-foundation.org
Cc: hongfu.li@linux.dev, lihongfu@kylinos.cn,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
reddybalavignesh9979@gmail.com, richard.weiyang@gmail.com,
shuah@kernel.org
Subject: Re: [PATCH] selftests/prctl: Fix non-anonymous VMA mapping in set-anon-vma-name test
Date: Tue, 4 Aug 2026 19:12:18 +0800 [thread overview]
Message-ID: <20260804111218.82537-1-hongfu.li@linux.dev> (raw)
In-Reply-To: <20260803140924.31bf563743a73653f65e2258@linux-foundation.org>
> AI review found one glitch which I don't think we need to care about:
> https://sashiko.dev/#/patchset/20260803103046.14324-1-hongfu.li@linux.dev
>
> and one possible pre-existing issue which is kinda related and which
> you may choose to address. Please take a look and let us know?
Thanks for the review. I've carefully considered the AI review's findings.
The /dev/zero case raised by the AI reviewer may be addressed by commit
cc3b846182db ("mm/vma: make MAP_PRIVATE-mapped /dev/zero mappings truly
anonymous"), which makes these mappings truly anonymous (no vm_file, no
vm_ops). So the vma->vm_file checks in madvise.c should not wrongly
reject them.
That said, I agree that vma_is_anonymous(vma) better expresses the intent
than vma->vm_file in these sites. I'm happy to send a separate patch for
that if needed.
Best regards,
Hongfu
prev parent reply other threads:[~2026-08-04 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 10:30 [PATCH] selftests/prctl: Fix non-anonymous VMA mapping in set-anon-vma-name test Hongfu Li
2026-08-03 21:09 ` Andrew Morton
2026-08-04 11:12 ` Hongfu Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804111218.82537-1-hongfu.li@linux.dev \
--to=hongfu.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reddybalavignesh9979@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox