Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org, Alexei Starovoitov <ast@kernel.org>,
	Shuah Khan <shuah@kernel.org>
Cc: "Sasha Levin" <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	linux-kselftest@vger.kernel.org, stable@vger.kernel.org,
	"Mykyta Yatsenko" <yatsenko@meta.com>,
	"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	"Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>
Subject: Re: [PATCH 7.1.y] selftests/bpf: Add tests for sleepable tracepoint programs
Date: Thu,  6 Aug 2026 13:49:40 -0400	[thread overview]
Message-ID: <20260806131002.stable-0003@kernel.org> (raw)
In-Reply-To: <20260805-selftests-bpf-sleepable-v1-1-e29fa5af4119@marliere.net>

On Wed, Aug 05, 2026 at 02:54:34PM -0300, Ricardo B. Marlière (SUSE) wrote:
> Hi, backporting commit 23b933c6223f ("bpf: Verifier support for sleepable
> tracepoint programs") without backporting this commit breaks the selftest,
> as seen in openSUSE CI:

Agreed on the diagnosis: 23b933c6223f went into 7.1.y as a Stable-dep-of
and changed the verifier error string without updating the expectation,
so the verifier/sleepable.c hunk is both correct and needed there.

The rest of the commit is the problem:

>  .../bpf/prog_tests/sleepable_tracepoints.c         | 142 +++++++++++++++++++++
>  .../bpf/progs/test_sleepable_tracepoints.c         | 112 ++++++++++++++++
>  .../bpf/progs/test_sleepable_tracepoints_fail.c    |  18 +++
>  tools/testing/selftests/bpf/verifier/sleepable.c   |  17 ++-

The three new files use SEC("tp_btf.s/..."), SEC("raw_tp.s/...") and
SEC("tp.s/..."). 7.1.y does not carry 0cd420a6f40c7 ("libbpf: Add section
handlers for sleepable tracepoints"), so its libbpf has no SEC_DEF entry
for any ".s" tracepoint variant, and sec_def_matches() will not match a
".s" suffix against the plain "tp_btf+"/"raw_tp+"/"tp+" entries. Every
program in the two new progs/ files then fails to load and
test_sleepable_tracepoints__open_and_load() fails outright - so as posted
this trades a test_verifier failure for a permanently failing test_progs
test.

The runtime pieces are missing from 7.1.y as well - 439ebd5b5708 ("bpf:
Add sleepable support for raw tracepoint programs"), 12628ffaf98b ("bpf:
Add bpf_prog_run_array_sleepable()") and 57918341dd19 ("bpf: Add
sleepable support for classic tracepoint programs") - so even with the
libbpf section handlers the functional subtests would still fail.

Could you send a v2 carrying only the
tools/testing/selftests/bpf/verifier/sleepable.c hunk, with a note in the
commit message explaining why the new prog_tests/ and progs/ files are
omitted?

-- 
Thanks,
Sasha

  reply	other threads:[~2026-08-06 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 17:54 [PATCH 7.1.y] selftests/bpf: Add tests for sleepable tracepoint programs Ricardo B. Marlière (SUSE)
2026-08-06 17:49 ` Sasha Levin [this message]
2026-08-06 21:04   ` Ricardo B. Marlière (SUSE)
  -- strict thread matches above, loose matches on Subject: below --
2026-08-03 18:57 Ricardo B. Marlière (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806131002.stable-0003@kernel.org \
    --to=sashal@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=ricardo@marliere.net \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yatsenko@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox