From: Simon Horman <horms@kernel.org>
To: Brian Grech <bgrech@redhat.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org, edumazet@google.com, pabeni@redhat.com,
kuba@kernel.org
Subject: Re: [PATCH] selftests/net: fin_ack_lat: fix latency threshold typo
Date: Thu, 6 Aug 2026 14:30:51 +0100 [thread overview]
Message-ID: <20260806133051.GD51943@horms.kernel.org> (raw)
In-Reply-To: <20260804220108.1630366-1-bgrech@redhat.com>
On Tue, Aug 04, 2026 at 05:01:08PM -0500, Brian Grech wrote:
> The FIN-ACK latency threshold was written as 100000 (100ms) instead
> of the intended 1000000 (1 second). Connections completing between
> 100ms and 1 second were incorrectly flagged as high-latency outliers
> and printed as failures on loaded systems.
>
> Add the missing zero to restore the intended 1 second threshold.
>
> Signed-off-by: Brian Grech <bgrech@redhat.com>
> ---
> v2: Added missing maintainer CCs
Hi Brian,
It might be nice to include some information on why 1s is intended.
But I don't think that is strictly necessary.
Also, if this is a fix to be backported (I am unsure) then
it should have a Fixes tag and be targeted at the net branch.
The above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-08-06 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 14:59 [PATCH] selftests/net: fin_ack_lat: fix latency threshold typo Brian Grech
2026-08-04 22:01 ` Brian Grech
2026-08-06 13:30 ` Simon Horman [this message]
2026-08-06 15:01 ` Brian Grech
2026-08-06 15:16 ` [PATCH net v3] " Brian Grech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806133051.GD51943@horms.kernel.org \
--to=horms@kernel.org \
--cc=bgrech@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox