From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jv@jvosburgh.net, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: bonding: disable DAD for IPv6 addresses
Date: Mon, 10 Aug 2026 11:14:50 -0700 [thread overview]
Message-ID: <20260810111450.176b34d6@kernel.org> (raw)
In-Reply-To: <ankxIiVLu3qY5jw5@fedora>
On Mon, 10 Aug 2026 10:02:10 +0800 Hangbin Liu wrote:
> On Sat, Aug 08, 2026 at 09:23:45AM -0700, Jakub Kicinski wrote:
> > bond_reset() waits up to 2 seconds for IPv6 connectivity.
> > With default settings DAD itself may take almost 2 seconds,
> > causing flakes on debug builds. It used to flake once or
> > twice a week, recently it started failing once a day.
> > Probably some downstream changes to scheduler, or our machines
> > go busier.
> >
> > A lot of selftests already use nodad, let's use nodad in bonding, too.
> > I don't see an obvious reason why DAD would be important to the test.
>
> In this case, how about add nodad to all IPv6 address setting on bonding
> tests, e.g. bond_options.sh, bond_macvlan_ipvlan.sh.
>
> After that, we may event remove the sleep time in bond_macvlan_ipvlan.sh.
> In my local testing all the macvlan/ipvlan test passed with nodad set.
Can you do that as a follow up, please?
bond_options.sh is the worst offender for flakiness right now.
I would like to squash these flakes ASAP.
next prev parent reply other threads:[~2026-08-10 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 16:23 [PATCH net-next] selftests: bonding: disable DAD for IPv6 addresses Jakub Kicinski
2026-08-10 2:02 ` Hangbin Liu
2026-08-10 18:14 ` Jakub Kicinski [this message]
2026-08-11 0:43 ` Hangbin Liu
2026-08-11 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810111450.176b34d6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox