From: Jakub Kicinski <kuba@kernel.org>
To: Lei Zhu <zhulei_szu@163.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
kuniyu@google.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, shuah@kernel.org
Subject: Re: [PATCH net] selftests: af_unix: verify SCM_PIDFD pidfd in cmsg_check_dead()
Date: Mon, 17 Aug 2026 08:41:23 -0700 [thread overview]
Message-ID: <20260817084123.75fbbf97@kernel.org> (raw)
In-Reply-To: <20260817061121.239648-1-zhulei_szu@163.com>
On Mon, 17 Aug 2026 14:11:21 +0800 Lei Zhu wrote:
> The cmsg_check_dead() function receives an expected_pid parameter but never
> actually verifies that the pidfd received via SCM_PIDFD corresponds to that
> PID. It only checks the child's exit code via PIDFD_GET_INFO.
this breaks the test:
(scm_pidfd.c:282: errno: None) wrong SCM_PIDFD -1 != <PID>
If you want to improve the test please repost this patch in 2 weeks
after the merge window. This patch should not carry the Fixes tag.
prev parent reply other threads:[~2026-08-17 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 6:11 [PATCH net] selftests: af_unix: verify SCM_PIDFD pidfd in cmsg_check_dead() Lei Zhu
2026-08-17 15:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817084123.75fbbf97@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=zhulei_szu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox