Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Matthieu Baerts <matttbe@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com, linux-kselftest@vger.kernel.org,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: Use cross-compilation environment for the io_uring check
Date: Tue, 1 Sep 2026 15:46:20 -0700	[thread overview]
Message-ID: <20260901154620.492ab980@kernel.org> (raw)
In-Reply-To: <20631f9a-1a2f-4ef5-a4c5-e1948e55dd78@bootlin.com>

On Tue, 1 Sep 2026 22:45:47 +0200 Maxime Chevallier wrote:
> Hi Matthieu,
> 
> On 9/1/26 19:24, Matthieu Baerts wrote:
> > Hi Maxime,  
> >> +# Set CC for the io_uring check
> >> +CC := $(CROSS_COMPILE)gcc  
> > 
> > Could we have something similar to
> > tools/testing/selftests/riscv/cfi/Makefile:
> > 
> >   # Set CC for the io_uring check done before including lib.mk
> >   ifeq ($(LLVM)$(CC),cc)
> >   CC := $(CROSS_COMPILE)gcc
> >   endif
> > 
> > WDYT?  
> 
> Ah this is better indeed IMO, I'll use that in V2 then, thanks for
> the tips.
> 
> Initially I considered doing a larger rework of extracting the logic
> in lib.mk that sets CC to the right value base on CROSS_COMPILE, LLVM
> and ARCH into a dedicated .mk file that we would include at the top,
> but at that time it seemed to be too big of a rework for just the
> io_uring check.
> 
> It lead to some headache about double-inclusions and relative paths lookups
> that far exceeded my Makefile skills :(
> 
> Thanks for the review,

I assume you don't actually have luring for your cross- env? Could we
keep it simple and just declare luring as unavailable when cross
compiling? Because the probing compilation rule is probably missing 
more flags to make cross compilation work.

Ignore if selftests using luring do actually work for you after this
patch..

      reply	other threads:[~2026-09-01 22:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 16:41 [PATCH net-next 0/2] selftests: drv-net: Allow cross-compiling the hardware tests Maxime Chevallier (Netdev Foundation)
2026-09-01 16:41 ` [PATCH net-next 1/2] selftests: drv-net: ynl: Allow cross-compiling ynl and associated tools Maxime Chevallier (Netdev Foundation)
2026-09-01 22:42   ` Jakub Kicinski
2026-09-01 16:41 ` [PATCH net-next 2/2] selftests: drv-net: Use cross-compilation environment for the io_uring check Maxime Chevallier (Netdev Foundation)
2026-09-01 17:24   ` Matthieu Baerts
2026-09-01 20:45     ` Maxime Chevallier
2026-09-01 22:46       ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901154620.492ab980@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox