From: Paul Dolan <paul.dolan.dev@gmail.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] selftests/proc: avoid exit() from SIGALRM handler
Date: Fri, 4 Sep 2026 13:37:52 +0100 [thread overview]
Message-ID: <20260904123752.157562-1-paul.dolan.dev@gmail.com> (raw)
proc-tid0 uses SIGALRM to stop the test after one second, but the
signal handler calls exit(), which is not async-signal-safe.
Set a sig_atomic_t flag from the handler instead and let the main loop
terminate normally. This also preserves the existing atexit cleanup
that kills the worker child.
Fixes: 0658a0961b0a ("procfs: do not list TID 0 in /proc/<pid>/task")
Signed-off-by: Paul Dolan <paul.dolan.dev@gmail.com>
---
tools/testing/selftests/proc/proc-tid0.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/proc/proc-tid0.c b/tools/testing/selftests/proc/proc-tid0.c
index 58c1d7c90a8e..79d3704b2b33 100644
--- a/tools/testing/selftests/proc/proc-tid0.c
+++ b/tools/testing/selftests/proc/proc-tid0.c
@@ -25,6 +25,8 @@
static pid_t pid = -1;
+static volatile sig_atomic_t alarmed;
+
static void atexit_hook(void)
{
if (pid > 0) {
@@ -39,7 +41,7 @@ static void *f(void *_)
static void sigalrm(int _)
{
- exit(0);
+ alarmed = 1;
}
int main(void)
@@ -62,7 +64,7 @@ int main(void)
signal(SIGALRM, sigalrm);
alarm(1);
- while (1) {
+ while (!alarmed) {
DIR *d = opendir(buf);
struct dirent *de;
while ((de = readdir(d))) {
--
2.55.0
reply other threads:[~2026-09-04 12:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904123752.157562-1-paul.dolan.dev@gmail.com \
--to=paul.dolan.dev@gmail.com \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox