From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f8.google.com (mail-wr2-f8.google.com [74.125.225.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039CC35677C for ; Sun, 4 Oct 2026 16:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791130338; cv=none; b=P8wxu5R26/cXVOduYEKkrRDtAPjuqyBNNuUoDKV5xknSoIEl2BSCQhOtmNvNj89EJD67H0jfWkusc1C+BjWwfMYp/F03TCt7t+NhExN6MKNh5yUlDteGpWmCF0pcGJHRNGJsfWDzXHlBFEqQFUxiJhA8mKE3eR+AiPwg5wjyx/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791130338; c=relaxed/simple; bh=/idkTiictibcBwPx3KaPsQdtHC3he+EupjWKYNAP2kU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a/7i7BNgHWGrZCfVavsI4a+DRRRo33/M/jn0F69/ghMCFR9bcwcbga4O3fptv/ODUGgYtG5JfvxMhwMLbAXUjK9vQf/K0lLtrqI+W1SjssgWlhnDiTBPr2U6b2Y6O2sHwycfK6zoNgDkdhsqIP8FVuH5eNrp6u/GIlgbQBPJrXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=blockcast.net; spf=pass smtp.mailfrom=blockcast.net; dkim=pass (2048-bit key) header.d=blockcast.net header.i=@blockcast.net header.b=LvYwD5Gy; arc=none smtp.client-ip=74.125.225.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=blockcast.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=blockcast.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blockcast.net header.i=@blockcast.net header.b="LvYwD5Gy" Received: by mail-wr2-f8.google.com with SMTP id ffacd0b85a97d-48b0241a47eso396180f8f.1 for ; Sun, 04 Oct 2026 09:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blockcast.net; s=google; t=1791130334; x=1791735134; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FPYochGZLRchHnAPZrvdvx5IZfJjHufMRI6BSKQPizk=; b=LvYwD5GyiDwXhrg/S3JMlbplWAU5Gcxl9zVnG1Q9it0n5G223lMoTRKLnxwTCSII6i K6JOHWf6U61ppLp3jIfvF243UtfPQ+lZW9g96sbmxG3bPMQwBs2LiwWp0ERocW9Fbkiu voMfnuuPH3woYNouPAHZeoIGSdhDt3K372E/rPhoG2EVsqWMLOTgw7NTvpsX4uEJx4wY K6TYwAJrPc6JxVLPC4WbKCffPhCWMm85zq7Njg5QU+KMR5A7rddbxf955UmAcpZU45if wpm0bU+hWdXebgQUI0ClWc94jgXoCpFv0lGgDF35leDqggX7gL4U25OUC9JOsku8z+fm vV/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791130334; x=1791735134; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FPYochGZLRchHnAPZrvdvx5IZfJjHufMRI6BSKQPizk=; b=fY01QCW3htr+PvIbsh2bEAm/jnWzgXHrj8z01SSY9PohMyV3Z6AT0glU1mxqcCTzYn VyTrBsv+ekw4ewwXy43dZ/uDZVMmYgEL7mh+JzUATTzax2/VdkTMArLRC3wfn0cRlKD8 BzXguTagTJmHCVGEUoKtTuwTx5pCJKqKwvuS2NlGKP3qQABXD042ebY+akJn8wBLxVc4 N5m29Kb98hRqLRplVE036VsqjN5Bafr3WM7oXqAn/l5+BojwjRaU9/22Nn/Erau9HTvV H+TmLOXeltZDlxgFjRPA+1SJzH913lc8JdKNt0fnBo0sFbf3GUeqKuOOD2lvoX1tDMlV HzpA== X-Forwarded-Encrypted: i=1; AKwUvBy+vgXDGpBr+wCvIBOcUkvLJQBGfLuFH3iXKwF/rcEjF7rQVzk77PpnmJBYaAlPrNSHJ/CgcWJVUkI3Hj57Jn4=@vger.kernel.org X-Gm-Message-State: AFuF++lTklRwYqWS4PJdp3Lb5HYJpZdaPjrSVJBQKwEDPGipngmsZA6L 96c4McJyK7OBUQXWzjEqYaZ9WKQqJjQH+EpwtbKZTN5ScJX55htUqr6MZ3WoNfR/yR4= X-Gm-Gg: AYBFou0CEJ9FJN81EoFQ6O3NetTSm3OybvWuYStwGVhnph4WopoIvCaHPh1nTkYZXdd I43sCkn0LQSqfw8lFuYXssfFA6MPJlpHa5rxflOHyfBcaSt9l40seLLOBpTtW3DSnTBqPbh9Ujl cPFF+aSjjRUCi2fiyw740N0ldT10yr4RcY/BcyS1zRqneqnwlFvZu+/gKrGkG6vlzh2BbV6EEbq X62oUf3bZPL4q+CL8hiRDkM2BOAaWtPXwHQUUI5FW3KQ+E3lCVpM+cqGrjgFYb0qs6D9/25Chm3 kDUl4B4Cn8zBeNW7GU/A8XDA9oMvSYtr50BxV0C88xCm2mHzwezlKsbhRxMNn40OvNLQwZX9ESr /hZFgXgASdi97AVj5sJbCr/ihD+/P6LmIvqzUxaVIx6AtDggWxOWTobuS8Lefmzzfn1S1v3/ppI +TlDaa/13NKZD5rNmZLizb8UKxLTxVNAl/K9RBn/ZTezfIFHp/bU8a9yHed6UQWKrRoKWtooWTB fzkCkz20HnVBZBPeEgdM7yuQShpBeYyu+nJOjfVuR6LUbI0kAJuuSerYm6dEc2+Spn1pzzQF7uk 7bQy/EEmPXY= X-Received: by 2002:a05:600c:5392:b0:4a1:6991:36d7 with SMTP id 5b1f17b1804b1-4a1699137bfmr78497205e9.10.1791130333960; Sun, 04 Oct 2026 09:12:13 -0700 (PDT) Received: from localhost.localdomain ([197.51.72.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a02854073csm244512275e9.3.2026.10.04.09.12.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 04 Oct 2026 09:12:13 -0700 (PDT) From: Omar Ramadan To: Taehee Yoo , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: Simon Horman , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 0/2] amt: mark relay data as a UDP tunnel packet, with a selftest Date: Sun, 4 Oct 2026 19:11:58 +0300 Message-ID: <20261004161200.27196-1-omar@blockcast.net> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit amt_send_multicast_data() never calls udp_tunnel_handle_offloads(), unlike other UDP tunnels. With tx checksum offload on the amt device (off by default), a UDP_SEGMENT burst through the relay is dropped before patch 1 and delivered after it. Patch 2 adds the selftest. This follows Eric Dumazet's suggestion on my withdrawn [PATCH net] "amt: do not offer software GSO on the amt device": https://lore.kernel.org/all/20260928181554.85766-1-omar@blockcast.net/ Not touched: amt advertises NETIF_F_GSO_FRAGLIST and skb_copy_expand() refuses such skbs with a WARN_ON_ONCE(). I have not reproduced it, and it would be a separate fix. v3: - patch 2: fail a case when one of its captures dies (Sashiko review) - patch 2: also check amtg rx_dropped, as the changelog says, and mention the plain-datagram cases there (Sashiko review) - patch 2: wait for a fresh READY, and fail a case when a helper does not start (Sashiko review) - patch 2: fail, not skip, when no relayed probe gets through (Sashiko review) - patch 2: fail, not skip, a tx-on UDP_SEGMENT case in which no GSO skb reaches amt_dev_xmit(), as the changelog says - patch 2: make amt_gso reject sizes that would overflow its buffers (Sashiko review) - patch 1 is unchanged v2: https://lore.kernel.org/all/20261002212458.34247-1-omar@blockcast.net/ - shorten the changelogs, add Suggested-by, and move the testing notes below the "---" (Eric); patch 1's code is unchanged, one comment is corrected - patch 2: fix the shellcheck and 80-column checkpatch findings reported by the netdev CI, skip when AF_PACKET is not available (v1 reported no result and exit 0), add CONFIG_PACKET to the config, drop dead options and code v1: https://lore.kernel.org/all/20261001171016.88208-1-omar@blockcast.net/ Omar Ramadan (2): amt: mark relay data as a UDP tunnel packet before sending it selftests: net: add an amt test for UDP_SEGMENT through the relay drivers/net/amt.c | 10 + tools/testing/selftests/net/.gitignore | 1 + tools/testing/selftests/net/Makefile | 2 + tools/testing/selftests/net/amt_gso.c | 462 +++++++++++++++++++++++++ tools/testing/selftests/net/amt_gso.sh | 282 +++++++++++++++ tools/testing/selftests/net/config | 1 + 6 files changed, 758 insertions(+) create mode 100644 tools/testing/selftests/net/amt_gso.c create mode 100755 tools/testing/selftests/net/amt_gso.sh -- 2.50.1 (Apple Git-155)