From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B1C393DDC for ; Thu, 8 Oct 2026 14:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791469626; cv=none; b=Sw7Z8I4QBpji57NsVtUbs3GnystLfzrALrUzDas6SFTv5ooKjsD2UnlU9jMqDCGAOk7zyHtDvGuhk9yVbtT7Z2DeOEL+okQKv6g4uwCNd1x8tlpi3eALSg+9NCY+4lIJi1UPYnwvbjVrUd5thSBd20/ezJFBGydlgICC3HcRzTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791469626; c=relaxed/simple; bh=KsMUuPLgwYCOV9UxYIW28j71QtlkZ2rhkGNJMAEP42s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uZvqSHp74XqHc/hw8Nk15nUtif4ywJPwd/odwGPc4CJeb8LNBDL/w1JVncaT2VaB4apOILDfDYNaE98VMKu9UTSrBkbHcllU7NhpP1SKna0/te2TuKZrzzIt1mDnM+iGTqX3OxO93hn856sUERJ7u/P43j3I/TWWJd2+IHbjUjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jrf42L33; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jrf42L33" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4a022fee0caso30279575e9.1 for ; Thu, 08 Oct 2026 07:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791469623; x=1792074423; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7LUqBhSOfJVHWYAUJBV+3KDwxwiS0DArsjvYAlNe814=; b=jrf42L33W6TSc+3pBsiR1KgnLdn1Q0Ty+QvUZjRcHLU7mvr/M8E8B1ZVt5/psUzFi8 vGB4eGAhbsBAx4gI2ldDJi7DEFiDUQAo2vfBSTXJX8myvXbjPJe084onLzKR3Qkth/sx tcfpREawMEtyh/DsGFMP+mWvvyDzZ+JFHIKMtxLIJknztqAwUCPvF87LiZMwWjjebHbp iCDnGs7Xs0726C+zGHmT7oHPypA2sSykomX6XQMj+kzy/z2aT7qrV2C4ASxD9h2TuzEQ fukR4fc5fcZiYvygy/3wYI++zH+HcsFbJEgAH5MiJN4examLzssD90m5DlUcPSc4zekj 6BGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791469623; x=1792074423; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7LUqBhSOfJVHWYAUJBV+3KDwxwiS0DArsjvYAlNe814=; b=tIC21z01K6Q3qonj4aVHV3PAX2wHEsPvwt0DyJlQHD6NNAQfn3mZRHwX6OYuUupvJ/ oAwdpASayHhEtA5Oz60+ueOolYctt4i+qDmE0GVHvLUXAQ+KmWHsvrKU5M1J7Vpb+p+e Guzccz+rh0obxOG4zPlzL/+cOQAkfBd1RQlzxR0ZeD72n/Eyqrp+R1ZaEaeF/jTF8wEI ONcoTxrhktRqgzJc8SlVvwU794jzQiSaKn45jp0fgZYXbQQ2C8FWvgfU9Sy5Mlpf69jz qP1OgXsb2G+LsCUCB6mU4pdwm0hp/bb22k+xEDVhcrckncyVAUD7rfLedkVRDn8MC8rU INhQ== X-Forwarded-Encrypted: i=1; AKwUvBwCWD57lP3M26Noa/vVeBN848ONH4g3eHZtNGvof0W+bKdxiGDf4/5+cJ+SFzDafj1PtE7cbqqNLfAEB9hZeNg=@vger.kernel.org X-Gm-Message-State: AFuF++mmz/OnBRtzk94Xu3X0YSqVmrEH+G5lStStDYtw2hp+jeatZHhE d8+moGYRVGFerB5D9KLw5HA/1KC5a01bsgOJj5jVwVcWLEr69EZXq1/i X-Gm-Gg: AYBFou1JpzP3UPseqpxUa8tFvJcpk4aKq8nGvaPTwf0TO+GEvPhlkSFMi67Uaneyn02 T2jP6qAhZtAoMYc8aI8E/7ouh4p+KR4K+dQSCEfjCNMe8I1OILdGixyXEaVLGgNTlaWxtoulyCX 47drsjw+kFfcBhs8SbryQ56HY2jsaa5v6ilNJctNIKGbyhOn0PAxrO+W9bHlgPEFwGlXNvCsaDC wTYyEjEQJ1LoBM0721RpTXux1fB7GJPAZsut4j3w0b9ndcVPvZYCvYfl5vdvZS9Y0zpg2IoZiTu Sa2VOj9+1jhb+pQX6RYF95DOf4tdUM0YbnZqWagaVdmBEwJHeEPBt5Jv0emQiivjztKkMdPuC59 qYhkPlxrQR8Qr8d/vGGMc7U/ZGAkU6il4LzKdURxxTQjtn8cFypX1cF6guL6XIl5EirGKtQPFrH zfzmilgh/Q8d5Pkdt+SMi5cyAa/kkqOeBdoIa9pFPdoT26tfzNCtsa7+NYR7uS1A77ljJ85iMLU h7BIOqmA6xlsx6dv9IJGfg7pIIxpAepFg== X-Received: by 2002:a05:600c:548b:b0:4a1:71ab:63ba with SMTP id 5b1f17b1804b1-4a18045f729mr104513565e9.29.1791469623095; Thu, 08 Oct 2026 07:27:03 -0700 (PDT) Received: from localhost (ip87-106-108-193.pbiaas.com. [87.106.108.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18360c5ebsm57526765e9.3.2026.10.08.07.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 07:27:02 -0700 (PDT) From: =?UTF-8?q?G=C3=BCnther=20Noack?= To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= Cc: Wang Yan , linux-kselftest@vger.kernel.org, =?UTF-8?q?G=C3=BCnther=20Noack?= , =?UTF-8?q?G=C3=BCnther=20Noack?= , Shuah Khan , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/27] selftests/landlock: Handle a missing control message in recv_fd() Date: Thu, 8 Oct 2026 16:25:37 +0200 Message-ID: <20261008142604.39107-10-gnoack3000@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261008142604.39107-2-gnoack3000@gmail.com> References: <20261008142604.39107-2-gnoack3000@gmail.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CMSG_FIRSTHDR() returns NULL when recvmsg(2) did not receive any ancillary data, e.g. when the peer closed the socket without sending an FD. recv_fd() dereferences the result unconditionally and crashes instead of returning an error. Return -EIO in that case. Assisted-by: LLM Signed-off-by: Günther Noack --- tools/testing/selftests/landlock/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/landlock/common.h b/tools/testing/selftests/landlock/common.h index c5124de68a51..e195c0f48eb3 100644 --- a/tools/testing/selftests/landlock/common.h +++ b/tools/testing/selftests/landlock/common.h @@ -158,7 +158,7 @@ static int __maybe_unused recv_fd(int usock) return -errno; cmsg = CMSG_FIRSTHDR(&msg); - if (cmsg->cmsg_len != CMSG_LEN(sizeof(fd_rx))) + if (!cmsg || cmsg->cmsg_len != CMSG_LEN(sizeof(fd_rx))) return -EIO; memcpy(&fd_rx, CMSG_DATA(cmsg), sizeof(fd_rx)); -- 2.56.0