From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3D71ACEDE for ; Fri, 16 Oct 2026 00:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109693; cv=none; b=IAGESzARGCbO+ObOVDsDVwzcH+aOpgJmYZtIJZrv5M4ZK7Sx5Y02pqS3B4xUYLaEtmyVPH327lkSXVi2CYHU35p4aBFPfKgS+RsvsJRkbOfD6f6UlvFOhSTJUw9yAm3aj56VN4MqLBvkaYuqnMHE0UvKl5AToG2dCHLO2FnNKtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109693; c=relaxed/simple; bh=N3hAyy7nTu0uD6uxxEosrsvSAc05WwQLSTSIID6INNQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oQL4ihDAGmXWvS783iA18OArqFb6kN/OAbu65qwzlQJiTYgUVpb7l8ls0Il5N197RVMZ7Xuhr2xKyfHqH6bIqwbBfSiQyvNjfGkSVS6A4CcTgBsHE7Pj9YFR+XPoym8V80TD3jOjo6N/9xQ0hrZIBGS8zCpo/fz75ioJjAa/AAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=T/StiSJg; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="T/StiSJg" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5351d76e1baso5829961cf.1 for ; Thu, 15 Oct 2026 17:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1792109691; x=1792714491; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=V2saNd2pf5xXpmgizEGMG+P83blHZRupazL/vtIJhv4=; b=T/StiSJg9NKkj9ibcSWBMEe5hjKjl5QSwtnEiP3tJzvpn/R0nSFhQSE2BteEpHDzDF 4uRGBFJHEJaC8NsxylpA+ABes7IxI2+87ROJ6dQn0dhETh3oLKejUQcI3XVrCeooZ0jN LBuzzRkKgdH7XqHEVZM1mVh+4VYM5srvaGbH7cRqoiS+NpWHcQ3PPJ8hSNCRl3zf0jSx OC8glC/BwOAeoVt/aqPc6qBd/KOujSyKOKYhxMVH9idVTMQYEAS0+Dk3trwFqSQzgoDP Ukq63JkewdwSwFPWIY5gvBVoi5Iy7viGPaetFhiagl3amNV78U7Bh5Yi+uua5qHdSPpB aUIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792109691; x=1792714491; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V2saNd2pf5xXpmgizEGMG+P83blHZRupazL/vtIJhv4=; b=Bt4coLe94v0rZz6yAI+ilxZLIDQcoxFlg3h5P7CnLwGHF7GSxpRWap2K7vRSr6kxkp HY8ue7fzAm2K92gCk/2y1I3uSLENbaqJzwlFPkvVLOpOsNdG7V0ettRo8hiJ1z77rPSB 8W3guBep3nPq1wdzl/HXOrO5hiZFVAQhJxlRfQDKt+RZyRvK1KWEWGcw27Lzj8rn7ehv yO2hoyvHDTg/hidUJNe7gegu0EfhgC5mC5eOfakRNMYm4vBXTufUImzyIC/IHufCSvVc 2rjerhqTrP7pZTaE+++/8hUuaXZeKsepguPl5wb1HM/TAwAAg91UB9rsUhteHtYFKKTD qRZA== X-Forwarded-Encrypted: i=1; AKwUvBxUB7oLNkeXe3HtpRyt9CC19EFND+NCZfuf/N3s63hIoL6RnEUi5ekkV/TVs3PzTCPGU+87pkDsiKAbI0SBtOE=@vger.kernel.org X-Gm-Message-State: AFq9FYJSOs5Gg0/NNjtBl/PqKiXKPQFEhTVlU7JgLF60PfImcEdUXQr2 GUs/0v7EPuhwFkG1QiaXw7XuqMj1dJ3Q3PBi1gGnqzkrDCTRGw3wnNUsyyQmOsr5PS4= X-Gm-Gg: AYBFou10snARpm9++1ZXfP7CuTFX9wSow0E6a1HxY+N93NZq5BdWEq0gcD+/hHd+yJZ C/O71TnXJrAvoq/YJISOzyqoSdbvWuwbg1qCc/GpUfZ7pjxZgFQXDQahvBZz2lb/90y+GKyUgAx Hcb1LVDFIeYo7ttOKhe0VStdhuukW2h2ruZY8a7Z5o2ESoKea2/KtkGJ0AuwW0g0rxUqsRRh1fB 2Aqnk7ICeEvvMNEDdTeYV+Q+bbp5itH38mQOCejo9CneRxpPZ9ouMl6p/gdFbwwdqdr8P72cjix MdBWZxNCrxCtKXjF9acI3vgap8usvZAyHRWXwEGGLYZ/Mk3pEZyEM+fp95DH4FTmdlWeB3yzGH9 G1NTDTQMNEMjmxLTpj7YUM/uZKx0UlEtCYAcsUQND5viqTK1ljhWvs4hi3cy/s7KvLeOceW+4/2 pDIYT5ALj/BObdRFJN1PCFa11A4I2CJEDFnto8MiHlRApw4bgsfe+r8JEu1JnSeZBcCg8uVT9qn N9MhQj4k+/ji+5M8UU6hjyioxo8Q1cz3xy/xsy9QwmEmSvF4JLTkw5c X-Received: by 2002:a05:622a:990:b0:535:ba01:d95 with SMTP id d75a77b69052e-536272c2d55mr30900421cf.19.1792109690637; Thu, 15 Oct 2026 17:14:50 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5362aa57106sm7257071cf.28.2026.10.15.17.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 17:14:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xHVay-00000000IxD-2c33; Thu, 15 Oct 2026 21:14:48 -0300 Date: Thu, 15 Oct 2026 21:14:48 -0300 From: Jason Gunthorpe To: Fred Griffoul Cc: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Oliver Upton , Catalin Marinas , Andrew Morton , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Jonathan Corbet , Shuah Khan , Shuah Khan , David Woodhouse , Ackerley Tng , "Aneesh Kumar K . V" , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Steffen Eiden , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2 07/11] iommufd: Use large IOMMU pages for provider mappings Message-ID: <20261016001448.GC14213@ziepe.ca> References: <20261014093733.90312-1-griffoul@gmail.com> <20261014093733.90312-8-griffoul@gmail.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014093733.90312-8-griffoul@gmail.com> On Wed, Oct 14, 2026 at 09:37:29AM +0000, Fred Griffoul wrote: > From: Fred Griffoul > > Provider pages are mapped with one PAGE_SIZE entry each. A device that > uses a large provider block then misses in the IOTLB on every page, and > the IOMMU needs more page table memory than the block requires. A > revoke also flushes the IOTLB once per run of pages it unmaps. > > Map each block that the provider reports with large IOMMU pages where > the IOVA and the frames are aligned alike, and with smaller ones where > they are not. Only the pages of the block are mapped, as before. > > A large IOMMU page can only be unmapped whole, so a revoke that cuts > one widens its range to the whole page. It maps back what the provider > backs now, and a device may also fault on the rest of that page while > it is remapped. The widening finds the page with iova_to_phys(): > pages that only look like one large page make the revoke remap more > than it must, which is harmless. You are going to need to go into generic_pt and implement cut and a more suitable unmap to make this stuff work properly. We can't over unmap on conversions. > iommu_unmap() may not split the range of one map call either, and > virtio-iommu refuses to. Map each IOMMU page with its own call: the > widened range ends on IOMMU page boundaries, so it also ends on map > call boundaries. Also please don't write commit messages with AI. WTF is this even trying to say? The subject is "use large pages" and this text says "map each page with its own call" Jason