From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=52.13.214.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792633560; b=oxaUBQd/kVuk6dW1Gz2msdYoca/zpTY2I7Gn8tUbclh/N2PLaiZBKxYZjQ7JySnPpfdQ RWmuNwohxbHtB3ZN6f8ZjvPrl6Ns60SuZFc8S714iKmg1ZMt2YD/rmWkT49p1TgABxlK6 YzIREwVTPUYcjpoIHCgI++FIZGRZNRwlArdo/nfbbXAqJ3cZAQ9QDwSP0lmzyyMTO0OTn hi/c4F7ir2OopHqbIbMrnbwkL7sdsPwOpkKB4sp91I7udbmPQ8/t8cTQyKP4uNRjcLHLo GcbCXJi3BR9oxWUrqD7q1gtXDQRvGjr2j9EsDneZ6LEy4I9M2YLLKm66ryGFOxmk9/w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792633560; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:Received:Received:X-Farcaster-Flow-ID:Received:Received: From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type:X-Originating-IP: X-ClientProxiedBy; bh=xLMB1ywrrTdxqIzhaTH+VUPMZLazifwWEdIjfFjN15c=; b=bfO0JIDR037VmFuiirib5xcyuxxfpyQRUkMkzydM0m8ckegE6UbCt2EAbVF9w0mmZ5o+ TZJFmSHY8PzzRWNMahCxboB5qD3SUOi6e/SR36a0bZs1QA1HTQT9x7q3A7MVF7Y5W7IkB SBsLI43ME2yG0LCpDYk6+zYsiIeg9TzcpR4Av4R7hK7wXPNKWqlLHjsGFgVKeQJFMWIPA VQATMnoDmwOv7NEDUunSmSghiLsLaPZY3dqlQMF3RBa930T+UOSKl9NY0kKZfW+LT6i/6 GPTFxAql4tBTSNCBe+qZNDbidOIfKRCnuNOO3dmjQw9wDmO6TuIT1gv2WKYQhe0Nw7Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=K7fIJAml; arc=none smtp.remote-ip=52.13.214.179 Received: from pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com [52.13.214.179]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BEEE606A319 for ; Thu, 22 Oct 2026 01:46:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4BEEE606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=K7fIJAml DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1792633560; x=1824169560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xLMB1ywrrTdxqIzhaTH+VUPMZLazifwWEdIjfFjN15c=; b=K7fIJAmlfpTGy8djOCfJv3Tp50OIZLC1TdIdr7lCGZwQleNA/a9c2Bu8 sG/shg+u4gdE7tlCnUAt8JI57+qQyVsUYwj1lAd9fJhBDO7seFT0Q/il2 PTf3Fw0SiZ2mCnekpSzs3lAP2C6iH5eJeB0xYYdUiGwknCToohvAyvhpO BwQdbOGbqC2H7uDCMlKKsUKVb6/kscRHUJJnp9laUhUvVWbReC/FywseU VYOx/Smnb+Pf2HFMb0zKFdIm1Pv7+ai8R7WchkiUSCoMUTpkpO5fcaw8u COaUIf1TWmDNqSI+cGYHZLEEsPk9tY/DlujBALl8RegEYFE2IFqY/R90A A==; X-CSE-ConnectionGUID: e+B/0xB6QBiioe/cuu886w== X-CSE-MsgGUID: 6GDiqCXmSxuSoD7r4fsKuQ== X-IronPort-AV: E=Sophos;i="6.27,171,1787011200"; d="scan'208";a="31900364" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2026 01:45:59 +0000 Received: from EX19MTAUWC001.ant.amazon.com [205.251.233.53:7746] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.12.154:2525] with esmtp (Farcaster) id 68ea4192-e51f-41f1-aced-bca14cffc124; Thu, 22 Oct 2026 01:45:59 +0000 (UTC) X-Farcaster-Flow-ID: 68ea4192-e51f-41f1-aced-bca14cffc124 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC001.ant.amazon.com (10.250.64.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.49; Thu, 22 Oct 2026 01:45:59 +0000 Received: from dev-dsk-jamz-1e-e35f4cd9.us-east-1.amazon.com (10.189.35.140) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.53; Thu, 22 Oct 2026 01:45:58 +0000 From: Jimmy Zuber To: NeilBrown CC: Miklos Szeredi , , , Shuah Khan , "Bernd Schubert" , Jim Harris , "Horst Birthelmer" , Luis Henriques Subject: Re: [PATCH 1/3] fuse: add FUSE_OPEN_ATOMIC Date: Thu, 22 Oct 2026 01:45:45 +0000 Message-ID: <20261022014545.2495106-1-jamz@amazon.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <179253863737.1724252.12836488084615923712@noble.neil.brown.name> References: <20261020141647.3271341-1-jamz@amazon.com> <20261020141647.3271341-2-jamz@amazon.com> <179253863737.1724252.12836488084615923712@noble.neil.brown.name> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D031UWC001.ant.amazon.com (10.13.139.241) To EX19D001UWA001.ant.amazon.com (10.13.138.214) On Wed, 21 Oct 2026, NeilBrown wrote: > > + d_drop(entry); > > + res = d_splice_alias(inode, entry); > > As of f1ac607f786f d_splice_alias() handles hashed dentries > and the d_drop() is not needed and not wanted. Thanks. I'll rebase onto 7.4-rc1 (will make note of the dependency), which has the commit f1ac607f786f. > > - d_instantiate(entry, inode); > > + if (d_in_lookup(entry)) > > + d_splice_alias(inode, entry); > > + else > > + d_instantiate(entry, inode); > > Similar to above, d_splice_alias() is now sufficient for all cases. Thanks, fuse_create_open() also handles FUSE_TMPFILE, which needs d_instantiate() for its dentry to stay unhashed. Otherwise I can have it use d_splice_alias().