From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.83 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794668879; b=CtsditMcLgw11ckxE//oYyDHITyPpYl+gbaebgUSgAjvN61kDIcONE2RGmXK0yEZ20K/ np2HgzPmN/7miZdgZpDGIHO2xMdiAqsur8KJVYAmj+ng07hlfepxeedCKP9ASEhjo7FEE meuhfNBlfhnSwF7s+LvrhML6BnRGllUSsWJvoZOylVNiiANjJaWGus8TXA7TF72sdvf6K P6Dv0PZt21v5/zikmzTvRaFrIDlBSjc0cTG87UXQcPMZKDdUi/Qy10WWslzgB63SE/iM5 o+9yWvke/IHw6qlXwd5bFiT7+v2DYExXF503QCZMnjW9SVl/jBxCA+AzuFEfbdNJ06w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794668879; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=Uk64wFp7pPgEKa5YPAhY1PUZRgl5m7ofqmvbexSEZz0=; b=2b1HRxZFw98otAm1Oxwo8nReNJjE7aNKylLJ1pSfrl8dJBDyZ6VXXZ0jT7IUm9Hwf02h Mz7ROzLPNHJfLzlES/M4j5z2az9SyogifcJw+I95EQbaH50ySvGLZUxE5QoNzO7oPqVB9 ncfXRxcYO5TGyxGBW8r791j4jcrrK6Ye6uRVAXHOzYiSqAewFjdyvk2I46BJOJJsZTXm5 cTxLge75joV+5tG3j8WsTWEUR3fuwG+jHwX7EO/+CERQ5qvAY1Q4y3DChsaDDM8D8K5zP AgIp5ZOUNB1MLI8m2Seocoby4Ifg8rZphsqgWYdokdwmAbHssy6MGXYzAsTLh1oUm3w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=tyvTnv2o; arc=none smtp.remote-ip=95.215.58.83 Received: from mta1.migadu.com (out-83.mta1.migadu.com [95.215.58.83]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E9D606A331 for ; Sat, 14 Nov 2026 15:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85E9D606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=tyvTnv2o X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=rzlaMxPU8kAE4A/3f5vu23JkjxTU6YRrGbrFnA3m0xE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794668876; v=1; x=1795273676; b=tyvTnv2ojEpI2MGUyQbaiPlEHL8Ow9HRchTQ5vALuQgSdnlhP1JanssWKjCADeViuRkqjUkV 2LCXeXwzjRqt7BApHQkGfZ9b7XW6m3Hwtqbr7nWBEZuW2Mp9lGCc3/OtpNgXoIrrM2k90zOi7tn c2+y+lpH8BpnZoqFJb4TO+cc= X-Envelope-To: linux-kselftest@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 44dc21937f954fd7; Sat, 14 Nov 2026 15:07:56 +0000 X-Mizu-Trace-ID: 44dc21937f954fd7 X-Migadu-Flow: FLOW_OUT From: Leon Hwang To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , KP Singh , Matt Bobrowski , Shuah Khan , Leon Hwang , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH bpf-next v2 8/9] selftests/bpf: Verify iter link_create logs Date: Sat, 14 Nov 2026 23:06:09 +0800 Message-ID: <20261114150610.84507-9-leon.hwang@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261114150610.84507-1-leon.hwang@linux.dev> References: <20261114150610.84507-1-leon.hwang@linux.dev> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the error code, log message, and reported log size for invalid target FDs, flags, and iterator information. Also cover attaching a sleepable program to an iterator that does not support it. Signed-off-by: Leon Hwang --- .../selftests/bpf/prog_tests/iter_link.c | 156 ++++++++++++++++++ 1 file changed, 156 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/iter_link.c diff --git a/tools/testing/selftests/bpf/prog_tests/iter_link.c b/tools/testing/selftests/bpf/prog_tests/iter_link.c new file mode 100644 index 000000000000..623a84ba612d --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/iter_link.c @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include "bpf_iter_bpf_map.skel.h" + +static void test_iter_link_create_log(int target_fd, struct bpf_link_create_opts *opts, + __u64 flags, int err_exp, const char *msg) +{ + struct bpf_iter_bpf_map *skel; + char log_buf[128] = {}; + int err, fd, prog_fd; + LIBBPF_OPTS(bpf_log_opts, log_opts, + .buf = log_buf, + .size = sizeof(log_buf), + .level = 1, + ); + + skel = bpf_iter_bpf_map__open(); + if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_map__open")) + return; + + err = bpf_program__set_flags(skel->progs.dump_bpf_map, flags); + if (!ASSERT_OK(err, "bpf_program__set_flags")) + goto out; + + err = bpf_iter_bpf_map__load(skel); + if (!ASSERT_OK(err, "bpf_iter_bpf_map__load")) + goto out; + + opts->log_opts = &log_opts; + prog_fd = bpf_program__fd(skel->progs.dump_bpf_map); + fd = bpf_link_create(prog_fd, target_fd, BPF_TRACE_ITER, opts); + if (!ASSERT_LT(fd, 0, "bpf_link_create")) { + close(fd); + goto out; + } + + ASSERT_EQ(fd, err_exp, "err"); + ASSERT_STREQ(log_buf, msg, "log_buf"); + ASSERT_EQ(log_opts.true_size, strlen(msg) + 1, "log_size"); + +out: + bpf_iter_bpf_map__destroy(skel); +} + +static void test_log_invalid_target_fd(void) +{ + const char *msg = "Invalid target_fd.\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts); + + test_iter_link_create_log(-1, &opts, 0, -EINVAL, msg); +} + +static void test_log_invalid_flags(void) +{ + const char *msg = "Invalid flags.\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts, + .flags = 1, + ); + + test_iter_link_create_log(0, &opts, 0, -EINVAL, msg); +} + +static void test_log_iter_info_only(void) +{ + const char *msg = "iter_info and iter_info_len must be both set or both unset.\n"; + union bpf_iter_link_info info = {}; + LIBBPF_OPTS(bpf_link_create_opts, opts, + .iter.info = &info, + ); + + test_iter_link_create_log(0, &opts, 0, -EINVAL, msg); +} + +static void test_log_iter_info_len_only(void) +{ + const char *msg = "iter_info and iter_info_len must be both set or both unset.\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts, + .iter.len = sizeof(union bpf_iter_link_info), + ); + + test_iter_link_create_log(0, &opts, 0, -EINVAL, msg); +} + +static void test_log_invalid_iter_info(void) +{ + unsigned char info[sizeof(union bpf_iter_link_info) + 1] = {}; + const char *msg = "Invalid iter_info_len.\n"; + struct bpf_iter_bpf_map *skel; + struct bpf_link *link; + char log_buf[128] = {}; + LIBBPF_OPTS(bpf_log_opts, log_opts, + .buf = log_buf, + .size = sizeof(log_buf), + .level = 1, + ); + LIBBPF_OPTS(bpf_iter_attach_opts, opts, + .link_info = (union bpf_iter_link_info *)info, + .link_info_len = sizeof(info), + .log_opts = &log_opts, + ); + + skel = bpf_iter_bpf_map__open_and_load(); + if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_map__open_and_load")) + return; + + info[sizeof(info) - 1] = 1; + link = bpf_program__attach_iter(skel->progs.dump_bpf_map, &opts); + if (!ASSERT_ERR_PTR(link, "bpf_program__attach_iter")) { + bpf_link__destroy(link); + goto out; + } + + ASSERT_EQ(libbpf_get_error(link), -E2BIG, "err"); + ASSERT_STREQ(log_buf, msg, "log_buf"); + ASSERT_EQ(log_opts.true_size, strlen(msg) + 1, "log_size"); + +out: + bpf_iter_bpf_map__destroy(skel); +} + +static void test_log_invalid_iter_info_len(void) +{ + const char *msg = "Invalid iter_info.\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts, + .iter.info = (union bpf_iter_link_info *)1, + .iter.len = sizeof(union bpf_iter_link_info), + ); + + test_iter_link_create_log(0, &opts, 0, -EFAULT, msg); +} + +static void test_log_invalid_prog(void) +{ + const char *msg = "The iter target does not support the bpf prog.\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts); + + test_iter_link_create_log(0, &opts, BPF_F_SLEEPABLE, -EINVAL, msg); +} + +void test_iter_link_log(void) +{ + if (test__start_subtest("invalid_target_fd")) + test_log_invalid_target_fd(); + if (test__start_subtest("invalid_flags")) + test_log_invalid_flags(); + if (test__start_subtest("iter_info_only")) + test_log_iter_info_only(); + if (test__start_subtest("iter_info_len_only")) + test_log_iter_info_len_only(); + if (test__start_subtest("invalid_iter_info")) + test_log_invalid_iter_info(); + if (test__start_subtest("invalid_iter_info_len")) + test_log_invalid_iter_info_len(); + if (test__start_subtest("invalid_prog")) + test_log_invalid_prog(); +} -- 2.55.0