From: Joe Lawrence <joe.lawrence@redhat.com>
To: Filipe Xavier <felipeaggger@gmail.com>
Cc: Marcos Paulo de Souza <mpdesouza@suse.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>, Shuah Khan <shuah@kernel.org>,
live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Felipe Xavier <felipe_life@live.com>
Subject: Re: [PATCH] selftests: livepatch: test if ftrace can trace a livepatched function
Date: Sat, 11 Jan 2025 13:00:31 -0500 [thread overview]
Message-ID: <20867ce3-901c-7821-fe02-ccd223fdcf17@redhat.com> (raw)
In-Reply-To: <9edd671a-be5e-41c9-a8dc-b1fd1d5e3375@gmail.com>
On 1/10/25 12:13, Filipe Xavier wrote:
> Em 07/01/2025 13:23, Joe Lawrence escreveu:
>
>> On Thu, Jan 02, 2025 at 03:42:10PM -0300, Filipe Xavier wrote:
>>> This new test makes sure that ftrace can trace a
>>> function that was introduced by a livepatch.
>>>
>> Hi Filipe,
>>
>> Thanks for adding a test!
>>
>> Aside: another similar test could verify that the original function, in
>> this case cmdline_proc_show(), can still be traced despite it being
>> livepatched. That may be non-intuitive but it demonstrates how the
>> ftrace handler works.
>
> Thanks for the review Joe!
>
> I have fixed all points mentioned below,
>
> and have a patch ready to submit.
>
> Do you believe that this other similar test could be sent later,
>
> or is it required in this patch?
>
The second test could be added later if you like, either way is fine w/me.
Thanks,
--
Joe
prev parent reply other threads:[~2025-01-11 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 18:42 [PATCH] selftests: livepatch: test if ftrace can trace a livepatched function Filipe Xavier
2025-01-07 16:23 ` Joe Lawrence
2025-01-10 17:13 ` Filipe Xavier
2025-01-11 18:00 ` Joe Lawrence [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20867ce3-901c-7821-fe02-ccd223fdcf17@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=felipe_life@live.com \
--cc=felipeaggger@gmail.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox