From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D6B55897 for ; Fri, 26 Jul 2024 19:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722021896; cv=none; b=k+qkfwJo530jTK01DxQ5kRHstC8Ei2nTd1tDFO3CXi3D+2ZTWbIP+bdYJSnga+b44j9N6K2VAYWBWd0qix00Av+E72oIyKvuSM915esmOByDvyAHbrOCNJkGQhdmR85NW+sIl+d38oKzq5oVGuIb1vFJet3ASQ4orOiGE1mZW2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722021896; c=relaxed/simple; bh=0rldXxTm42IMY5pZAkh4BHK0b1KE3f0no1736ppFpW8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMmap7ScLaKBrr6yJPEpeoJYWc9+4Ag8g7KlztffuzVMuFCPrJygPuHpmaYwZIy3CjvLkVrbK/QjASg8mWn+C1K28H9fJM3659Ixiwrj4TUwZoIcc7h9GW+GY4ytP10FIQNCNaPl5aBfhbfCpyOYpv1Q576pph25zMVU//34RIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TStDRQ0u; arc=none smtp.client-ip=209.85.166.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TStDRQ0u" Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-81d05359badso11813539f.3 for ; Fri, 26 Jul 2024 12:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722021893; x=1722626693; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g8bPjvgxcg0NQqkD2IayRMVzQ8xyFyTCFKfJZrOpROk=; b=TStDRQ0uco8P/jTSpfDovOU+ytgxZ5DNLtPJXtFmPj0z76OxKrfVndQoW9VQEq9ls1 qHtvGBoe/w1q5z8qoc2j5N+xuguAntstqarMShUVaNQQ1YsO09SMbpr9/6TJowoeHAoc zAoXr04HuFKpa7CzLXaEelq+LO6EYFYD/CgWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722021893; x=1722626693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g8bPjvgxcg0NQqkD2IayRMVzQ8xyFyTCFKfJZrOpROk=; b=BmOYyBytafT2Ptd2vYqhEUGeEShWJyUvNUP5FwB0YDtbSODnzSmPsZxY63ocdEe5R4 if6gKOcejYD9/KGiVGIwxRJgaMyPWfYX698Nt4YOXQDywzMg9LOBtSDIh05PHwYl+c+Y DQmlgeV+ProHmGHaB9oj1/6YBZK8TtNAOAmLNjPbZe5DdfsvkbsgqiOQEd7HAPdskLee xVGM0M+Qu9Lr9TqqQgr5YDfzZZ/MgAYKslJM5RH9qJXmC43WVTNd386pEj1mEo64bO2H yAU5O3qA1YccpVJ48FOsNLhHgc7DTu+JH9uxIsz/eVQ+JFCx2kPXoBE/cDV4dBjoh1gz k07w== X-Forwarded-Encrypted: i=1; AJvYcCWn45fKAZ9dSr7ipL+iTpvpZ2B91y87txUYDe3gfTOu5MpnN7zL5j1SozMruRBU3HOZ4KuxY84DkP6qn9tb+Cs=@vger.kernel.org X-Gm-Message-State: AOJu0YxjWjKreF6jrs4N9lYjRvNGlSeAbKxthiDmQZ6wYaaUn5LGWQA3 Q2rzFaFuuyqLptJy7Dcl7tfEYulIv1bZN+UjuDnLTg/JUd/arRtUUltk8XLeIrY= X-Google-Smtp-Source: AGHT+IEpNVO685ix7hRt+JN/Kvx7SoZErJW5kTfbGwQ732dbBX2Lhszk8tucKhAxc2dRcxJz9qjwEg== X-Received: by 2002:a05:6e02:1c42:b0:383:297a:bdfb with SMTP id e9e14a558f8ab-39a22cc31b2mr43392525ab.2.1722021893473; Fri, 26 Jul 2024 12:24:53 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-39a22e974efsm16428515ab.19.2024.07.26.12.24.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 12:24:53 -0700 (PDT) Message-ID: <21671af5-94fe-48bd-a32e-d7f6204563f1@linuxfoundation.org> Date: Fri, 26 Jul 2024 13:24:52 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] bitmap: Rename module To: Muhammad Usama Anjum , Andrew Morton , Yury Norov , Rasmus Villemoes , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kees@kernel.org, David Gow , John Hubbard Cc: kernel@collabora.com, Shuah Khan References: <20240726110658.2281070-1-usama.anjum@collabora.com> <20240726110658.2281070-3-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240726110658.2281070-3-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/26/24 05:06, Muhammad Usama Anjum wrote: > Rename module to bitmap_kunit and rename the configuration option > compliant with kunit framework. > > Cc: kees@kernel.org > Signed-off-by: Muhammad Usama Anjum > --- > MAINTAINERS | 2 +- > lib/Kconfig.debug | 15 ++++++++------- > lib/Makefile | 2 +- > lib/{test_bitmap.c => bitmap_kunit.c} | 0 > 4 files changed, 10 insertions(+), 9 deletions(-) > rename lib/{test_bitmap.c => bitmap_kunit.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 12b870712da4a..289b727344d64 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3814,13 +3814,13 @@ F: include/linux/find.h > F: include/linux/nodemask.h > F: include/linux/nodemask_types.h > F: include/vdso/bits.h > +F: lib/bitmap_kunit.c > F: lib/bitmap-str.c > F: lib/bitmap.c > F: lib/cpumask.c > F: lib/cpumask_kunit.c > F: lib/find_bit.c > F: lib/find_bit_benchmark.c > -F: lib/test_bitmap.c > F: tools/include/linux/bitfield.h > F: tools/include/linux/bitmap.h > F: tools/include/linux/bits.h > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index a30c03a661726..6bb02990a73e7 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2420,13 +2420,6 @@ config TEST_PRINTF > config TEST_SCANF > tristate "Test scanf() family of functions at runtime" > > -config TEST_BITMAP > - tristate "Test bitmap_*() family of functions at runtime" > - help > - Enable this option to test the bitmap functions at boot. > - > - If unsure, say N. > - This change will take away the ability to run bitmap tests during boot on a non-kunit kernel. Nack on this change. I wan to see all tests that are being removed from lib because they have been converted - also it doesn't make sense to convert some tests like this one that add the ability test during boot. thanks, -- Shuah