From: Eduard Zingerman <eddyz87@gmail.com>
To: Benjamin Tissoires <bentiss@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] bpf: helpers: fix bpf_wq_set_callback_impl signature
Date: Fri, 05 Jul 2024 13:58:05 -0700 [thread overview]
Message-ID: <23da6ae19d3cc17b445b77e18e2ac98c490f9b7b.camel@gmail.com> (raw)
In-Reply-To: <20240705-fix-wq-v1-1-91b4d82cd825@kernel.org>
On Fri, 2024-07-05 at 15:44 +0200, Benjamin Tissoires wrote:
> I realized this while having a map containing both a struct bpf_timer and
> a struct bpf_wq: the third argument provided to the bpf_wq callback is
> not the struct bpf_wq pointer itself, but the pointer to the value in
> the map.
>
> Which means that the users need to double cast the provided "value" as
> this is not a struct bpf_wq *.
>
> This is a change of API, but there doesn't seem to be much users of bpf_wq
> right now, so we should be able to go with this right now.
>
> Fixes: 81f1d7a583fa ("bpf: wq: add bpf_wq_set_callback_impl")
> Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
> ---
Reviewed-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-07-05 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 13:44 [PATCH bpf-next 0/2] Small API fix for bpf_wq Benjamin Tissoires
2024-07-05 13:44 ` [PATCH bpf-next 1/2] bpf: helpers: fix bpf_wq_set_callback_impl signature Benjamin Tissoires
2024-07-05 20:58 ` Eduard Zingerman [this message]
2024-07-05 13:44 ` [PATCH bpf-next 2/2] selftests/bpf: amend for wrong " Benjamin Tissoires
2024-07-05 20:54 ` Eduard Zingerman
2024-07-07 0:53 ` Alexei Starovoitov
2024-07-08 9:50 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23da6ae19d3cc17b445b77e18e2ac98c490f9b7b.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bentiss@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox